Guillaume Nault 7702e7e9e3 selftests: pmtu.sh: Kill tcpdump processes launched by subshell. ... [ Upstream commit 18dfc66755 ] The cleanup() function takes care of killing processes launched by the test functions. It relies on variables like ${tcpdump_pids} to get the relevant PIDs. But tests are run in their own subshell, so updated *_pids values are invisible to other shells. Therefore cleanup() never sees any process to kill: $ ./tools/testing/selftests/net/pmtu.sh -t pmtu_ipv4_exception TEST: ipv4: PMTU exceptions [ OK ] TEST: ipv4: PMTU exceptions - nexthop objects [ OK ] $ pgrep -af tcpdump 6084 tcpdump -s 0 -i veth_A-R1 -w pmtu_ipv4_exception_veth_A-R1.pcap 6085 tcpdump -s 0 -i veth_R1-A -w pmtu_ipv4_exception_veth_R1-A.pcap 6086 tcpdump -s 0 -i veth_R1-B -w pmtu_ipv4_exception_veth_R1-B.pcap 6087 tcpdump -s 0 -i veth_B-R1 -w pmtu_ipv4_exception_veth_B-R1.pcap 6088 tcpdump -s 0 -i veth_A-R2 -w pmtu_ipv4_exception_veth_A-R2.pcap 6089 tcpdump -s 0 -i veth_R2-A -w pmtu_ipv4_exception_veth_R2-A.pcap 6090 tcpdump -s 0 -i veth_R2-B -w pmtu_ipv4_exception_veth_R2-B.pcap 6091 tcpdump -s 0 -i veth_B-R2 -w pmtu_ipv4_exception_veth_B-R2.pcap 6228 tcpdump -s 0 -i veth_A-R1 -w pmtu_ipv4_exception_veth_A-R1.pcap 6229 tcpdump -s 0 -i veth_R1-A -w pmtu_ipv4_exception_veth_R1-A.pcap 6230 tcpdump -s 0 -i veth_R1-B -w pmtu_ipv4_exception_veth_R1-B.pcap 6231 tcpdump -s 0 -i veth_B-R1 -w pmtu_ipv4_exception_veth_B-R1.pcap 6232 tcpdump -s 0 -i veth_A-R2 -w pmtu_ipv4_exception_veth_A-R2.pcap 6233 tcpdump -s 0 -i veth_R2-A -w pmtu_ipv4_exception_veth_R2-A.pcap 6234 tcpdump -s 0 -i veth_R2-B -w pmtu_ipv4_exception_veth_R2-B.pcap 6235 tcpdump -s 0 -i veth_B-R2 -w pmtu_ipv4_exception_veth_B-R2.pcap Fix this by running cleanup() in the context of the test subshell. Now that each test cleans the environment after completion, there's no need for calling cleanup() again when the next test starts. So let's drop it from the setup() function. This is okay because cleanup() is also called when pmtu.sh starts, so even the first test starts in a clean environment. Also, use tcpdump's immediate mode. Otherwise it might not have time to process buffered packets, resulting in missing packets or even empty pcap files for short tests. Note: PAUSE_ON_FAIL is still evaluated before cleanup(), so one can still inspect the test environment upon failure when using -p. Fixes: a92a0a7b8e ("selftests: pmtu: Simplify cleanup and namespace names") Signed-off-by: Guillaume Nault <gnault@redhat.com> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-16 14:15:59 +01:00
..
accounting
arch	x86/speculation: Rename RETPOLINE_AMD to RETPOLINE_LFENCE	2022-03-11 12:11:49 +01:00
bootconfig	tools/bootconfig: Fix tracing_on option checking in ftrace2bconf.sh	2021-09-26 14:08:59 +02:00
bpf	tools/resolve_btfids: Do not print any commands when building silently	2022-02-08 18:30:39 +01:00
build	tools build: Remove needless libpython-version feature check that breaks test-all fast path	2021-12-14 11:32:42 +01:00
cgroup	tools/cgroup/slabinfo.py: updated to work on current kernel	2021-05-07 11:04:31 +02:00
debugging
edid
firewire
firmware
gpio	tools: gpio: fix %llu warning in gpio-watch.c	2021-01-27 11:55:20 +01:00
hv
iio
include	tools/nolibc: fix incorrect truncation of exit code	2022-01-27 10:53:42 +01:00
io_uring
kvm/kvm_stat	tools/kvm_stat: Add restart delay	2021-04-16 11:43:20 +02:00
laptop
leds
lib	libsubcmd: Fix use-after-free for realloc(..., 0)	2022-02-23 12:01:02 +01:00
memory-model
objtool	objtool: Fix static_call list generation	2021-11-18 14:04:02 +01:00
pci
pcmcia
perf	perf data: Fix double free in perf_session__delete()	2022-03-02 11:42:48 +01:00
power	tweewide: Fix most Shebang lines	2021-05-22 11:40:55 +02:00
scripts	tools: Allow proper CC/CXX/... override with LLVM=1 in Makefile.include	2021-07-31 08:16:10 +02:00
spi
testing	selftests: pmtu.sh: Kill tcpdump processes launched by subshell.	2022-03-16 14:15:59 +01:00
thermal/tmon	tools/thermal/tmon: Add cross compiling support	2021-09-18 13:40:07 +02:00
time
usb	usb: testusb: Fix for showing the connection speed	2021-10-09 14:40:56 +02:00
virtio	tools/virtio: fix build	2021-09-03 10:09:27 +02:00
vm	tools/vm/page-types: remove dependency on opt_file for idle page tracking	2021-10-09 14:40:57 +02:00
wmi
Makefile