Amir Goldstein 20663629f6 fanotify: fix handling of events on child sub-directory ... commit b469e7e47c upstream. When an event is reported on a sub-directory and the parent inode has a mark mask with FS_EVENT_ON_CHILD|FS_ISDIR, the event will be sent to fsnotify() even if the event type is not in the parent mark mask (e.g. FS_OPEN). Further more, if that event happened on a mount or a filesystem with a mount/sb mark that does have that event type in their mask, the "on child" event will be reported on the mount/sb mark. That is not desired, because user will get a duplicate event for the same action. Note that the event reported on the victim inode is never merged with the event reported on the parent inode, because of the check in should_merge(): old_fsn->inode == new_fsn->inode. Fix this by looking for a match of an actual event type (i.e. not just FS_ISDIR) in parent's inode mark mask and by not reporting an "on child" event to group if event type is only found on mount/sb marks. [backport hint: The bug seems to have always been in fanotify, but this patch will only apply cleanly to v4.19.y] Cc: <stable@vger.kernel.org> # v4.19 Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz> [amir: backport to v4.19] Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-12-01 09:37:31 +01:00
..
dnotify	Merge branch 'siginfo-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2018-08-21 13:47:29 -07:00
fanotify	fanotify: fix handling of events on child sub-directory	2018-12-01 09:37:31 +01:00
inotify	Merge branch 'akpm' (patches from Andrew)	2018-08-17 16:49:31 -07:00
fdinfo.c	fsnotify: let connector point to an abstract object	2018-06-27 13:45:05 +02:00
fdinfo.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fsnotify.c	fanotify: fix handling of events on child sub-directory	2018-12-01 09:37:31 +01:00
fsnotify.h	fsnotify: let connector point to an abstract object	2018-06-27 13:45:05 +02:00
group.c	fs: fsnotify: account fsnotify metadata to kmemcg	2018-08-17 16:20:30 -07:00
Kconfig	rcu: Make SRCU optional by using CONFIG_SRCU	2015-01-06 11:04:29 -08:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mark.c	fsnotify: Fix busy inodes during unmount	2018-11-13 11:08:50 -08:00
notification.c	fsnotify: Let userspace know about lost events due to ENOMEM	2018-02-27 10:25:33 +01:00