Amir Goldstein 2a33522994 ovl: fix missing override creds in link of a metacopy upper ... commit 91ff20f34e upstream. Theodore Ts'o reported a v4.19 regression with docker-dropbox: https://marc.info/?l=linux-fsdevel&m=154070089431116&w=2 "I was rebuilding my dropbox Docker container, and it failed in 4.19 with the following error: ... dpkg: error: error creating new backup file \ '/var/lib/dpkg/status-old': Invalid cross-device link" The problem did not reproduce with metacopy feature disabled. The error was caused by insufficient credentials to set "trusted.overlay.redirect" xattr on link of a metacopy file. Reproducer: echo Y > /sys/module/overlay/parameters/redirect_dir echo Y > /sys/module/overlay/parameters/metacopy cd /tmp mkdir l u w m chmod 777 l u touch l/foo ln l/foo l/link chmod 666 l/foo mount -t overlay none -olowerdir=l,upperdir=u,workdir=w m su fsgqa ln m/foo m/bar [ 21.455823] overlayfs: failed to set redirect (-1) ln: failed to create hard link 'm/bar' => 'm/foo':\ Invalid cross-device link Reported-by: Theodore Y. Ts'o <tytso@mit.edu> Reported-by: Maciej Zięba <maciekz82@gmail.com> Fixes: 4120fe64dc ("ovl: Set redirect on upper inode when it is linked") Cc: <stable@vger.kernel.org> # v4.19 Signed-off-by: Amir Goldstein <amir73il@gmail.com> Acked-by: Vivek Goyal <vgoyal@redhat.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-12-19 19:19:51 +01:00
..
copy_up.c	vfs: swap names of {do,vfs}_clone_file_range()	2018-09-24 10:54:01 +02:00
dir.c	ovl: fix missing override creds in link of a metacopy upper	2018-12-19 19:19:51 +01:00
export.c	ovl: fix decode of dir file handle with multi lower layers	2018-12-19 19:19:51 +01:00
file.c	vfs: swap names of {do,vfs}_clone_file_range()	2018-09-24 10:54:01 +02:00
inode.c	ovl: make symbol 'ovl_aops' static	2018-09-25 20:41:23 +02:00
Kconfig	ovl: Provide a mount option metacopy=on/off for metadata copyup	2018-07-20 09:56:06 +02:00
Makefile	ovl: stack file ops	2018-07-18 15:44:41 +02:00
namei.c	ovl: fix error handling in ovl_verify_set_fh()	2018-11-21 09:19:12 +01:00
overlayfs.h	ovl: fix format of setxattr debug	2018-10-04 14:49:10 +02:00
ovl_entry.h	ovl: Store lower data inode in ovl_inode	2018-07-20 09:56:11 +02:00
readdir.c	ovl: fix wrong use of impure dir cache in ovl_iterate()	2018-07-17 16:04:34 +02:00
super.c	ovl: automatically enable redirect_dir on metacopy=on	2018-11-21 09:19:13 +01:00
util.c	ovl: fix memory leak on unlink of indexed file	2018-09-24 10:54:01 +02:00