mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-29 20:30:35 +00:00
![Christophe Leroy](/assets/img/avatar_default.png)
'struct ppc_inst' is an internal representation of an instruction, but in-memory instructions are and will remain a table of 'u32' forever. Replace all 'struct ppc_inst *' used for locating an instruction in memory by 'u32 *'. This removes a lot of undue casts to 'struct ppc_inst *'. It also helps locating ab-use of 'struct ppc_inst' dereference. Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> [mpe: Fix ppc_inst_next(), use u32 instead of unsigned int] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/7062722b087228e42cbd896e39bfdf526d6a340a.1621516826.git.christophe.leroy@csgroup.eu
30 lines
717 B
C
30 lines
717 B
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
#include <linux/uaccess.h>
|
|
#include <linux/kernel.h>
|
|
|
|
#include <asm/disassemble.h>
|
|
#include <asm/inst.h>
|
|
#include <asm/ppc-opcode.h>
|
|
|
|
bool copy_from_kernel_nofault_allowed(const void *unsafe_src, size_t size)
|
|
{
|
|
return is_kernel_addr((unsigned long)unsafe_src);
|
|
}
|
|
|
|
int copy_inst_from_kernel_nofault(struct ppc_inst *inst, u32 *src)
|
|
{
|
|
unsigned int val, suffix;
|
|
int err;
|
|
|
|
err = copy_from_kernel_nofault(&val, src, sizeof(val));
|
|
if (err)
|
|
return err;
|
|
if (IS_ENABLED(CONFIG_PPC64) && get_op(val) == OP_PREFIX) {
|
|
err = copy_from_kernel_nofault(&suffix, src + 1, sizeof(suffix));
|
|
*inst = ppc_inst_prefix(val, suffix);
|
|
} else {
|
|
*inst = ppc_inst(val);
|
|
}
|
|
return err;
|
|
}
|