mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-29 20:30:35 +00:00
![Stephen Rothwell](/assets/img/avatar_default.png)
Currently, using llvm-objtool, this script just silently succeeds without actually do the intended checking. So this updates it to work properly. Firstly, llvm-objdump does not add target symbol names to the end of branches in its asm output, so we have to drop the branch to __start_initialization_multiplatform using its address. Secondly, v9 and 10 specify branch targets as .+<offset>, so we convert those to actual addresses. Thirdly, v10 and 11 error out on a vmlinux if given the -R option complaining that it is "not a dynamic object". The -R does not make any difference to the asm output, so remove it. Lastly, v11 produces asm that is very similar to Gnu objtool (at least as far as branches are concerned), so no further changes are necessary to make it work. Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200812081036.7969-3-sfr@canb.auug.org.au
79 lines
1.8 KiB
Bash
Executable file
79 lines
1.8 KiB
Bash
Executable file
#!/bin/bash
|
|
# SPDX-License-Identifier: GPL-2.0+
|
|
# Copyright © 2016,2020 IBM Corporation
|
|
#
|
|
# This script checks the unrelocated code of a vmlinux for "suspicious"
|
|
# branches to relocated code (head_64.S code).
|
|
|
|
# Have Kbuild supply the path to objdump and nm so we handle cross compilation.
|
|
objdump="$1"
|
|
nm="$2"
|
|
vmlinux="$3"
|
|
|
|
kstart=0xc000000000000000
|
|
|
|
end_intr=0x$($nm -p "$vmlinux" |
|
|
sed -E -n '/\s+[[:alpha:]]\s+__end_interrupts\s*$/{s///p;q}')
|
|
if [ "$end_intr" = "0x" ]; then
|
|
exit 0
|
|
fi
|
|
|
|
# we know that there is a correct branch to
|
|
# __start_initialization_multiplatform, so find its address
|
|
# so we can exclude it.
|
|
sim=0x$($nm -p "$vmlinux" |
|
|
sed -E -n '/\s+[[:alpha:]]\s+__start_initialization_multiplatform\s*$/{s///p;q}')
|
|
|
|
$objdump -D --no-show-raw-insn --start-address="$kstart" --stop-address="$end_intr" "$vmlinux" |
|
|
sed -E -n '
|
|
# match lines that start with a kernel address
|
|
/^c[0-9a-f]*:\s*b/ {
|
|
# drop branches via ctr or lr
|
|
/\<b.?.?(ct|l)r/d
|
|
# cope with some differences between Clang and GNU objdumps
|
|
s/\<bt.?\s*[[:digit:]]+,/beq/
|
|
s/\<bf.?\s*[[:digit:]]+,/bne/
|
|
# tidy up
|
|
s/\s0x/ /
|
|
s/://
|
|
# format for the loop below
|
|
s/^(\S+)\s+(\S+)\s+(\S+)\s*(\S*).*$/\1:\2:\3:\4/
|
|
# strip out condition registers
|
|
s/:cr[0-7],/:/
|
|
p
|
|
}' | {
|
|
|
|
all_good=true
|
|
while IFS=: read -r from branch to sym; do
|
|
case "$to" in
|
|
c*) to="0x$to"
|
|
;;
|
|
.+*)
|
|
to=${to#.+}
|
|
if [ "$branch" = 'b' ]; then
|
|
if (( to >= 0x2000000 )); then
|
|
to=$(( to - 0x4000000 ))
|
|
fi
|
|
elif (( to >= 0x8000 )); then
|
|
to=$(( to - 0x10000 ))
|
|
fi
|
|
printf -v to '0x%x' $(( "0x$from" + to ))
|
|
;;
|
|
*) printf 'Unkown branch format\n'
|
|
;;
|
|
esac
|
|
if [ "$to" = "$sim" ]; then
|
|
continue
|
|
fi
|
|
if (( to > end_intr )); then
|
|
if $all_good; then
|
|
printf '%s\n' 'WARNING: Unrelocated relative branches'
|
|
all_good=false
|
|
fi
|
|
printf '%s %s-> %s %s\n' "$from" "$branch" "$to" "$sym"
|
|
fi
|
|
done
|
|
|
|
$all_good
|
|
|
|
}
|