mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
![Masami Ichikawa](/assets/img/avatar_default.png)
kmemleak reported a memory leak as below. unreferenced object 0xffff880118f14700 (size 32): comm "swapper/0", pid 1, jiffies 4294877401 (age 123.283s) hex dump (first 32 bytes): 00 01 10 00 00 00 ad de 00 02 20 00 00 00 ad de .......... ..... 00 d4 d2 18 01 88 ff ff 01 00 00 00 00 04 00 00 ................ backtrace: [<ffffffff814edb1e>] kmemleak_alloc+0x4e/0xb0 [<ffffffff811889dc>] kmem_cache_alloc_trace+0x1ec/0x260 [<ffffffff810aba66>] pm_vt_switch_required+0x76/0xb0 [<ffffffff812f39f5>] register_framebuffer+0x195/0x320 [<ffffffff8130af18>] efifb_probe+0x718/0x780 [<ffffffff81391495>] platform_drv_probe+0x45/0xb0 [<ffffffff8138f407>] driver_probe_device+0x87/0x3a0 [<ffffffff8138f7f3>] __driver_attach+0x93/0xa0 [<ffffffff8138d413>] bus_for_each_dev+0x63/0xa0 [<ffffffff8138ee5e>] driver_attach+0x1e/0x20 [<ffffffff8138ea40>] bus_add_driver+0x180/0x250 [<ffffffff8138fe74>] driver_register+0x64/0xf0 [<ffffffff813913ba>] __platform_driver_register+0x4a/0x50 [<ffffffff8191e028>] efifb_driver_init+0x12/0x14 [<ffffffff8100214a>] do_one_initcall+0xfa/0x1b0 [<ffffffff818e40e0>] kernel_init_freeable+0x17b/0x201 In pm_vt_switch_required(), "entry" variable is allocated via kmalloc(). So, in pm_vt_switch_unregister(), it needs to call kfree() when object is deleted from list. Signed-off-by: Masami Ichikawa <masami256@gmail.com> Reviewed-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
150 lines
3.4 KiB
C
150 lines
3.4 KiB
C
/*
|
|
* Functions for saving/restoring console.
|
|
*
|
|
* Originally from swsusp.
|
|
*/
|
|
|
|
#include <linux/console.h>
|
|
#include <linux/vt_kern.h>
|
|
#include <linux/kbd_kern.h>
|
|
#include <linux/vt.h>
|
|
#include <linux/module.h>
|
|
#include "power.h"
|
|
|
|
#define SUSPEND_CONSOLE (MAX_NR_CONSOLES-1)
|
|
|
|
static int orig_fgconsole, orig_kmsg;
|
|
|
|
static DEFINE_MUTEX(vt_switch_mutex);
|
|
|
|
struct pm_vt_switch {
|
|
struct list_head head;
|
|
struct device *dev;
|
|
bool required;
|
|
};
|
|
|
|
static LIST_HEAD(pm_vt_switch_list);
|
|
|
|
|
|
/**
|
|
* pm_vt_switch_required - indicate VT switch at suspend requirements
|
|
* @dev: device
|
|
* @required: if true, caller needs VT switch at suspend/resume time
|
|
*
|
|
* The different console drivers may or may not require VT switches across
|
|
* suspend/resume, depending on how they handle restoring video state and
|
|
* what may be running.
|
|
*
|
|
* Drivers can indicate support for switchless suspend/resume, which can
|
|
* save time and flicker, by using this routine and passing 'false' as
|
|
* the argument. If any loaded driver needs VT switching, or the
|
|
* no_console_suspend argument has been passed on the command line, VT
|
|
* switches will occur.
|
|
*/
|
|
void pm_vt_switch_required(struct device *dev, bool required)
|
|
{
|
|
struct pm_vt_switch *entry, *tmp;
|
|
|
|
mutex_lock(&vt_switch_mutex);
|
|
list_for_each_entry(tmp, &pm_vt_switch_list, head) {
|
|
if (tmp->dev == dev) {
|
|
/* already registered, update requirement */
|
|
tmp->required = required;
|
|
goto out;
|
|
}
|
|
}
|
|
|
|
entry = kmalloc(sizeof(*entry), GFP_KERNEL);
|
|
if (!entry)
|
|
goto out;
|
|
|
|
entry->required = required;
|
|
entry->dev = dev;
|
|
|
|
list_add(&entry->head, &pm_vt_switch_list);
|
|
out:
|
|
mutex_unlock(&vt_switch_mutex);
|
|
}
|
|
EXPORT_SYMBOL(pm_vt_switch_required);
|
|
|
|
/**
|
|
* pm_vt_switch_unregister - stop tracking a device's VT switching needs
|
|
* @dev: device
|
|
*
|
|
* Remove @dev from the vt switch list.
|
|
*/
|
|
void pm_vt_switch_unregister(struct device *dev)
|
|
{
|
|
struct pm_vt_switch *tmp;
|
|
|
|
mutex_lock(&vt_switch_mutex);
|
|
list_for_each_entry(tmp, &pm_vt_switch_list, head) {
|
|
if (tmp->dev == dev) {
|
|
list_del(&tmp->head);
|
|
kfree(tmp);
|
|
break;
|
|
}
|
|
}
|
|
mutex_unlock(&vt_switch_mutex);
|
|
}
|
|
EXPORT_SYMBOL(pm_vt_switch_unregister);
|
|
|
|
/*
|
|
* There are three cases when a VT switch on suspend/resume are required:
|
|
* 1) no driver has indicated a requirement one way or another, so preserve
|
|
* the old behavior
|
|
* 2) console suspend is disabled, we want to see debug messages across
|
|
* suspend/resume
|
|
* 3) any registered driver indicates it needs a VT switch
|
|
*
|
|
* If none of these conditions is present, meaning we have at least one driver
|
|
* that doesn't need the switch, and none that do, we can avoid it to make
|
|
* resume look a little prettier (and suspend too, but that's usually hidden,
|
|
* e.g. when closing the lid on a laptop).
|
|
*/
|
|
static bool pm_vt_switch(void)
|
|
{
|
|
struct pm_vt_switch *entry;
|
|
bool ret = true;
|
|
|
|
mutex_lock(&vt_switch_mutex);
|
|
if (list_empty(&pm_vt_switch_list))
|
|
goto out;
|
|
|
|
if (!console_suspend_enabled)
|
|
goto out;
|
|
|
|
list_for_each_entry(entry, &pm_vt_switch_list, head) {
|
|
if (entry->required)
|
|
goto out;
|
|
}
|
|
|
|
ret = false;
|
|
out:
|
|
mutex_unlock(&vt_switch_mutex);
|
|
return ret;
|
|
}
|
|
|
|
int pm_prepare_console(void)
|
|
{
|
|
if (!pm_vt_switch())
|
|
return 0;
|
|
|
|
orig_fgconsole = vt_move_to_console(SUSPEND_CONSOLE, 1);
|
|
if (orig_fgconsole < 0)
|
|
return 1;
|
|
|
|
orig_kmsg = vt_kmsg_redirect(SUSPEND_CONSOLE);
|
|
return 0;
|
|
}
|
|
|
|
void pm_restore_console(void)
|
|
{
|
|
if (!pm_vt_switch())
|
|
return;
|
|
|
|
if (orig_fgconsole >= 0) {
|
|
vt_move_to_console(orig_fgconsole, 0);
|
|
vt_kmsg_redirect(orig_kmsg);
|
|
}
|
|
}
|