Jeff Layton 827a746f40 netfs: fix test for whether we can skip read when writing beyond EOF ... It's not sufficient to skip reading when the pos is beyond the EOF. There may be data at the head of the page that we need to fill in before the write. Add a new helper function that corrects and clarifies the logic of when we can skip reads, and have it only zero out the part of the page that won't have data copied in for the write. Finally, don't set the page Uptodate after zeroing. It's not up to date since the write data won't have been copied in yet. [DH made the following changes: - Prefixed the new function with "netfs_". - Don't call zero_user_segments() for a full-page write. - Altered the beyond-last-page check to avoid a DIV instruction and got rid of then-redundant zero-length file check. ] Fixes: e1b1240c1f ("netfs: Add write_begin helper") Reported-by: Andrew W Elble <aweits@rit.edu> Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> cc: ceph-devel@vger.kernel.org Link: https://lore.kernel.org/r/20210613233345.113565-1-jlayton@kernel.org/ Link: https://lore.kernel.org/r/162367683365.460125.4467036947364047314.stgit@warthog.procyon.org.uk/ # v1 Link: https://lore.kernel.org/r/162391826758.1173366.11794946719301590013.stgit@warthog.procyon.org.uk/ # v2		2021-06-21 21:24:07 +01:00
..
internal.h	netfs: Add write_begin helper	2021-04-23 10:14:32 +01:00
Kconfig	netfs: Make CONFIG_NETFS_SUPPORT auto-selected rather than manual	2021-05-25 13:48:04 +01:00
Makefile	netfs: Gather stats	2021-04-23 10:14:32 +01:00
read_helper.c	netfs: fix test for whether we can skip read when writing beyond EOF	2021-06-21 21:24:07 +01:00
stats.c	netfs: Add write_begin helper	2021-04-23 10:14:32 +01:00