Johannes Weiner 25cd241408 mm: zswap: fix data loss on SWP_SYNCHRONOUS_IO devices ... Zhongkun He reports data corruption when combining zswap with zram. The issue is the exclusive loads we're doing in zswap. They assume that all reads are going into the swapcache, which can assume authoritative ownership of the data and so the zswap copy can go. However, zram files are marked SWP_SYNCHRONOUS_IO, and faults will try to bypass the swapcache. This results in an optimistic read of the swap data into a page that will be dismissed if the fault fails due to races. In this case, zswap mustn't drop its authoritative copy. Link: https://lore.kernel.org/all/CACSyD1N+dUvsu8=zV9P691B9bVq33erwOXNTmEaUbi9DrDeJzw@mail.gmail.com/ Fixes: b9c91c4341 ("mm: zswap: support exclusive loads") Link: https://lkml.kernel.org/r/20240324210447.956973-1-hannes@cmpxchg.org Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Reported-by: Zhongkun He <hezhongkun.hzk@bytedance.com> Tested-by: Zhongkun He <hezhongkun.hzk@bytedance.com> Acked-by: Yosry Ahmed <yosryahmed@google.com> Acked-by: Barry Song <baohua@kernel.org> Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev> Reviewed-by: Nhat Pham <nphamcs@gmail.com> Acked-by: Chris Li <chrisl@kernel.org> Cc: <stable@vger.kernel.org> [6.5+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2024-03-26 11:14:12 -07:00
..
damon	mm: madvise: pageout: ignore references rather than clearing young	2024-03-04 17:01:18 -08:00
kasan	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
kfence	…
kmsan	mm: kmsan: remove runtime checks from kmsan_unpoison_memory()	2024-02-22 10:24:41 -08:00
Kconfig	Kbuild updates for v6.9	2024-03-21 14:41:00 -07:00
Kconfig.debug	…
Makefile	…
backing-dev.c	vfs-6.9.misc	2024-03-11 09:38:17 -07:00
balloon_compaction.c	…
bootmem_info.c	…
cma.c	mm/cma: add sysfs file 'release_pages_success'	2024-02-22 10:24:57 -08:00
cma.h	mm/cma: add sysfs file 'release_pages_success'	2024-02-22 10:24:57 -08:00
cma_debug.c	…
cma_sysfs.c	mm/cma: add sysfs file 'release_pages_success'	2024-02-22 10:24:57 -08:00
compaction.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
debug.c	mm: make dump_page() take a const argument	2024-03-06 13:04:18 -08:00
debug_page_alloc.c	…
debug_page_ref.c	…
debug_vm_pgtable.c	mm/debug_vm_pgtable: fix BUG_ON with pud advanced test	2024-02-23 17:27:13 -08:00
dmapool.c	…
dmapool_test.c	…
early_ioremap.c	…
fadvise.c	…
fail_page_alloc.c	…
failslab.c	…
filemap.c	mm: cachestat: fix two shmem bugs	2024-03-26 11:07:20 -07:00
folio-compat.c	…
gup.c	…
gup_test.c	…
gup_test.h	…
highmem.c	…
hmm.c	…
huge_memory.c	mm/huge_memory: skip invalid debugfs new_order input for folio split	2024-03-12 13:07:17 -07:00
hugetlb.c	mm: add an explicit smp_wmb() to UFFDIO_CONTINUE	2024-03-12 13:07:17 -07:00
hugetlb_cgroup.c	…
hugetlb_vmemmap.c	…
hugetlb_vmemmap.h	…
hwpoison-inject.c	…
init-mm.c	…
internal.h	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
interval_tree.c	…
io-mapping.c	…
ioremap.c	…
khugepaged.c	mm: convert free_swap_cache() to take a folio	2024-03-04 17:01:26 -08:00
kmemleak.c	…
ksm.c	…
list_lru.c	mm/zswap: stop lru list shrinking when encounter warm region	2024-02-22 10:24:54 -08:00
maccess.c	…
madvise.c	mm: madvise: pageout: ignore references rather than clearing young	2024-03-04 17:01:18 -08:00
mapping_dirty_helpers.c	…
memblock.c	cxl fixes for 6.8-rc6	2024-02-24 15:53:40 -08:00
memcontrol.c	memcg: remove mem_cgroup_uncharge_list()	2024-03-04 17:01:25 -08:00
memfd.c	mm/memfd: refactor memfd_tag_pins() and memfd_wait_for_pins()	2024-03-04 17:01:21 -08:00
memory-failure.c	…
memory-tiers.c	mm/demotion: print demotion targets	2024-02-22 10:24:55 -08:00
memory.c	mm/memory: fix missing pte marker for !page on pte zaps	2024-03-26 11:07:19 -07:00
memory_hotplug.c	mm/memory_hotplug: export mhp_supports_memmap_on_memory()	2024-02-22 10:24:40 -08:00
mempolicy.c	mm/mempolicy: use a folio in do_mbind()	2024-03-06 13:04:18 -08:00
mempool.c	mempool: kvmalloc pool	2024-03-13 18:38:13 -04:00
memremap.c	…
memtest.c	memtest: use {READ,WRITE}_ONCE in memory scanning	2024-03-13 12:12:21 -07:00
migrate.c	merge mm-hotfixes-stable into mm-nonmm-stable to pick up stackdepot changes	2024-02-23 17:28:43 -08:00
migrate_device.c	…
mincore.c	…
mlock.c	mm: make folios_put() the basis of release_pages()	2024-03-04 17:01:22 -08:00
mm_init.c	Author: Gang Li padata: dispatch works on	2024-03-06 13:04:17 -08:00
mm_slot.h	…
mmap.c	RISC-V Patches for the 6.9 Merge Window	2024-03-22 10:41:13 -07:00
mmap_lock.c	…
mmu_gather.c	mm/mmu_gather: improve cond_resched() handling with large folios and expensive page freeing	2024-02-22 15:27:17 -08:00
mmu_notifier.c	…
mmzone.c	…
mprotect.c	mprotect: use pfn_swap_entry_folio	2024-02-21 16:00:03 -08:00
mremap.c	…
msync.c	…
nommu.c	mm/vmalloc: remove vmap_area_list	2024-02-23 17:48:19 -08:00
oom_kill.c	mm: update mark_victim tracepoints fields	2024-03-04 17:01:16 -08:00
page-writeback.c	writeback: remove a use of write_cache_pages() from do_writepages()	2024-02-23 17:48:38 -08:00
page_alloc.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
page_counter.c	…
page_ext.c	…
page_idle.c	…
page_io.c	…
page_isolation.c	mm: add alloc_contig_migrate_range allocation statistics	2024-03-04 17:01:27 -08:00
page_owner.c	mm,page_owner: fix recursion	2024-03-26 11:07:20 -07:00
page_poison.c	…
page_reporting.c	…
page_reporting.h	…
page_table_check.c	…
page_vma_mapped.c	…
pagewalk.c	…
percpu-internal.h	…
percpu-km.c	…
percpu-stats.c	…
percpu-vm.c	…
percpu.c	…
pgalloc-track.h	…
pgtable-generic.c	…
process_vm_access.c	…
ptdump.c	mm: ptdump: add check_wx_pages debugfs attribute	2024-02-22 10:24:47 -08:00
readahead.c	mm: support order-1 folios in the page cache	2024-03-04 17:01:19 -08:00
rmap.c	rmap: replace two calls to compound_order with folio_order	2024-02-22 15:27:20 -08:00
rodata_test.c	…
secretmem.c	…
shmem.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
shmem_quota.c	tmpfs: fix race on handling dquot rbtree	2024-03-26 11:07:23 -07:00
show_mem.c	…
shrinker.c	…
shrinker_debug.c	…
shuffle.c	…
shuffle.h	…
slab.h	Merge branch 'slab/for-6.9/slab-flag-cleanups' into slab/for-linus	2024-03-12 10:16:56 +01:00
slab_common.c	- Kuan-Wei Chiu has developed the well-named series "lib min_heap: Min	2024-03-14 18:03:09 -07:00
slub.c	Merge branch 'slab/for-6.9/slab-flag-cleanups' into slab/for-linus	2024-03-12 10:16:56 +01:00
sparse-vmemmap.c	…
sparse.c	mm/memory_hotplug: introduce MEM_PREPARE_ONLINE/MEM_FINISH_OFFLINE notifiers	2024-02-21 16:00:01 -08:00
swap.c	mm: fix list corruption in put_pages_list	2024-03-12 13:07:16 -07:00
swap.h	mm/swap: fix race when skipping swapcache	2024-02-20 14:20:48 -08:00
swap_cgroup.c	…
swap_slots.c	mm/zswap: invalidate zswap entry when swap entry free	2024-02-22 10:24:54 -08:00
swap_state.c	mm: convert free_swap_cache() to take a folio	2024-03-04 17:01:26 -08:00
swapfile.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
truncate.c	…
usercopy.c	…
userfaultfd.c	userfaultfd: fix deadlock warning when locking src and dst VMAs	2024-03-26 11:07:23 -07:00
util.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
vmalloc.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
vmpressure.c	…
vmscan.c	- Sumanth Korikkar has taught s390 to allocate hotplug-time page frames	2024-03-14 17:43:30 -07:00
vmstat.c	…
workingset.c	mm: move mapping_set_update out of <linux/swap.h>	2024-02-21 11:36:50 +05:30
z3fold.c	mm/z3fold: fix the comment for __encode_handle()	2024-02-23 17:48:31 -08:00
zbud.c	…
zpool.c	…
zsmalloc.c	mm/zsmalloc: don't need to reserve LSB in handle	2024-03-04 17:01:28 -08:00
zswap.c	mm: zswap: fix data loss on SWP_SYNCHRONOUS_IO devices	2024-03-26 11:14:12 -07:00