linux-stable/tools/testing/selftests/net/mptcp
Davide Caratti 7a1b3490f4 mptcp: don't account accept() of non-MPC client as fallback to TCP
Current MPTCP servers increment MPTcpExtMPCapableFallbackACK when they
accept non-MPC connections. As reported by Christoph, this is "surprising"
because the counter might become greater than MPTcpExtMPCapableSYNRX.

MPTcpExtMPCapableFallbackACK counter's name suggests it should only be
incremented when a connection was seen using MPTCP options, then a
fallback to TCP has been done. Let's do that by incrementing it when
the subflow context of an inbound MPC connection attempt is dropped.
Also, update mptcp_connect.sh kselftest, to ensure that the
above MIB does not increment in case a pure TCP client connects to a
MPTCP server.

Fixes: fc518953bc ("mptcp: add and use MIB counter infrastructure")
Cc: stable@vger.kernel.org
Reported-by: Christoph Paasch <cpaasch@apple.com>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/449
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240329-upstream-net-20240329-fallback-mib-v1-1-324a8981da48@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-04-01 21:25:00 -07:00
..
.gitignore
Makefile selftests: mptcp: connect: skip if MPTCP is not supported 2023-05-30 13:21:02 +02:00
config selftests: mptcp: add missing kconfig for NF Mangle 2024-02-01 09:06:37 -08:00
diag.sh selftests: mptcp: print test results with colors 2024-03-11 15:07:26 -07:00
mptcp_connect.c selftests/net: mptcp: fix uninitialized variable warnings 2023-11-27 18:12:07 -08:00
mptcp_connect.sh mptcp: don't account accept() of non-MPC client as fallback to TCP 2024-04-01 21:25:00 -07:00
mptcp_inq.c selftests/net: mptcp: fix uninitialized variable warnings 2023-11-27 18:12:07 -08:00
mptcp_join.sh selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL 2024-03-11 15:07:27 -07:00
mptcp_lib.sh selftests: mptcp: declare event macros in mptcp_lib 2024-03-11 15:07:27 -07:00
mptcp_sockopt.c selftests: mptcp: add MPTCP_FULL_INFO testcase 2023-06-21 22:45:58 -07:00
mptcp_sockopt.sh selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL 2024-03-11 15:07:27 -07:00
pm_netlink.sh selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL 2024-03-11 15:07:27 -07:00
pm_nl_ctl.c selftests: mptcp: add token for get_addr 2024-03-04 13:07:46 +00:00
settings selftests: mptcp: increase timeout to 30 min 2024-02-01 09:06:37 -08:00
simult_flows.sh selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL 2024-03-11 15:07:27 -07:00
userspace_pm.sh selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL 2024-03-11 15:07:27 -07:00