Ilya Dryomov 7af3ea189a libceph: stop allocating a new cipher on every crypto request ... This is useless and more importantly not allowed on the writeback path, because crypto_alloc_skcipher() allocates memory with GFP_KERNEL, which can recurse back into the filesystem: kworker/9:3 D ffff92303f318180 0 20732 2 0x00000080 Workqueue: ceph-msgr ceph_con_workfn [libceph] ffff923035dd4480 ffff923038f8a0c0 0000000000000001 000000009eb27318 ffff92269eb28000 ffff92269eb27338 ffff923036b145ac ffff923035dd4480 00000000ffffffff ffff923036b145b0 ffffffff951eb4e1 ffff923036b145a8 Call Trace: [<ffffffff951eb4e1>] ? schedule+0x31/0x80 [<ffffffff951eb77a>] ? schedule_preempt_disabled+0xa/0x10 [<ffffffff951ed1f4>] ? __mutex_lock_slowpath+0xb4/0x130 [<ffffffff951ed28b>] ? mutex_lock+0x1b/0x30 [<ffffffffc0a974b3>] ? xfs_reclaim_inodes_ag+0x233/0x2d0 [xfs] [<ffffffff94d92ba5>] ? move_active_pages_to_lru+0x125/0x270 [<ffffffff94f2b985>] ? radix_tree_gang_lookup_tag+0xc5/0x1c0 [<ffffffff94dad0f3>] ? __list_lru_walk_one.isra.3+0x33/0x120 [<ffffffffc0a98331>] ? xfs_reclaim_inodes_nr+0x31/0x40 [xfs] [<ffffffff94e05bfe>] ? super_cache_scan+0x17e/0x190 [<ffffffff94d919f3>] ? shrink_slab.part.38+0x1e3/0x3d0 [<ffffffff94d9616a>] ? shrink_node+0x10a/0x320 [<ffffffff94d96474>] ? do_try_to_free_pages+0xf4/0x350 [<ffffffff94d967ba>] ? try_to_free_pages+0xea/0x1b0 [<ffffffff94d863bd>] ? __alloc_pages_nodemask+0x61d/0xe60 [<ffffffff94ddf42d>] ? cache_grow_begin+0x9d/0x560 [<ffffffff94ddfb88>] ? fallback_alloc+0x148/0x1c0 [<ffffffff94ed84e7>] ? __crypto_alloc_tfm+0x37/0x130 [<ffffffff94de09db>] ? __kmalloc+0x1eb/0x580 [<ffffffffc09fe2db>] ? crush_choose_firstn+0x3eb/0x470 [libceph] [<ffffffff94ed84e7>] ? __crypto_alloc_tfm+0x37/0x130 [<ffffffff94ed9c19>] ? crypto_spawn_tfm+0x39/0x60 [<ffffffffc08b30a3>] ? crypto_cbc_init_tfm+0x23/0x40 [cbc] [<ffffffff94ed857c>] ? __crypto_alloc_tfm+0xcc/0x130 [<ffffffff94edcc23>] ? crypto_skcipher_init_tfm+0x113/0x180 [<ffffffff94ed7cc3>] ? crypto_create_tfm+0x43/0xb0 [<ffffffff94ed83b0>] ? crypto_larval_lookup+0x150/0x150 [<ffffffff94ed7da2>] ? crypto_alloc_tfm+0x72/0x120 [<ffffffffc0a01dd7>] ? ceph_aes_encrypt2+0x67/0x400 [libceph] [<ffffffffc09fd264>] ? ceph_pg_to_up_acting_osds+0x84/0x5b0 [libceph] [<ffffffff950d40a0>] ? release_sock+0x40/0x90 [<ffffffff95139f94>] ? tcp_recvmsg+0x4b4/0xae0 [<ffffffffc0a02714>] ? ceph_encrypt2+0x54/0xc0 [libceph] [<ffffffffc0a02b4d>] ? ceph_x_encrypt+0x5d/0x90 [libceph] [<ffffffffc0a02bdf>] ? calcu_signature+0x5f/0x90 [libceph] [<ffffffffc0a02ef5>] ? ceph_x_sign_message+0x35/0x50 [libceph] [<ffffffffc09e948c>] ? prepare_write_message_footer+0x5c/0xa0 [libceph] [<ffffffffc09ecd18>] ? ceph_con_workfn+0x2258/0x2dd0 [libceph] [<ffffffffc09e9903>] ? queue_con_delay+0x33/0xd0 [libceph] [<ffffffffc09f68ed>] ? __submit_request+0x20d/0x2f0 [libceph] [<ffffffffc09f6ef8>] ? ceph_osdc_start_request+0x28/0x30 [libceph] [<ffffffffc0b52603>] ? rbd_queue_workfn+0x2f3/0x350 [rbd] [<ffffffff94c94ec0>] ? process_one_work+0x160/0x410 [<ffffffff94c951bd>] ? worker_thread+0x4d/0x480 [<ffffffff94c95170>] ? process_one_work+0x410/0x410 [<ffffffff94c9af8d>] ? kthread+0xcd/0xf0 [<ffffffff951efb2f>] ? ret_from_fork+0x1f/0x40 [<ffffffff94c9aec0>] ? kthread_create_on_node+0x190/0x190 Allocating the cipher along with the key fixes the issue - as long the key doesn't change, a single cipher context can be used concurrently in multiple requests. We still can't take that GFP_KERNEL allocation though. Both ceph_crypto_key_clone() and ceph_crypto_key_decode() are called from GFP_NOFS context, so resort to memalloc_noio_{save,restore}() here. Reported-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Reviewed-by: Sage Weil <sage@redhat.com>		2016-12-12 23:09:20 +01:00
..
6lowpan	6lowpan: ndisc: no overreact if no short address is available	2016-09-19 20:19:34 +02:00
9p	IB/core: add support to create a unsafe global rkey to ib_create_pd	2016-09-23 13:47:44 -04:00
802
8021q	net: add recursion limit to GRO	2016-10-20 14:32:22 -04:00
appletalk	appletalk: use IS_ENABLED() instead of checking for built-in or module	2016-09-10 21:19:10 -07:00
atm	lec: use IS_ENABLED() instead of checking for built-in or module	2016-09-10 21:19:10 -07:00
ax25
batman-adv	batman-adv: Check for alloc errors when preparing TT local data	2016-12-02 10:46:59 +01:00
bluetooth	Bluetooth: Fix using the correct source address type	2016-11-22 22:50:46 +01:00
bridge	net: bridge: set error code on failure	2016-12-05 13:26:22 -05:00
caif	net: caif: remove ineffective check	2016-12-05 14:48:48 -05:00
can	can: raw: raw_setsockopt: limit number of can_filter that can be set	2016-12-07 10:45:57 +01:00
ceph	libceph: stop allocating a new cipher on every crypto request	2016-12-12 23:09:20 +01:00
core	net: avoid signed overflows for SO_{SND|RCV}BUFFORCE	2016-12-02 14:10:14 -05:00
dcb	net: dcb: set error code on failures	2016-12-03 23:54:25 -05:00
dccp	net/dccp: fix use-after-free in dccp_invalid_packet	2016-11-29 20:37:26 -05:00
decnet
dns_resolver
dsa	net: dsa: slave: fix fixed-link phydev leaks	2016-11-29 23:17:02 -05:00
ethernet	net: add recursion limit to GRO	2016-10-20 14:32:22 -04:00
hsr	net/hsr: Remove unused but set variable	2016-10-18 10:28:18 -04:00
ieee802154
ipv4	tcp: warn on bogus MSS and try to amend it	2016-12-06 11:01:19 -05:00
ipv6	ip6_offload: check segs for NULL in ipv6_gso_segment.	2016-12-02 13:34:58 -05:00
ipx
irda	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-09-23 06:46:57 -04:00
iucv
kcm	Merge branch 'work.splice_read' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-10-07 15:36:58 -07:00
key
l2tp	l2tp: fix address test in __l2tp_ip6_bind_lookup()	2016-11-30 14:14:08 -05:00
l3mdev	net: ipv6: Remove l3mdev_get_saddr6	2016-09-10 23:12:53 -07:00
lapb
llc	llc: switch type to bool as the timeout is only tested versus 0	2016-09-17 10:05:05 -04:00
mac80211	mac80211: fix A-MSDU aggregation with fast-xmit + txq	2016-11-15 14:37:30 +01:00
mac802154	mac802154: use rate limited warnings for malformed frames	2016-09-19 20:19:34 +02:00
mpls	net: af_mpls.c add space before open parenthesis	2016-12-05 13:25:55 -05:00
ncsi	net/ncsi: Improve HNCDSC AEN handler	2016-10-20 11:23:08 -04:00
netfilter	netfilter: nft_range: add the missing NULL pointer check	2016-11-24 14:43:35 +01:00
netlabel
netlink	netlink: Do not schedule work from sk_destruct	2016-12-05 19:43:42 -05:00
netrom
nfc
openvswitch	openvswitch: Fix skb leak in IPv6 reassembly.	2016-11-30 11:00:45 -05:00
packet	packet: fix race condition in packet_set_ring	2016-12-02 12:16:49 -05:00
phonet
qrtr
rds	RDS: TCP: unregister_netdevice_notifier() in error path of rds_tcp_init_net	2016-12-02 13:29:26 -05:00
rfkill
rose
rxrpc	rxrpc: Fix checking of error from ip6_route_output()	2016-10-13 08:43:17 +01:00
sched	sched: cls_flower: remove from hashtable only in case skip sw flag is not set	2016-11-29 20:44:38 -05:00
sctp	sctp: change sk state only when it has assocs in sctp_shutdown	2016-11-14 16:22:33 -05:00
strparser	strparser: Propagate correct error code in strp_recv()	2016-10-12 01:51:49 -04:00
sunrpc	One fix for an NFS/RDMA crash.	2016-11-18 16:32:21 -08:00
switchdev	switchdev: Execute bridge ndos only for bridge ports	2016-10-19 10:58:04 -04:00
tipc	tipc: check minimum bearer MTU	2016-12-02 14:03:20 -05:00
unix	af_unix: conditionally use freezable blocking calls in read	2016-11-18 13:58:39 -05:00
vmw_vsock	VSOCK: Don't dec ack backlog twice for rejected connections	2016-09-27 07:59:25 -04:00
wimax
wireless	cfg80211: limit scan results cache size	2016-11-18 08:44:44 +01:00
x25	net: x25: remove null checks on arrays calling_ae and called_ae	2016-09-09 18:13:30 -07:00
xfrm	xfrm_user: fix return value from xfrm_user_rcv_msg	2016-11-30 10:58:53 +01:00
compat.c
Kconfig
Makefile
socket.c	xattr: Fix setting security xattrs on sockfs	2016-11-17 00:00:23 -05:00
sysctl_net.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-10-06 09:52:23 -07:00