linux-stable/arch
Ard Biesheuvel 46bcc8c57e arm64: compat: Work around uninitialized variable warning
[ Upstream commit 32d8599968 ]

Dan reports that smatch complains about a potential uninitialized
variable being used in the compat alignment fixup code.

The logic is not wrong per se, but we do end up using an uninitialized
variable if reading the instruction that triggered the alignment fault
from user space faults, even if the fault ensures that the uninitialized
value doesn't propagate any further.

Given that we just give up and return 1 if any fault occurs when reading
the instruction, let's get rid of the 'success handling' pattern that
captures the fault in a variable and aborts later, and instead, just
return 1 immediately if any of the get_user() calls result in an
exception.

Fixes: 3fc24ef32d ("arm64: compat: Implement misalignment fixups for multiword loads")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202304021214.gekJ8yRc-lkp@intel.com/
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20230404103625.2386382-1-ardb@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-04-13 17:02:41 +02:00
..
alpha
arc
arm
arm64 arm64: compat: Work around uninitialized variable warning 2023-04-13 17:02:41 +02:00
csky
hexagon
ia64
loongarch
m68k
microblaze
mips mips: bmips: BCM6358: disable RAC flush for TP1 2023-04-06 12:12:31 +02:00
nios2
openrisc
parisc
powerpc powerpc/64s: Fix __pte_needs_flush() false positive warning 2023-04-06 12:12:44 +02:00
riscv riscv/kvm: Fix VM hang in case of timer delta being zero. 2023-04-06 12:12:31 +02:00
s390 KVM: s390: pv: fix external interruption loop not always detected 2023-04-13 17:02:36 +02:00
sh
sparc
um
x86 x86/PVH: avoid 32-bit build warning when obtaining VGA console info 2023-04-06 12:12:48 +02:00
xtensa xtensa: fix KASAN report for show_stack 2023-04-06 12:12:45 +02:00
.gitignore
Kconfig