Qian Cai 8419d8e01a jbd2: fix data races at struct journal_head ... [ Upstream commit 6c5d911249 ] journal_head::b_transaction and journal_head::b_next_transaction could be accessed concurrently as noticed by KCSAN, LTP: starting fsync04 /dev/zero: Can't open blockdev EXT4-fs (loop0): mounting ext3 file system using the ext4 subsystem EXT4-fs (loop0): mounted filesystem with ordered data mode. Opts: (null) ================================================================== BUG: KCSAN: data-race in __jbd2_journal_refile_buffer [jbd2] / jbd2_write_access_granted [jbd2] write to 0xffff99f9b1bd0e30 of 8 bytes by task 25721 on cpu 70: __jbd2_journal_refile_buffer+0xdd/0x210 [jbd2] __jbd2_journal_refile_buffer at fs/jbd2/transaction.c:2569 jbd2_journal_commit_transaction+0x2d15/0x3f20 [jbd2] (inlined by) jbd2_journal_commit_transaction at fs/jbd2/commit.c:1034 kjournald2+0x13b/0x450 [jbd2] kthread+0x1cd/0x1f0 ret_from_fork+0x27/0x50 read to 0xffff99f9b1bd0e30 of 8 bytes by task 25724 on cpu 68: jbd2_write_access_granted+0x1b2/0x250 [jbd2] jbd2_write_access_granted at fs/jbd2/transaction.c:1155 jbd2_journal_get_write_access+0x2c/0x60 [jbd2] __ext4_journal_get_write_access+0x50/0x90 [ext4] ext4_mb_mark_diskspace_used+0x158/0x620 [ext4] ext4_mb_new_blocks+0x54f/0xca0 [ext4] ext4_ind_map_blocks+0xc79/0x1b40 [ext4] ext4_map_blocks+0x3b4/0x950 [ext4] _ext4_get_block+0xfc/0x270 [ext4] ext4_get_block+0x3b/0x50 [ext4] __block_write_begin_int+0x22e/0xae0 __block_write_begin+0x39/0x50 ext4_write_begin+0x388/0xb50 [ext4] generic_perform_write+0x15d/0x290 ext4_buffered_write_iter+0x11f/0x210 [ext4] ext4_file_write_iter+0xce/0x9e0 [ext4] new_sync_write+0x29c/0x3b0 __vfs_write+0x92/0xa0 vfs_write+0x103/0x260 ksys_write+0x9d/0x130 __x64_sys_write+0x4c/0x60 do_syscall_64+0x91/0xb05 entry_SYSCALL_64_after_hwframe+0x49/0xbe 5 locks held by fsync04/25724: #0: ffff99f9911093f8 (sb_writers#13){.+.+}, at: vfs_write+0x21c/0x260 #1: ffff99f9db4c0348 (&sb->s_type->i_mutex_key#15){+.+.}, at: ext4_buffered_write_iter+0x65/0x210 [ext4] #2: ffff99f5e7dfcf58 (jbd2_handle){++++}, at: start_this_handle+0x1c1/0x9d0 [jbd2] #3: ffff99f9db4c0168 (&ei->i_data_sem){++++}, at: ext4_map_blocks+0x176/0x950 [ext4] #4: ffffffff99086b40 (rcu_read_lock){....}, at: jbd2_write_access_granted+0x4e/0x250 [jbd2] irq event stamp: 1407125 hardirqs last enabled at (1407125): [<ffffffff980da9b7>] __find_get_block+0x107/0x790 hardirqs last disabled at (1407124): [<ffffffff980da8f9>] __find_get_block+0x49/0x790 softirqs last enabled at (1405528): [<ffffffff98a0034c>] __do_softirq+0x34c/0x57c softirqs last disabled at (1405521): [<ffffffff97cc67a2>] irq_exit+0xa2/0xc0 Reported by Kernel Concurrency Sanitizer on: CPU: 68 PID: 25724 Comm: fsync04 Tainted: G L 5.6.0-rc2-next-20200221+ #7 Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 The plain reads are outside of jh->b_state_lock critical section which result in data races. Fix them by adding pairs of READ|WRITE_ONCE(). Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Qian Cai <cai@lca.pw> Link: https://lore.kernel.org/r/20200222043111.2227-1-cai@lca.pw Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-03-20 10:54:26 +01:00
..
9p	9p: avoid attaching writeback_fid on mmap with type PRIVATE	2019-10-11 18:18:38 +02:00
adfs	fs/adfs: super: fix use-after-free bug	2019-08-06 19:05:21 +02:00
affs	affs: fix a memory leak in affs_remount	2020-01-27 14:46:52 +01:00
afs	afs: Fix large file support	2020-01-27 14:46:51 +01:00
autofs4	autofs: fix a leak in autofs_expire_indirect()	2019-12-17 20:37:24 +01:00
befs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bfs	bfs: add sanity check at bfs_fill_super()	2018-12-01 09:42:51 +01:00
btrfs	Btrfs: fix btrfs_wait_ordered_range() so that it waits for all ordered extents	2020-02-28 16:36:14 +01:00
cachefiles	fscache, cachefiles: remove redundant variable 'cache'	2018-12-17 09:28:53 +01:00
ceph	ceph: check availability of mds cluster on mount after wait timeout	2020-02-28 16:36:07 +01:00
cifs	cifs_atomic_open(): fix double-put on late allocation failure	2020-03-20 10:54:16 +01:00
coda	coda: add error handling for fget	2019-08-06 19:05:23 +02:00
configfs	configfs: fix a deadlock in configfs_symlink()	2019-11-12 19:18:18 +01:00
cramfs	Cramfs: fix abad comparison when wrap-arounds occur	2018-11-13 11:15:12 -08:00
crypto	fscrypt: clean up some BUG_ON()s in block encryption/decryption	2019-07-31 07:28:22 +02:00
debugfs	debugfs: fix use-after-free on symlink traversal	2019-05-08 07:20:49 +02:00
devpts	fs/devpts: always delete dcache dentry-s in dput()	2019-03-23 14:35:21 +01:00
dlm	dlm: fix invalid cluster name warning	2019-12-17 20:38:33 +01:00
ecryptfs	ecryptfs: Fix up bad backport of fe2e082f5d	2020-03-11 18:02:51 +01:00
efivarfs
efs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
exofs	exofs_mount(): fix leaks on failure exits	2019-12-05 15:37:28 +01:00
exportfs	exportfs: fix 'passing zero to ERR_PTR()' warning	2020-01-27 14:46:06 +01:00
ext2	ext2: Adjust indentation in ext2_fill_super	2020-02-14 16:32:17 -05:00
ext4	ext4: potential crash on allocation error in ext4_alloc_flex_bg_array()	2020-03-11 18:02:48 +01:00
f2fs	f2fs: fix memleak of kobject	2020-02-28 16:36:05 +01:00
fat	fat: fix uninit-memory access for partial initialized inode	2020-03-11 18:03:03 +01:00
freevxfs
fscache	fscache: fix race between enablement and dropping of object	2018-12-17 09:28:53 +01:00
fuse	fuse: verify attributes	2019-12-17 20:38:44 +01:00
gfs2	gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache	2020-03-20 10:54:16 +01:00
hfs	fs/hfs/extent.c: fix array out of bounds read of array extent	2019-12-01 09:13:57 +01:00
hfsplus	hfsplus: update timestamps on truncate()	2019-12-01 09:13:56 +01:00
hostfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hpfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
hugetlbfs	hugetlb: use same fault hash key for shared and private mappings	2019-05-31 06:47:12 -07:00
isofs	isofs: reject hardware sector size > 2048 bytes	2018-10-03 17:00:57 -07:00
jbd2	jbd2: fix data races at struct journal_head	2020-03-20 10:54:26 +01:00
jffs2	jffs2: fix use-after-free on symlink traversal	2019-05-08 07:20:49 +02:00
jfs	jfs: fix bogus variable self-initialization	2020-01-27 14:46:26 +01:00
kernfs	kernfs: fix ino wrap-around detection	2019-12-17 20:38:50 +01:00
lockd	lockd: fix decoding of TEST results	2019-12-17 20:38:15 +01:00
minix	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ncpfs	staging: ncpfs: memory corruption in ncp_read_kernel()	2018-03-28 18:24:43 +02:00
nfs	NFSv4: try lease recovery on NFS4ERR_EXPIRED	2020-02-14 16:32:21 -05:00
nfs_common	lockd: fix "list_add double add" caused by legacy signal interface	2018-02-03 17:39:08 +01:00
nfsd	nfsd: fix jiffies/time_t mixup in LRU list	2020-02-14 16:32:17 -05:00
nilfs2	do d_instantiate/unlock_new_inode combinations safely	2018-05-30 07:51:47 +02:00
nls	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
notify	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:11:59 +01:00
ntfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ocfs2	ocfs2: fix a NULL pointer dereference when call ocfs2_update_inode_fsync_trans()	2020-02-28 16:36:08 +01:00
omfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
openpromfs
orangefs	help_next should increase position index	2020-02-28 16:36:08 +01:00
overlayfs	ovl: relax WARN_ON() on rename to self	2019-12-17 20:39:21 +01:00
proc	proc/vmcore: Fix i386 build error of missing copy_oldmem_page_encrypted()	2019-11-24 08:23:23 +01:00
pstore	pstore/ram: Write new dumps to start of recycled zones	2020-01-09 10:17:55 +01:00
qnx4	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
qnx6	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
quota	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:11:59 +01:00
ramfs
reiserfs	reiserfs: prevent NULL pointer dereference in reiserfs_insert_item()	2020-02-28 16:36:08 +01:00
romfs	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
squashfs	Squashfs: Compute expected length from inode size rather than block length	2018-09-05 09:26:32 +02:00
sysfs	scsi: sysfs: Introduce sysfs_{un,}break_active_protection()	2018-09-05 09:26:41 +02:00
sysv	sysv: return 'err' instead of 0 in __sysv_write_inode	2018-12-17 09:28:48 +01:00
tracefs
ubifs	ubifs: don't trigger assertion on invalid no-key filename	2020-02-14 16:32:11 -05:00
udf	udf: Fix free space reporting for metadata and virtual partitions	2020-02-28 16:36:02 +01:00
ufs	ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour	2019-05-25 18:25:36 +02:00
xfs	xfs: Sanity check flags of Q_XQUOTARM call	2020-01-27 14:46:02 +01:00
aio.c	aio: fix spectre gadget in lookup_ioctx	2018-12-21 14:13:04 +01:00
anon_inodes.c
attr.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
bad_inode.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
binfmt_aout.c
binfmt_elf.c	binfmt_elf: Do not move brk for INTERP-less ET_EXEC	2019-10-05 12:48:06 +02:00
binfmt_elf_fdpic.c
binfmt_em86.c
binfmt_flat.c	fs/binfmt_flat.c: make load_flat_shared_library() work	2019-07-03 13:15:59 +02:00
binfmt_misc.c	fs/binfmt_misc.c: do not allow offset overflow	2018-06-26 08:06:33 +08:00
binfmt_script.c	exec: load_script: Do not exec truncated interpreter path	2019-11-06 12:42:59 +01:00
block_dev.c	block: fix the return errno for direct IO	2019-04-17 08:37:53 +02:00
buffer.c	fs: fix guard_bio_eod to check for real EOD errors	2019-04-05 22:31:28 +02:00
char_dev.c	chardev: Avoid potential use-after-free in 'chrdev_open()'	2020-01-14 20:05:39 +01:00
compat.c
compat_binfmt_elf.c
compat_ioctl.c	fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP	2020-01-09 10:17:58 +01:00
coredump.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dax.c	dax: pass NOWAIT flag to iomap_apply	2020-03-11 18:02:43 +01:00
dcache.c	fs/dcache: Fix incorrect nr_dentry_unused accounting in shrink_dcache_sb()	2019-02-06 17:31:34 +01:00
dcookies.c
direct-io.c	iomap: report collisions between directio and buffered writes to userspace	2019-04-27 09:35:41 +02:00
drop_caches.c	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:11:59 +01:00
eventfd.c
eventpoll.c	fs/epoll: drop ovflist branch prediction	2019-02-12 19:46:10 +01:00
exec.c	exit/exec: Seperate mm_release()	2019-12-05 15:38:25 +01:00
fcntl.c	fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall	2017-12-17 15:07:59 +01:00
fhandle.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
file.c	fs/file.c: initialize init_files.resize_wait	2019-04-05 22:31:28 +02:00
file_table.c
filesystems.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs-writeback.c	cgroup,writeback: don't switch wbs immediately on dead wbs if the memcg is dead	2019-11-12 19:18:47 +01:00
fs_pin.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fs_struct.c
inode.c	fs: avoid softlockups in s_inodes iterators	2020-01-12 12:11:59 +01:00
internal.h
ioctl.c	vfs: swap names of {do,vfs}_clone_file_range()	2018-11-10 07:48:33 -08:00
iomap.c	iomap: Fix pipe page leakage during splicing	2019-12-17 20:38:57 +01:00
Kconfig
Kconfig.binfmt
libfs.c	Fix the locking in dcache_readdir() and friends	2019-10-17 13:43:52 -07:00
locks.c	locks: print unsigned ino in /proc/locks	2020-01-09 10:17:55 +01:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mbcache.c	mbcache: initialize entry->e_referenced in mb_cache_entry_create()	2018-02-22 15:42:25 +01:00
mount.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mpage.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
namei.c	namei: only return -ECHILD from follow_dotdot_rcu()	2020-03-11 18:02:53 +01:00
namespace.c	mount: Prevent MNT_DETACH from disconnecting locked mounts	2018-11-21 09:24:14 +01:00
no-block.c
nsfs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
open.c	cifs_atomic_open(): fix double-put on late allocation failure	2020-03-20 10:54:16 +01:00
pipe.c	fs: prevent page refcount overflow in pipe_buf_get	2019-05-04 09:15:18 +02:00
pnode.c
pnode.h
posix_acl.c
proc_namespace.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
read_write.c	vfs: avoid problematic remapping requests into partial EOF block	2019-12-01 09:13:51 +01:00
readdir.c	filldir[64]: remove WARN_ON_ONCE() for bad directory entries	2020-01-04 14:00:04 +01:00
select.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
seq_file.c	seq_file: fix incomplete reset on read from zero offset	2018-02-22 15:42:28 +01:00
signalfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
splice.c	fs: prevent page refcount overflow in pipe_buf_get	2019-05-04 09:15:18 +02:00
stack.c
stat.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
statfs.c	vfs: Fix EOVERFLOW testing in put_compat_statfs64	2019-10-11 18:18:48 +02:00
super.c	fs: don't scan the inode cache before SB_BORN is set	2018-05-30 07:51:47 +02:00
sync.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
timerfd.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
userfaultfd.c	userfaultfd: require CAP_SYS_PTRACE for UFFD_FEATURE_EVENT_FORK	2020-01-04 13:59:58 +01:00
utimes.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xattr.c	sysfs: Do not return POSIX ACL xattrs via listxattr	2018-10-10 08:54:27 +02:00