Linus Torvalds 85746e2ab3 vm: fix move_vma() memory accounting being off ... commit 3cec504909 upstream. Commit 408579cd62 ("mm: Update do_vmi_align_munmap() return semantics") seems to have updated one of the callers of do_vmi_munmap() incorrectly: it used to check for the error case (which didn't change: negative means error). That commit changed the check to the success case (which did change: before that commit, 0 was success, and 1 was "success and lock downgraded". After the change, it's always 0 for success, and the lock will have been released if requested). This didn't change any actual VM behavior _except_ for memory accounting when 'VM_ACCOUNT' was set on the vma. Which made the wrong return value test fairly subtle, since everything continues to work. Or rather - it continues to work but the "Committed memory" accounting goes all wonky (Committed_AS value in /proc/meminfo), and depending on settings that then causes problems much much later as the VM relies on bogus statistics for its heuristics. Revert that one line of the change back to the original logic. Fixes: 408579cd62 ("mm: Update do_vmi_align_munmap() return semantics") Reported-by: Christoph Biedl <linux-kernel.bfrz@manchmal.in-ulm.de> Reported-bisected-and-tested-by: Michael Labiuk <michael.labiuk@virtuozzo.com> Cc: Bagas Sanjaya <bagasdotme@gmail.com> Cc: Liam R. Howlett <Liam.Howlett@oracle.com> Link: https://lore.kernel.org/all/1694366957@msgid.manchmal.in-ulm.de/ Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Helge Deller <deller@gmx.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-09-19 12:30:30 +02:00
..
damon	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
kasan	kasan, slub: fix HW_TAGS zeroing with slub_debug	2023-07-08 09:29:32 -07:00
kfence	mm/slab: introduce kmem_cache flag SLAB_NO_MERGE	2023-06-02 10:24:33 +02:00
kmsan	kasan,kmsan: remove __GFP_KSWAPD_RECLAIM usage from kasan/kmsan	2023-06-23 16:59:26 -07:00
backing-dev.c	mm: backing-dev: make bdi_class a static const structure	2023-06-23 16:59:27 -07:00
balloon_compaction.c
bootmem_info.c
cma.c	mm/page_owner/cma: show pfn in cma/page_owner with hex format	2023-06-19 16:19:32 -07:00
cma.h
cma_debug.c
cma_sysfs.c
compaction.c	mm: compaction: fix endless looping over same migrate block	2023-08-04 13:03:42 -07:00
debug.c	mm: update validate_mm() to use vma iterator	2023-06-09 16:25:31 -07:00
debug_page_alloc.c	mm: page_alloc: split out DEBUG_PAGEALLOC	2023-06-09 16:25:23 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm/debug_vm_pgtable,page_table_check: warn pte map fails	2023-06-19 16:19:15 -07:00
dmapool.c	dmapool: create/destroy cleanup	2023-06-09 16:25:17 -07:00
dmapool_test.c
early_ioremap.c	mm/early_ioremap.c: improve the execution efficiency of early_ioremap_setup()	2023-06-09 16:25:56 -07:00
fadvise.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
fail_page_alloc.c	mm: page_alloc: split out FAIL_PAGE_ALLOC	2023-06-09 16:25:23 -07:00
failslab.c
filemap.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
folio-compat.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
frontswap.c	mm: zswap: support exclusive loads	2023-06-19 16:19:05 -07:00
gup.c	mm/gup: reintroduce FOLL_NUMA as FOLL_HONOR_NUMA_FAULT	2023-08-21 13:07:20 -07:00
gup_test.c	Merge mm-hotfixes-stable into mm-stable to pick up depended-upon changes.	2023-06-23 16:58:19 -07:00
gup_test.h
highmem.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
hmm.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
huge_memory.c	madvise:madvise_free_huge_pmd(): don't use mapcount() against large folio for sharing check	2023-08-24 14:59:46 -07:00
hugetlb.c	hugetlb: do not clear hugetlb dtor until allocating vmemmap	2023-08-04 13:03:41 -07:00
hugetlb_cgroup.c
hugetlb_vmemmap.c	mm: hugetlb_vmemmap: fix a race between vmemmap pmd split	2023-09-19 12:30:11 +02:00
hugetlb_vmemmap.h
hwpoison-inject.c
init-mm.c	IOMMU Updates for Linux 6.4	2023-04-30 13:00:38 -07:00
internal.h	mm/gup: handle cont-PTE hugetlb pages correctly in gup_must_unshare() via GUP-fast	2023-08-21 13:07:21 -07:00
interval_tree.c
io-mapping.c
ioremap.c
Kconfig	mm: disable CONFIG_PER_VMA_LOCK until its fixed	2023-07-08 09:29:29 -07:00
Kconfig.debug	mm: page_table_check: Make it dependent on EXCLUSIVE_SYSTEM_RAM	2023-05-29 16:14:28 +01:00
khugepaged.c	mm/khugepaged: fix regression in collapse_file()	2023-06-29 09:41:45 -07:00
kmemleak.c
ksm.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
list_lru.c
maccess.c
madvise.c	madvise:madvise_free_pte_range(): don't use mapcount() against large folio for sharing check	2023-08-24 14:59:46 -07:00
Makefile	mm: page_alloc: split out DEBUG_PAGEALLOC	2023-06-09 16:25:23 -07:00
mapping_dirty_helpers.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
memblock.c	Revert "mm,memblock: reset memblock.reserved to system init state to prevent UAF"	2023-07-28 09:47:06 -07:00
memcontrol.c	memcontrol: ensure memcg acquired by id is properly set up	2023-09-19 12:30:23 +02:00
memfd.c	revert "memfd: improve userspace warnings for missing exec-related flags".	2023-09-13 09:53:57 +02:00
memory-failure.c	mm: memory-failure: fix unexpected return value in soft_offline_page()	2023-08-21 13:07:22 -07:00
memory-tiers.c	memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check	2023-06-19 16:19:29 -07:00
memory.c	mm: avoid 'might_sleep()' in get_mmap_lock_carefully()	2023-08-21 06:11:33 +02:00
memory_hotplug.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
mempolicy.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mempool.c
memremap.c
memtest.c
migrate.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
migrate_device.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mincore.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mlock.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mm_init.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
mm_slot.h
mmap.c	mm: lock VMA in dup_anon_vma() before setting ->anon_vma	2023-07-27 13:07:04 -07:00
mmap_lock.c
mmu_gather.c
mmu_notifier.c
mmzone.c
mprotect.c	mm: enable page walking API to lock vmas during the walk	2023-08-21 13:07:20 -07:00
mremap.c	vm: fix move_vma() memory accounting being off	2023-09-19 12:30:30 +02:00
msync.c
nommu.c	xtensa: fix lock_mm_and_find_vma in case VMA not found	2023-07-01 08:00:05 -07:00
oom_kill.c	mm, oom: do not check 0 mask in out_of_memory()	2023-06-09 16:25:20 -07:00
page-writeback.c	writeback: account the number of pages written back	2023-07-08 09:29:30 -07:00
page_alloc.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
page_counter.c
page_ext.c
page_idle.c
page_io.c	swap: use __bio_add_page to add page to bio	2023-05-31 09:50:02 -06:00
page_isolation.c	mm: page_isolation: write proper kerneldoc	2023-06-19 16:18:59 -07:00
page_owner.c	mm/page_owner/cma: show pfn in cma/page_owner with hex format	2023-06-19 16:19:32 -07:00
page_poison.c
page_reporting.c
page_reporting.h
page_table_check.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
page_vma_mapped.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
pagewalk.c	mm/pagewalk: fix bootstopping regression from extra pte_unmap()	2023-09-13 09:53:46 +02:00
percpu-internal.h	percpu-internal/pcpu_chunk: re-layout pcpu_chunk structure to reduce false sharing	2023-06-19 16:19:29 -07:00
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c
pgalloc-track.h
pgtable-generic.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
process_vm_access.c	mm/gup: remove unused vmas parameter from pin_user_pages_remote()	2023-06-09 16:25:25 -07:00
ptdump.c	mm: ptdump should use ptep_get_lockless()	2023-06-19 16:19:24 -07:00
readahead.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
rmap.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
rodata_test.c
secretmem.c	mm/mlock: rename mlock_future_check() to mlock_future_ok()	2023-06-09 16:25:38 -07:00
shmem.c	tmpfs: verify {g,u}id mount options correctly	2023-09-13 09:52:58 +02:00
show_mem.c	mm: page_alloc: collect mem statistic into show_mem.c	2023-06-09 16:25:22 -07:00
shrinker_debug.c	Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless"	2023-06-19 13:19:34 -07:00
shuffle.c
shuffle.h
slab.c	slab updates for 6.5	2023-06-29 16:34:12 -07:00
slab.h	kasan, slub: fix HW_TAGS zeroing with slub_debug	2023-07-08 09:29:32 -07:00
slab_common.c	slab updates for 6.5	2023-06-29 16:34:12 -07:00
slub.c	slab updates for 6.5	2023-06-29 16:34:12 -07:00
sparse-vmemmap.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
sparse.c	- Arnd Bergmann has fixed a bunch of -Wmissing-prototypes in	2023-06-28 10:59:38 -07:00
swap.c	mm: remove references to pagevec	2023-06-23 16:59:30 -07:00
swap.h
swap_cgroup.c
swap_slots.c
swap_state.c	mm: remove unnecessary pagevec includes	2023-06-23 16:59:31 -07:00
swapfile.c	mm/swapfile: fix wrong swap entry type for hwpoisoned swapcache page	2023-08-04 13:03:40 -07:00
truncate.c	mm: remove references to pagevec	2023-06-23 16:59:30 -07:00
usercopy.c
userfaultfd.c	mm: ptep_get() conversion	2023-06-19 16:19:25 -07:00
util.c	rcu: dump vmalloc memory info safely	2023-09-13 09:53:50 +02:00
vmalloc.c	mm/vmalloc: add a safer version of find_vm_area() for debug	2023-09-13 09:53:50 +02:00
vmpressure.c	net-memcg: Fix scope of sockmem pressure indicators	2023-09-13 09:53:07 +02:00
vmscan.c	Multi-gen LRU: avoid race in inc_min_seq()	2023-09-19 12:30:11 +02:00
vmstat.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
workingset.c	Multi-gen LRU: fix workingset accounting	2023-06-09 16:25:46 -07:00
z3fold.c	mm: zswap: remove shrink from zpool interface	2023-06-19 16:19:27 -07:00
zbud.c	mm: zswap: remove shrink from zpool interface	2023-06-19 16:19:27 -07:00
zpool.c	mm: zswap: remove shrink from zpool interface	2023-06-19 16:19:27 -07:00
zsmalloc.c	zsmalloc: fix races between modifications of fullness and isolated	2023-08-04 13:03:40 -07:00
zswap.c	mm: zswap: fix double invalidate with exclusive loads	2023-06-23 16:59:31 -07:00