Gustavo A. R. Silva e7bb7ecefa IB/mlx4: Replace zero-length array with flexible-array ... The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] sizeof(flexible-array-member) triggers a warning because flexible array members have incomplete type[1]. There are some instances of code in which the sizeof operator is being incorrectly/erroneously applied to zero-length arrays and the result is zero. Such instances may be hiding some bugs. So, this work (flexible-array member conversions) will also help to get completely rid of those sorts of issues. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2020-05-09 20:49:13 -07:00
..
cmd.h
cq.h	RDMA/mlx4: Redo TX checksum offload in line with docs	2020-01-03 16:37:58 -04:00
device.h	mlx4: Bump up MAX_MSIX from 64 to 128	2020-01-12 12:32:32 -08:00
doorbell.h
driver.h
qp.h	IB/mlx4: Replace zero-length array with flexible-array	2020-05-09 20:49:13 -07:00
srq.h