Omar Sandoval 7f07bbf9bc block: only call sched requeue_request() for scheduled requests ... [ Upstream commit e8a8a18505 ] Yang Yang reported the following crash caused by requeueing a flush request in Kyber: [ 2.517297] Unable to handle kernel paging request at virtual address ffffffd8071c0b00 ... [ 2.517468] pc : clear_bit+0x18/0x2c [ 2.517502] lr : sbitmap_queue_clear+0x40/0x228 [ 2.517503] sp : ffffff800832bc60 pstate : 00c00145 ... [ 2.517599] Process ksoftirqd/5 (pid: 51, stack limit = 0xffffff8008328000) [ 2.517602] Call trace: [ 2.517606] clear_bit+0x18/0x2c [ 2.517619] kyber_finish_request+0x74/0x80 [ 2.517627] blk_mq_requeue_request+0x3c/0xc0 [ 2.517637] __scsi_queue_insert+0x11c/0x148 [ 2.517640] scsi_softirq_done+0x114/0x130 [ 2.517643] blk_done_softirq+0x7c/0xb0 [ 2.517651] __do_softirq+0x208/0x3bc [ 2.517657] run_ksoftirqd+0x34/0x60 [ 2.517663] smpboot_thread_fn+0x1c4/0x2c0 [ 2.517667] kthread+0x110/0x120 [ 2.517669] ret_from_fork+0x10/0x18 This happens because Kyber doesn't track flush requests, so kyber_finish_request() reads a garbage domain token. Only call the scheduler's requeue_request() hook if RQF_ELVPRIV is set (like we do for the finish_request() hook in blk_mq_free_request()). Now that we're handling it in blk-mq, also remove the check from BFQ. Reported-by: Yang Yang <yang.yang@vivo.com> Signed-off-by: Omar Sandoval <osandov@fb.com> Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-09-23 12:40:37 +02:00
..
partitions
badblocks.c
bfq-cgroup.c	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bfq-iosched.c	block: only call sched requeue_request() for scheduled requests	2020-09-23 12:40:37 +02:00
bfq-iosched.h	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bfq-wf2q.c	bfq: fix blkio cgroup leakage v4	2020-09-03 11:26:54 +02:00
bio-integrity.c	block: release bip in a right way in error path	2020-07-16 08:16:36 +02:00
bio.c	block: Set same_page to false in __bio_try_merge_page if ret is false	2020-09-17 13:47:44 +02:00
blk-cgroup.c	blkcg: fix memleak for iolatency	2020-09-03 11:26:55 +02:00
blk-core.c	block: ensure bdi->io_pages is always initialized	2020-09-09 19:12:34 +02:00
blk-exec.c
blk-flush.c
blk-integrity.c
blk-ioc.c
blk-iocost.c	blk-iocost: ioc_pd_free() shouldn't assume irq disabled	2020-09-09 19:12:35 +02:00
blk-iolatency.c
blk-lib.c
blk-map.c
blk-merge.c	block: fix get_max_io_size()	2020-09-03 11:27:01 +02:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	blk-mq-debugfs: update blk_queue_flag_name[] accordingly for new flags	2020-07-22 09:32:52 +02:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART	2020-09-03 11:27:01 +02:00
blk-mq-sched.h	block: only call sched requeue_request() for scheduled requests	2020-09-23 12:40:37 +02:00
blk-mq-sysfs.c
blk-mq-tag.c
blk-mq-tag.h
blk-mq-virtio.c
blk-mq.c	blk-mq: order adding requests to hctx->dispatch and checking SCHED_RESTART	2020-09-03 11:27:01 +02:00
blk-mq.h
blk-pm.c
blk-pm.h
blk-rq-qos.c
blk-rq-qos.h
blk-settings.c
blk-softirq.c
blk-stat.c
blk-stat.h
blk-sysfs.c
blk-throttle.c
blk-timeout.c
blk-wbt.c
blk-wbt.h
blk-zoned.c
blk.h
bounce.c
bsg-lib.c
bsg.c
cmdline-parser.c
compat_ioctl.c
elevator.c
genhd.c
ioctl.c
ioprio.c
Kconfig
Kconfig.iosched
kyber-iosched.c
Makefile
mq-deadline.c
opal_proto.h
partition-generic.c
scsi_ioctl.c
sed-opal.c
t10-pi.c