Randy Dunlap 6c7f2aaf4d efi: fix return value of __setup handlers ... [ Upstream commit 9feaf8b387 ] When "dump_apple_properties" is used on the kernel boot command line, it causes an Unknown parameter message and the string is added to init's argument strings: Unknown kernel command line parameters "dump_apple_properties BOOT_IMAGE=/boot/bzImage-517rc6 efivar_ssdt=newcpu_ssdt", will be passed to user space. Run /sbin/init as init process with arguments: /sbin/init dump_apple_properties with environment: HOME=/ TERM=linux BOOT_IMAGE=/boot/bzImage-517rc6 efivar_ssdt=newcpu_ssdt Similarly when "efivar_ssdt=somestring" is used, it is added to the Unknown parameter message and to init's environment strings, polluting them (see examples above). Change the return value of the __setup functions to 1 to indicate that the __setup options have been handled. Fixes: 58c5475aba ("x86/efi: Retrieve and assign Apple device properties") Fixes: 475fb4e8b2 ("efi / ACPI: load SSTDs from EFI variables") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru Cc: Ard Biesheuvel <ardb@kernel.org> Cc: linux-efi@vger.kernel.org Cc: Lukas Wunner <lukas@wunner.de> Cc: Octavian Purdila <octavian.purdila@intel.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Matt Fleming <matt@codeblueprint.co.uk> Link: https://lore.kernel.org/r/20220301041851.12459-1-rdunlap@infradead.org Signed-off-by: Ard Biesheuvel <ardb@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-03-23 09:01:35 +01:00
..
broadcom
efi	efi: fix return value of __setup handlers	2022-03-23 09:01:35 +01:00
google	firmware: Update Kconfig help text for Google firmware	2022-01-27 09:00:59 +01:00
meson
tegra
arm_scpi.c
dcdbas.c
dcdbas.h
dell_rbu.c
dmi-id.c
dmi-sysfs.c
dmi_scan.c
edd.c
iscsi_ibft.c
iscsi_ibft_find.c
Kconfig
Makefile
memmap.c
pcdp.c
pcdp.h
psci.c	arm/arm64: smccc/psci: add arm_smccc_1_1_get_conduit()	2022-03-11 10:13:29 +01:00
psci_checker.c
qcom_scm-32.c
qcom_scm-64.c
qcom_scm.c
qcom_scm.h
qemu_fw_cfg.c	firmware: qemu_fw_cfg: fix kobject leak in probe error path	2022-03-08 19:01:57 +01:00
raspberrypi.c
scpi_pm_domain.c	firmware: arm_scpi: Fix string overflow in SCPI genpd driver	2021-12-22 09:18:00 +01:00
ti_sci.c
ti_sci.h