Tejun Heo 1e4d3f8bd8 blk-iocost: Fix an UBSAN shift-out-of-bounds warning ... [ Upstream commit 2a427b49d0 ] When iocg_kick_delay() is called from a CPU different than the one which set the delay, @now may be in the past of @iocg->delay_at leading to the following warning: UBSAN: shift-out-of-bounds in block/blk-iocost.c:1359:23 shift exponent 18446744073709 is too large for 64-bit type 'u64' (aka 'unsigned long long') ... Call Trace: <TASK> dump_stack_lvl+0x79/0xc0 __ubsan_handle_shift_out_of_bounds+0x2ab/0x300 iocg_kick_delay+0x222/0x230 ioc_rqos_merge+0x1d7/0x2c0 __rq_qos_merge+0x2c/0x80 bio_attempt_back_merge+0x83/0x190 blk_attempt_plug_merge+0x101/0x150 blk_mq_submit_bio+0x2b1/0x720 submit_bio_noacct_nocheck+0x320/0x3e0 __swap_writepage+0x2ab/0x9d0 The underflow itself doesn't really affect the behavior in any meaningful way; however, the past timestamp may exaggerate the delay amount calculated later in the code, which shouldn't be a material problem given the nature of the delay mechanism. If @now is in the past, this CPU is racing another CPU which recently set up the delay and there's nothing this CPU can contribute w.r.t. the delay. Let's bail early from iocg_kick_delay() in such cases. Reported-by: Breno Leitão <leitao@debian.org> Signed-off-by: Tejun Heo <tj@kernel.org> Fixes: 5160a5a53c ("blk-iocost: implement delay adjustment hysteresis") Link: https://lore.kernel.org/r/ZVvc9L_CYk5LO1fT@slm.duckdns.org Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-02-23 08:54:59 +01:00
..
partitions	block: Move checking GENHD_FL_NO_PART to bdev_add_partition()	2024-02-23 08:54:35 +01:00
badblocks.c
bdev.c	block: move GENHD_FL_BLOCK_EVENTS_ON_EXCL_WRITE to disk->event_flags	2023-09-19 12:23:02 +02:00
bfq-cgroup.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-02-09 11:26:36 +01:00
bfq-iosched.c	block, bfq: fix uaf for bfqq in bic_set_bfqq()	2023-02-09 11:26:36 +01:00
bfq-iosched.h	bfq: Get rid of __bio_blkcg() usage	2022-06-09 10:23:19 +02:00
bfq-wf2q.c	block/bfq_wf2q: correct weight to ioprio	2022-04-08 14:23:55 +02:00
bio-integrity.c	block: bio-integrity: Copy flags when bio_integrity_payload is cloned	2023-03-10 09:39:05 +01:00
bio.c	block: prevent an integer overflow in bvec_try_merge_hw_page	2024-02-23 08:54:44 +01:00
blk-cgroup-rwstat.c	blk-cgroup: Fix the recursive blkg rwstat	2021-03-05 11:32:15 -07:00
blk-cgroup-rwstat.h
blk-cgroup.c	blk-cgroup: bypass blkcg_deactivate_policy after destroying	2023-12-20 15:17:39 +01:00
blk-core.c	blk-core: use pr_warn_ratelimited() in bio_check_ro()	2023-11-20 11:08:29 +01:00
blk-crypto-fallback.c	block: rename BIO_MAX_PAGES to BIO_MAX_VECS	2021-03-11 07:47:48 -07:00
blk-crypto-internal.h	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-crypto.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-11 23:00:16 +09:00
blk-exec.c	block: return errors from blk_execute_rq()	2021-06-30 15:35:45 -06:00
blk-flush.c	block: Fix fsync always failed if once failed	2022-01-27 11:05:25 +01:00
blk-integrity.c	block: flush the integrity workqueue in blk_integrity_unregister	2021-09-14 20:03:30 -06:00
blk-ioc.c	block: fix default IO priority handling again	2022-08-11 13:07:50 +02:00
blk-iocost.c	blk-iocost: Fix an UBSAN shift-out-of-bounds warning	2024-02-23 08:54:59 +01:00
blk-iolatency.c	block: don't allow the same type rq_qos add more than once	2022-08-17 14:24:24 +02:00
blk-ioprio.c	block: Introduce the ioprio rq-qos policy	2021-06-21 15:03:40 -06:00
blk-ioprio.h	block: Introduce the ioprio rq-qos policy	2021-06-21 15:03:40 -06:00
blk-lib.c	block: export blk_next_bio()	2021-06-17 15:51:20 +02:00
blk-map.c	block-map: add __GFP_ZERO flag for alloc_page in function bio_copy_kern	2022-03-08 19:12:31 +01:00
blk-merge.c	blk-mq: release crypto keyslot before reporting I/O complete	2023-05-11 23:00:16 +09:00
blk-mq-cpumap.c
blk-mq-debugfs-zoned.c
blk-mq-debugfs.c	blk-mq: don't create hctx debugfs dir until q->debugfs_dir is created	2022-08-17 14:23:12 +02:00
blk-mq-debugfs.h
blk-mq-pci.c
blk-mq-rdma.c
blk-mq-sched.c	blk-mq: correct stale comment of .get_budget	2023-03-10 09:39:04 +01:00
blk-mq-sched.h	blk: Fix lock inversion between ioc lock and bfqd lock	2021-06-24 18:43:55 -06:00
blk-mq-sysfs.c	blk-mq: fix possible memleak when register 'hctx' failed	2022-12-31 13:14:43 +01:00
blk-mq-tag.c	blk-mq: avoid to iterate over stale request	2021-09-12 19:32:43 -06:00
blk-mq-tag.h	blk-mq: Some tag allocation code refactoring	2021-05-24 06:47:22 -06:00
blk-mq-virtio.c
blk-mq.c	blk-mq: fix IO hang from sbitmap wakeup race	2024-02-23 08:54:52 +01:00
blk-mq.h	blk-mq: cancel blk-mq dispatch work in both blk_cleanup_queue and disk_release()	2021-12-01 09:04:56 +01:00
blk-pm.c	scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()	2022-01-27 11:04:15 +01:00
blk-pm.h	block: Remove unused blk_pm_*() function definitions	2021-02-22 06:33:48 -07:00
blk-rq-qos.c	rq-qos: fix missed wake-ups in rq_qos_throttle try two	2021-06-08 15:12:57 -06:00
blk-rq-qos.h	block: don't allow the same type rq_qos add more than once	2022-08-17 14:24:24 +02:00
blk-settings.c	block: make BLK_DEF_MAX_SECTORS unsigned	2024-01-25 14:52:40 -08:00
blk-stat.c
blk-stat.h
blk-sysfs.c	block: fix use-after-free of q->q_usage_counter	2023-10-10 21:59:05 +02:00
blk-throttle.c	blk-throttle: fix lockdep warning of "cgroup_mutex or RCU read lock required!"	2023-12-20 15:17:39 +01:00
blk-timeout.c
blk-wbt.c	blk-wbt: fix that 'rwb->wc' is always set to 1 in wbt_init()	2022-10-26 12:35:54 +02:00
blk-wbt.h	blk-wbt: introduce a new disable state to prevent false positive by rwb_enabled()	2021-06-21 15:03:41 -06:00
blk-zoned.c	block: Hold invalidate_lock in BLKRESETZONE ioctl	2021-11-18 19:17:15 +01:00
blk.h	block: bump max plugged deferred size from 16 to 32	2021-11-18 19:16:16 +01:00
bounce.c	block: use memcpy_from_bvec in __blk_queue_bounce	2021-08-02 13:37:28 -06:00
bsg-lib.c	scsi: bsg-lib: Fix commands without data transfer in bsg_transport_sg_io_fn()	2021-08-01 13:21:40 -04:00
bsg.c	scsi: bsg: Fix device unregistration	2021-09-14 00:22:15 -04:00
disk-events.c	block: increment diskseq on all media change events	2023-07-23 13:47:20 +02:00
elevator.c	block/wbt: fix negative inflight counter when remove scsi device	2022-02-23 12:03:15 +01:00
fops.c	block: Don't invalidate pagecache for invalid falloc modes	2024-01-15 18:51:07 +01:00
genhd.c	block: add check of 'minors' and 'first_minor' in device_add_disk()	2024-01-25 14:52:39 -08:00
holder.c	block: drop unused includes in <linux/genhd.h>	2022-03-16 14:23:46 +01:00
ioctl.c	block: Move checking GENHD_FL_NO_PART to bdev_add_partition()	2024-02-23 08:54:35 +01:00
ioprio.c	block: fix default IO priority handling again	2022-08-11 13:07:50 +02:00
Kconfig	SCSI misc on 20210902	2021-09-02 15:09:46 -07:00
Kconfig.iosched	Revert "block/mq-deadline: Add cgroup support"	2021-08-11 13:47:26 -06:00
keyslot-manager.c	blk-crypto: make blk_crypto_evict_key() more robust	2023-05-11 23:00:16 +09:00
kyber-iosched.c	kyber: avoid q->disk dereferences in trace points	2021-10-15 21:02:57 -06:00
Makefile	block: move CONFIG_BLOCK guard to top Makefile	2022-12-14 11:37:30 +01:00
mq-deadline.c	block: mq-deadline: Rename deadline_is_seq_writes()	2023-01-24 07:22:49 +01:00
opal_proto.h
sed-opal.c	block: sed-opal: kmalloc the cmd/resp buffers	2022-11-26 09:24:35 +01:00
t10-pi.c	block: use bvec_kmap_local in t10_pi_type1_{prepare,complete}	2021-08-02 13:37:28 -06:00