mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
3e2ccfd93c
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230920125829.1478827-13-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
164 lines
4.2 KiB
C
164 lines
4.2 KiB
C
/*
|
|
* Marvell 88PM80x ONKEY driver
|
|
*
|
|
* Copyright (C) 2012 Marvell International Ltd.
|
|
* Haojian Zhuang <haojian.zhuang@marvell.com>
|
|
* Qiao Zhou <zhouqiao@marvell.com>
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General
|
|
* Public License. See the file "COPYING" in the main directory of this
|
|
* archive for more details.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/input.h>
|
|
#include <linux/mfd/88pm80x.h>
|
|
#include <linux/regmap.h>
|
|
#include <linux/slab.h>
|
|
|
|
#define PM800_LONG_ONKEY_EN (1 << 0)
|
|
#define PM800_LONG_KEY_DELAY (8) /* 1 .. 16 seconds */
|
|
#define PM800_LONKEY_PRESS_TIME ((PM800_LONG_KEY_DELAY-1) << 4)
|
|
#define PM800_LONKEY_PRESS_TIME_MASK (0xF0)
|
|
#define PM800_SW_PDOWN (1 << 5)
|
|
|
|
struct pm80x_onkey_info {
|
|
struct input_dev *idev;
|
|
struct pm80x_chip *pm80x;
|
|
struct regmap *map;
|
|
int irq;
|
|
};
|
|
|
|
/* 88PM80x gives us an interrupt when ONKEY is held */
|
|
static irqreturn_t pm80x_onkey_handler(int irq, void *data)
|
|
{
|
|
struct pm80x_onkey_info *info = data;
|
|
int ret = 0;
|
|
unsigned int val;
|
|
|
|
ret = regmap_read(info->map, PM800_STATUS_1, &val);
|
|
if (ret < 0) {
|
|
dev_err(info->idev->dev.parent, "failed to read status: %d\n", ret);
|
|
return IRQ_NONE;
|
|
}
|
|
val &= PM800_ONKEY_STS1;
|
|
|
|
input_report_key(info->idev, KEY_POWER, val);
|
|
input_sync(info->idev);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static SIMPLE_DEV_PM_OPS(pm80x_onkey_pm_ops, pm80x_dev_suspend,
|
|
pm80x_dev_resume);
|
|
|
|
static int pm80x_onkey_probe(struct platform_device *pdev)
|
|
{
|
|
|
|
struct pm80x_chip *chip = dev_get_drvdata(pdev->dev.parent);
|
|
struct pm80x_onkey_info *info;
|
|
int err;
|
|
|
|
info = kzalloc(sizeof(struct pm80x_onkey_info), GFP_KERNEL);
|
|
if (!info)
|
|
return -ENOMEM;
|
|
|
|
info->pm80x = chip;
|
|
|
|
info->irq = platform_get_irq(pdev, 0);
|
|
if (info->irq < 0) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
info->map = info->pm80x->regmap;
|
|
if (!info->map) {
|
|
dev_err(&pdev->dev, "no regmap!\n");
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
info->idev = input_allocate_device();
|
|
if (!info->idev) {
|
|
dev_err(&pdev->dev, "Failed to allocate input dev\n");
|
|
err = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
info->idev->name = "88pm80x_on";
|
|
info->idev->phys = "88pm80x_on/input0";
|
|
info->idev->id.bustype = BUS_I2C;
|
|
info->idev->dev.parent = &pdev->dev;
|
|
info->idev->evbit[0] = BIT_MASK(EV_KEY);
|
|
__set_bit(KEY_POWER, info->idev->keybit);
|
|
|
|
err = pm80x_request_irq(info->pm80x, info->irq, pm80x_onkey_handler,
|
|
IRQF_ONESHOT, "onkey", info);
|
|
if (err < 0) {
|
|
dev_err(&pdev->dev, "Failed to request IRQ: #%d: %d\n",
|
|
info->irq, err);
|
|
goto out_reg;
|
|
}
|
|
|
|
err = input_register_device(info->idev);
|
|
if (err) {
|
|
dev_err(&pdev->dev, "Can't register input device: %d\n", err);
|
|
goto out_irq;
|
|
}
|
|
|
|
platform_set_drvdata(pdev, info);
|
|
|
|
/* Enable long onkey detection */
|
|
regmap_update_bits(info->map, PM800_RTC_MISC4, PM800_LONG_ONKEY_EN,
|
|
PM800_LONG_ONKEY_EN);
|
|
/* Set 8-second interval */
|
|
regmap_update_bits(info->map, PM800_RTC_MISC3,
|
|
PM800_LONKEY_PRESS_TIME_MASK,
|
|
PM800_LONKEY_PRESS_TIME);
|
|
|
|
device_init_wakeup(&pdev->dev, 1);
|
|
return 0;
|
|
|
|
out_irq:
|
|
pm80x_free_irq(info->pm80x, info->irq, info);
|
|
out_reg:
|
|
input_free_device(info->idev);
|
|
out:
|
|
kfree(info);
|
|
return err;
|
|
}
|
|
|
|
static void pm80x_onkey_remove(struct platform_device *pdev)
|
|
{
|
|
struct pm80x_onkey_info *info = platform_get_drvdata(pdev);
|
|
|
|
pm80x_free_irq(info->pm80x, info->irq, info);
|
|
input_unregister_device(info->idev);
|
|
kfree(info);
|
|
}
|
|
|
|
static struct platform_driver pm80x_onkey_driver = {
|
|
.driver = {
|
|
.name = "88pm80x-onkey",
|
|
.pm = &pm80x_onkey_pm_ops,
|
|
},
|
|
.probe = pm80x_onkey_probe,
|
|
.remove_new = pm80x_onkey_remove,
|
|
};
|
|
|
|
module_platform_driver(pm80x_onkey_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Marvell 88PM80x ONKEY driver");
|
|
MODULE_AUTHOR("Qiao Zhou <zhouqiao@marvell.com>");
|
|
MODULE_ALIAS("platform:88pm80x-onkey");
|