mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
6d3a5b8254
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230920125829.1478827-17-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
142 lines
3 KiB
C
142 lines
3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* m68k beeper driver for Linux
|
|
*
|
|
* Copyright (c) 2002 Richard Zidlicky
|
|
* Copyright (c) 2002 Vojtech Pavlik
|
|
* Copyright (c) 1992 Orest Zborowski
|
|
*/
|
|
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/input.h>
|
|
#include <linux/platform_device.h>
|
|
#include <asm/machdep.h>
|
|
#include <asm/io.h>
|
|
|
|
MODULE_AUTHOR("Richard Zidlicky <rz@linux-m68k.org>");
|
|
MODULE_DESCRIPTION("m68k beeper driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static struct platform_device *m68kspkr_platform_device;
|
|
|
|
static int m68kspkr_event(struct input_dev *dev, unsigned int type, unsigned int code, int value)
|
|
{
|
|
unsigned int count = 0;
|
|
|
|
if (type != EV_SND)
|
|
return -1;
|
|
|
|
switch (code) {
|
|
case SND_BELL: if (value) value = 1000;
|
|
case SND_TONE: break;
|
|
default: return -1;
|
|
}
|
|
|
|
if (value > 20 && value < 32767)
|
|
count = 1193182 / value;
|
|
|
|
mach_beep(count, -1);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int m68kspkr_probe(struct platform_device *dev)
|
|
{
|
|
struct input_dev *input_dev;
|
|
int err;
|
|
|
|
input_dev = input_allocate_device();
|
|
if (!input_dev)
|
|
return -ENOMEM;
|
|
|
|
input_dev->name = "m68k beeper";
|
|
input_dev->phys = "m68k/generic";
|
|
input_dev->id.bustype = BUS_HOST;
|
|
input_dev->id.vendor = 0x001f;
|
|
input_dev->id.product = 0x0001;
|
|
input_dev->id.version = 0x0100;
|
|
input_dev->dev.parent = &dev->dev;
|
|
|
|
input_dev->evbit[0] = BIT_MASK(EV_SND);
|
|
input_dev->sndbit[0] = BIT_MASK(SND_BELL) | BIT_MASK(SND_TONE);
|
|
input_dev->event = m68kspkr_event;
|
|
|
|
err = input_register_device(input_dev);
|
|
if (err) {
|
|
input_free_device(input_dev);
|
|
return err;
|
|
}
|
|
|
|
platform_set_drvdata(dev, input_dev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void m68kspkr_remove(struct platform_device *dev)
|
|
{
|
|
struct input_dev *input_dev = platform_get_drvdata(dev);
|
|
|
|
input_unregister_device(input_dev);
|
|
/* turn off the speaker */
|
|
m68kspkr_event(NULL, EV_SND, SND_BELL, 0);
|
|
}
|
|
|
|
static void m68kspkr_shutdown(struct platform_device *dev)
|
|
{
|
|
/* turn off the speaker */
|
|
m68kspkr_event(NULL, EV_SND, SND_BELL, 0);
|
|
}
|
|
|
|
static struct platform_driver m68kspkr_platform_driver = {
|
|
.driver = {
|
|
.name = "m68kspkr",
|
|
},
|
|
.probe = m68kspkr_probe,
|
|
.remove_new = m68kspkr_remove,
|
|
.shutdown = m68kspkr_shutdown,
|
|
};
|
|
|
|
static int __init m68kspkr_init(void)
|
|
{
|
|
int err;
|
|
|
|
if (!mach_beep) {
|
|
printk(KERN_INFO "m68kspkr: no lowlevel beep support\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
err = platform_driver_register(&m68kspkr_platform_driver);
|
|
if (err)
|
|
return err;
|
|
|
|
m68kspkr_platform_device = platform_device_alloc("m68kspkr", -1);
|
|
if (!m68kspkr_platform_device) {
|
|
err = -ENOMEM;
|
|
goto err_unregister_driver;
|
|
}
|
|
|
|
err = platform_device_add(m68kspkr_platform_device);
|
|
if (err)
|
|
goto err_free_device;
|
|
|
|
return 0;
|
|
|
|
err_free_device:
|
|
platform_device_put(m68kspkr_platform_device);
|
|
err_unregister_driver:
|
|
platform_driver_unregister(&m68kspkr_platform_driver);
|
|
|
|
return err;
|
|
}
|
|
|
|
static void __exit m68kspkr_exit(void)
|
|
{
|
|
platform_device_unregister(m68kspkr_platform_device);
|
|
platform_driver_unregister(&m68kspkr_platform_driver);
|
|
}
|
|
|
|
module_init(m68kspkr_init);
|
|
module_exit(m68kspkr_exit);
|