Brian Geffon 0756504578 PM: hibernate: Clean up sync_read handling in snapshot_write_next() ... commit d08970df19 upstream. In snapshot_write_next(), sync_read is set and unset in three different spots unnecessiarly. As a result there is a subtle bug where the first page after the meta data has been loaded unconditionally sets sync_read to 0. If this first PFN was actually a highmem page, then the returned buffer will be the global "buffer," and the page needs to be loaded synchronously. That is, I'm not sure we can always assume the following to be safe: handle->buffer = get_buffer(&orig_bm, &ca); handle->sync_read = 0; Because get_buffer() can call get_highmem_page_buffer() which can return 'buffer'. The easiest way to address this is just set sync_read before snapshot_write_next() returns if handle->buffer == buffer. Signed-off-by: Brian Geffon <bgeffon@google.com> Fixes: 8357376d3d ("[PATCH] swsusp: Improve handling of highmem") Cc: All applicable <stable@vger.kernel.org> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-11-28 17:20:02 +00:00
..
autosleep.c	PM: sleep: fix typos in comments	2021-04-08 19:37:21 +02:00
console.c
energy_model.c	PM: EM: fix memory leak with using debugfs_lookup()	2023-02-09 20:36:10 +01:00
hibernate.c	PM: hibernate: Fix the exclusive get block device in test_resume mode	2023-09-12 11:45:15 +02:00
Kconfig	PM: sleep: Remove "select SRCU"	2023-01-20 17:53:07 +01:00
main.c	- Yosry Ahmed brought back some cgroup v1 stats in OOM logs.	2023-06-28 10:28:11 -07:00
Makefile	PM: sleep: Narrow down -DDEBUG on kernel/power/ files	2022-04-13 16:34:01 +02:00
power.h	PM: hibernate: Rename function parameter from snapshot_test to exclusive	2023-09-12 11:45:15 +02:00
poweroff.c	tty: sysrq: switch sysrq handlers from int to u8	2023-07-25 19:21:03 +02:00
process.c	workqueue: Introduce show_freezable_workqueues	2023-03-23 15:55:38 -10:00
qos.c	PM: QoS: Add check to make sure CPU latency is non-negative	2023-08-22 21:37:29 +02:00
snapshot.c	PM: hibernate: Clean up sync_read handling in snapshot_write_next()	2023-11-28 17:20:02 +00:00
suspend.c	Scheduler changes for v6.1:	2022-10-10 09:10:28 -07:00
suspend_test.c	PM: suspend: fix return value of __setup handler	2022-03-01 18:55:07 +01:00
swap.c	PM: hibernate: Rename function parameter from snapshot_test to exclusive	2023-09-12 11:45:15 +02:00
user.c	freezer: Have {,un}lock_system_sleep() save/restore flags	2022-09-07 21:53:48 +02:00
wakelock.c	PM: wakeup: simplify the output logic of pm_show_wakelocks()	2022-01-25 18:27:02 +01:00