mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
d2a02e3c8b
blake2s_compress_generic is weakly aliased by blake2s_compress. The
current harness for function selection uses a function pointer, which is
ordinarily inlined and resolved at compile time. But when Clang's CFI is
enabled, CFI still triggers when making an indirect call via a weak
symbol. This seems like a bug in Clang's CFI, as though it's bucketing
weak symbols and strong symbols differently. It also only seems to
trigger when "full LTO" mode is used, rather than "thin LTO".
[ 0.000000][ T0] Kernel panic - not syncing: CFI failure (target: blake2s_compress_generic+0x0/0x1444)
[ 0.000000][ T0] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.16.0-mainline-06981-g076c855b846e #1
[ 0.000000][ T0] Hardware name: MT6873 (DT)
[ 0.000000][ T0] Call trace:
[ 0.000000][ T0] dump_backtrace+0xfc/0x1dc
[ 0.000000][ T0] dump_stack_lvl+0xa8/0x11c
[ 0.000000][ T0] panic+0x194/0x464
[ 0.000000][ T0] __cfi_check_fail+0x54/0x58
[ 0.000000][ T0] __cfi_slowpath_diag+0x354/0x4b0
[ 0.000000][ T0] blake2s_update+0x14c/0x178
[ 0.000000][ T0] _extract_entropy+0xf4/0x29c
[ 0.000000][ T0] crng_initialize_primary+0x24/0x94
[ 0.000000][ T0] rand_initialize+0x2c/0x6c
[ 0.000000][ T0] start_kernel+0x2f8/0x65c
[ 0.000000][ T0] __primary_switched+0xc4/0x7be4
[ 0.000000][ T0] Rebooting in 5 seconds..
Nonetheless, the function pointer method isn't so terrific anyway, so
this patch replaces it with a simple boolean, which also gets inlined
away. This successfully works around the Clang bug.
In general, I'm not too keen on all of the indirection involved here; it
clearly does more harm than good. Hopefully the whole thing can get
cleaned up down the road when lib/crypto is overhauled more
comprehensively. But for now, we go with a simple bandaid.
Fixes:
|
||
---|---|---|
.. | ||
internal | ||
acompress.h | ||
aead.h | ||
aes.h | ||
akcipher.h | ||
algapi.h | ||
arc4.h | ||
asym_tpm_subtype.h | ||
authenc.h | ||
b128ops.h | ||
blake2b.h | ||
blake2s.h | ||
blowfish.h | ||
cast5.h | ||
cast6.h | ||
cast_common.h | ||
chacha.h | ||
chacha20poly1305.h | ||
cryptd.h | ||
ctr.h | ||
curve25519.h | ||
des.h | ||
dh.h | ||
drbg.h | ||
ecc_curve.h | ||
ecdh.h | ||
engine.h | ||
gcm.h | ||
gf128mul.h | ||
ghash.h | ||
hash.h | ||
hash_info.h | ||
hmac.h | ||
if_alg.h | ||
kdf_sp800108.h | ||
kpp.h | ||
md5.h | ||
nhpoly1305.h | ||
null.h | ||
padlock.h | ||
pcrypt.h | ||
pkcs7.h | ||
poly1305.h | ||
public_key.h | ||
rng.h | ||
scatterwalk.h | ||
serpent.h | ||
sha1.h | ||
sha1_base.h | ||
sha2.h | ||
sha3.h | ||
sha256_base.h | ||
sha512_base.h | ||
skcipher.h | ||
sm2.h | ||
sm3.h | ||
sm3_base.h | ||
sm4.h | ||
streebog.h | ||
twofish.h | ||
xts.h |