mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 22:25:03 +00:00
f0a5157803
While the dest comm string size is assured to be at least TASK_COMM_LEN long, doing a memcpy() also adds the assumption that the source is at least that long as well, which isn't assured, and isn't true in cases such as: set_task_comm(worker->task, "kworker/dying"); This leads to accessing invalid memory. Link: http://lkml.kernel.org/r/1440760018-1557-1-git-send-email-sasha.levin@oracle.com Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
61 lines
1.5 KiB
C
61 lines
1.5 KiB
C
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM task
|
|
|
|
#if !defined(_TRACE_TASK_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_TASK_H
|
|
#include <linux/tracepoint.h>
|
|
|
|
TRACE_EVENT(task_newtask,
|
|
|
|
TP_PROTO(struct task_struct *task, unsigned long clone_flags),
|
|
|
|
TP_ARGS(task, clone_flags),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( pid_t, pid)
|
|
__array( char, comm, TASK_COMM_LEN)
|
|
__field( unsigned long, clone_flags)
|
|
__field( short, oom_score_adj)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pid = task->pid;
|
|
memcpy(__entry->comm, task->comm, TASK_COMM_LEN);
|
|
__entry->clone_flags = clone_flags;
|
|
__entry->oom_score_adj = task->signal->oom_score_adj;
|
|
),
|
|
|
|
TP_printk("pid=%d comm=%s clone_flags=%lx oom_score_adj=%hd",
|
|
__entry->pid, __entry->comm,
|
|
__entry->clone_flags, __entry->oom_score_adj)
|
|
);
|
|
|
|
TRACE_EVENT(task_rename,
|
|
|
|
TP_PROTO(struct task_struct *task, const char *comm),
|
|
|
|
TP_ARGS(task, comm),
|
|
|
|
TP_STRUCT__entry(
|
|
__field( pid_t, pid)
|
|
__array( char, oldcomm, TASK_COMM_LEN)
|
|
__array( char, newcomm, TASK_COMM_LEN)
|
|
__field( short, oom_score_adj)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
__entry->pid = task->pid;
|
|
memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
|
|
strlcpy(entry->newcomm, comm, TASK_COMM_LEN);
|
|
__entry->oom_score_adj = task->signal->oom_score_adj;
|
|
),
|
|
|
|
TP_printk("pid=%d oldcomm=%s newcomm=%s oom_score_adj=%hd",
|
|
__entry->pid, __entry->oldcomm,
|
|
__entry->newcomm, __entry->oom_score_adj)
|
|
);
|
|
|
|
#endif
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|