Yonglong Liu 8601a99d7c net: hns: Fix WARNING when remove HNS driver with SMMU enabled ... When enable SMMU, remove HNS driver will cause a WARNING: [ 141.924177] WARNING: CPU: 36 PID: 2708 at drivers/iommu/dma-iommu.c:443 __iommu_dma_unmap+0xc0/0xc8 [ 141.954673] Modules linked in: hns_enet_drv(-) [ 141.963615] CPU: 36 PID: 2708 Comm: rmmod Tainted: G W 5.0.0-rc1-28723-gb729c57de95c-dirty #32 [ 141.983593] Hardware name: Huawei D05/D05, BIOS Hisilicon D05 UEFI Nemo 1.8 RC0 08/31/2017 [ 142.000244] pstate: 60000005 (nZCv daif -PAN -UAO) [ 142.009886] pc : __iommu_dma_unmap+0xc0/0xc8 [ 142.018476] lr : __iommu_dma_unmap+0xc0/0xc8 [ 142.027066] sp : ffff000013533b90 [ 142.033728] x29: ffff000013533b90 x28: ffff8013e6983600 [ 142.044420] x27: 0000000000000000 x26: 0000000000000000 [ 142.055113] x25: 0000000056000000 x24: 0000000000000015 [ 142.065806] x23: 0000000000000028 x22: ffff8013e66eee68 [ 142.076499] x21: ffff8013db919800 x20: 0000ffffefbff000 [ 142.087192] x19: 0000000000001000 x18: 0000000000000007 [ 142.097885] x17: 000000000000000e x16: 0000000000000001 [ 142.108578] x15: 0000000000000019 x14: 363139343a70616d [ 142.119270] x13: 6e75656761705f67 x12: 0000000000000000 [ 142.129963] x11: 00000000ffffffff x10: 0000000000000006 [ 142.140656] x9 : 1346c1aa88093500 x8 : ffff0000114de4e0 [ 142.151349] x7 : 6662666578303d72 x6 : ffff0000105ffec8 [ 142.162042] x5 : 0000000000000000 x4 : 0000000000000000 [ 142.172734] x3 : 00000000ffffffff x2 : ffff0000114de500 [ 142.183427] x1 : 0000000000000000 x0 : 0000000000000035 [ 142.194120] Call trace: [ 142.199030] __iommu_dma_unmap+0xc0/0xc8 [ 142.206920] iommu_dma_unmap_page+0x20/0x28 [ 142.215335] __iommu_unmap_page+0x40/0x60 [ 142.223399] hnae_unmap_buffer+0x110/0x134 [ 142.231639] hnae_free_desc+0x6c/0x10c [ 142.239177] hnae_fini_ring+0x14/0x34 [ 142.246540] hnae_fini_queue+0x2c/0x40 [ 142.254080] hnae_put_handle+0x38/0xcc [ 142.261619] hns_nic_dev_remove+0x54/0xfc [hns_enet_drv] [ 142.272312] platform_drv_remove+0x24/0x64 [ 142.280552] device_release_driver_internal+0x17c/0x20c [ 142.291070] driver_detach+0x4c/0x90 [ 142.298259] bus_remove_driver+0x5c/0xd8 [ 142.306148] driver_unregister+0x2c/0x54 [ 142.314037] platform_driver_unregister+0x10/0x18 [ 142.323505] hns_nic_dev_driver_exit+0x14/0xf0c [hns_enet_drv] [ 142.335248] __arm64_sys_delete_module+0x214/0x25c [ 142.344891] el0_svc_common+0xb0/0x10c [ 142.352430] el0_svc_handler+0x24/0x80 [ 142.359968] el0_svc+0x8/0x7c0 [ 142.366104] ---[ end trace 60ad1cd58e63c407 ]--- The tx ring buffer map when xmit and unmap when xmit done. So in hnae_init_ring() did not map tx ring buffer, but in hnae_fini_ring() have a unmap operation for tx ring buffer, which is already unmapped when xmit done, than cause this WARNING. The hnae_alloc_buffers() is called in hnae_init_ring(), so the hnae_free_buffers() should be in hnae_fini_ring(), not in hnae_free_desc(). In hnae_fini_ring(), adds a check is_rx_ring() as in hnae_init_ring(). When the ring buffer is tx ring, adds a piece of code to ensure that the tx ring is unmap. Signed-off-by: Yonglong Liu <liuyonglong@huawei.com> Signed-off-by: Peng Li <lipeng321@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-04-04 10:35:42 -07:00
..
appletalk
arcnet
bonding	bonding: show full hw address in sysfs for slave entries	2019-03-29 13:32:39 -07:00
caif
can	peak_usb: fix clang build warning	2019-03-07 09:39:46 -08:00
dsa	net: dsa: mv88e6xxx: fix few issues in mv88e6390x_port_set_cmode	2019-03-27 21:53:50 -07:00
ethernet	net: hns: Fix WARNING when remove HNS driver with SMMU enabled	2019-04-04 10:35:42 -07:00
fddi
fjes
hamradio
hippi
hyperv	hv_netvsc: Fix unwanted wakeup after tx_disable	2019-03-29 13:34:01 -07:00
ieee802154	ieee802154: hwsim: propagate genlmsg_reply return code	2019-03-13 10:13:26 +01:00
ipvlan
netdevsim
phy	net: phy: bcm54xx: Encode link speed and activity into LEDs	2019-03-26 11:24:47 -07:00
plip
ppp	pptp: dst_release sk_dst_cache in pptp_sock_destruct	2019-03-13 14:22:49 -07:00
slip
team	team: Free BPF filter when unregistering netdev	2019-03-04 10:57:29 -08:00
usb	qmi_wwan: add Olicard 600	2019-03-28 16:58:06 -07:00
vmxnet3
wan	net: wan: z85230: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop profiles	2019-02-25 14:36:15 -08:00
wimax
wireless	mt76x02: do not enable RTS/CTS by default	2019-03-19 17:37:25 +02:00
xen-netback	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-03-02 12:54:35 -08:00
dummy.c
eql.c
geneve.c	geneve: correctly handle ipv6.disable module parameter	2019-03-01 22:07:56 -08:00
gtp.c
ifb.c
Kconfig	gtp: change NET_UDP_TUNNEL dependency to select	2019-03-18 16:54:42 -07:00
LICENSE.SRC
loopback.c
macsec.c
macvlan.c
macvtap.c
Makefile
mdio.c
mii.c
net_failover.c
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tap.c
thunderbolt.c
tun.c	tun: add a missing rcu_read_unlock() in error path	2019-03-16 13:16:37 -07:00
veth.c
virtio_net.c
vrf.c	vrf: prevent adding upper devices	2019-03-27 22:54:38 -07:00
vsockmon.c
vxlan.c	vxlan: Don't call gro_cells_destroy() before device is unregistered	2019-03-18 17:07:27 -07:00
xen-netfront.c