Sebastian Andrzej Siewior d2576d29da hsr: Synchronize sequence number updates. ... [ Upstream commit 5c7aa13210 ] hsr_register_frame_out() compares new sequence_nr vs the old one recorded in hsr_node::seq_out and if the new sequence_nr is higher then it will be written to hsr_node::seq_out as the new value. This operation isn't locked so it is possible that two frames with the same sequence number arrive (via the two slave devices) and are fed to hsr_register_frame_out() at the same time. Both will pass the check and update the sequence counter later to the same value. As a result the content of the same packet is fed into the stack twice. This was noticed by running ping and observing DUP being reported from time to time. Instead of using the hsr_priv::seqnr_lock for the whole receive path (as it is for sending in the master node) add an additional lock that is only used for sequence number checks and updates. Add a per-node lock that is used during sequence number reads and updates. Fixes: f421436a59 ("net/hsr: Add support for the High-availability Seamless Redundancy protocol (HSRv0)") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-12-31 13:32:22 +01:00
..
hsr_debugfs.c	Revert "net: hsr: use hlist_head instead of list_head for mac addresses"	2022-12-31 13:32:21 +01:00
hsr_device.c	hsr: Synchronize sending frames to have always incremented outgoing seq nr.	2022-12-31 13:32:22 +01:00
hsr_device.h
hsr_forward.c	hsr: Synchronize sending frames to have always incremented outgoing seq nr.	2022-12-31 13:32:22 +01:00
hsr_forward.h
hsr_framereg.c	hsr: Synchronize sequence number updates.	2022-12-31 13:32:22 +01:00
hsr_framereg.h	hsr: Synchronize sequence number updates.	2022-12-31 13:32:22 +01:00
hsr_main.c
hsr_main.h	Revert "net: hsr: use hlist_head instead of list_head for mac addresses"	2022-12-31 13:32:21 +01:00
hsr_netlink.c	Revert "net: hsr: use hlist_head instead of list_head for mac addresses"	2022-12-31 13:32:21 +01:00
hsr_netlink.h
hsr_slave.c
hsr_slave.h
Kconfig
Makefile