mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-22 18:41:06 +00:00
87b0d8d3d0
Recently, journal pre-reservations were removed. They were for reserving space ahead of time in the journal for operations that are required for journal reclaim, e.g. btree key cache flushing and interior node btree updates. Instead we have watermarks - only operations for journal reclaim are allowed when the journal is low on space, and in general we're quite good about doing operations in the order that will free up space in the journal quickest when we're low on space. If we're doing a journal reclaim operation out of order, we usually do it in nonblocking mode if it's not freeing up space at the end of the journal. There's an exceptino though - interior btree node update operations have to be BCH_WATERMARK_reclaim - once they've been started, and they can't be nonblocking. Generally this is fine because they'll only be a very small fraction of transaction commits - but there's an exception, which is during journal replay. Journal replay does many btree operations, but doesn't need to commit them to the journal since they're already in the journal. So killing off of pre-reservation, plus another change to make journal replay more efficient by initially doing the replay in sorted btree order, made it possible for the interior update operations replay generates to fill and deadlock the journal. Fix this by introducing a new check on journal space at the _start_ of an interior update operation. This causes us to block if necessary in exactly the same way as we used to when interior updates took a journal pre-reservaiton, but without all the expensive accounting pre-reservations required. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> |
||
|---|---|---|
| .. | ||
| acl.c | ||
| acl.h | ||
| alloc_background.c | ||
| alloc_background.h | ||
| alloc_foreground.c | ||
| alloc_foreground.h | ||
| alloc_types.h | ||
| backpointers.c | ||
| backpointers.h | ||
| bbpos.h | ||
| bbpos_types.h | ||
| bcachefs.h | ||
| bcachefs_format.h | ||
| bcachefs_ioctl.h | ||
| bkey.c | ||
| bkey.h | ||
| bkey_buf.h | ||
| bkey_cmp.h | ||
| bkey_methods.c | ||
| bkey_methods.h | ||
| bkey_sort.c | ||
| bkey_sort.h | ||
| bset.c | ||
| bset.h | ||
| btree_cache.c | ||
| btree_cache.h | ||
| btree_gc.c | ||
| btree_gc.h | ||
| btree_io.c | ||
| btree_io.h | ||
| btree_iter.c | ||
| btree_iter.h | ||
| btree_journal_iter.c | ||
| btree_journal_iter.h | ||
| btree_key_cache.c | ||
| btree_key_cache.h | ||
| btree_key_cache_types.h | ||
| btree_locking.c | ||
| btree_locking.h | ||
| btree_trans_commit.c | ||
| btree_types.h | ||
| btree_update.c | ||
| btree_update.h | ||
| btree_update_interior.c | ||
| btree_update_interior.h | ||
| btree_write_buffer.c | ||
| btree_write_buffer.h | ||
| btree_write_buffer_types.h | ||
| buckets.c | ||
| buckets.h | ||
| buckets_types.h | ||
| buckets_waiting_for_journal.c | ||
| buckets_waiting_for_journal.h | ||
| buckets_waiting_for_journal_types.h | ||
| chardev.c | ||
| chardev.h | ||
| checksum.c | ||
| checksum.h | ||
| clock.c | ||
| clock.h | ||
| clock_types.h | ||
| compress.c | ||
| compress.h | ||
| counters.c | ||
| counters.h | ||
| darray.h | ||
| data_update.c | ||
| data_update.h | ||
| debug.c | ||
| debug.h | ||
| dirent.c | ||
| dirent.h | ||
| disk_groups.c | ||
| disk_groups.h | ||
| disk_groups_types.h | ||
| ec.c | ||
| ec.h | ||
| ec_types.h | ||
| errcode.c | ||
| errcode.h | ||
| error.c | ||
| error.h | ||
| extent_update.c | ||
| extent_update.h | ||
| extents.c | ||
| extents.h | ||
| extents_types.h | ||
| eytzinger.h | ||
| fifo.h | ||
| fs-common.c | ||
| fs-common.h | ||
| fs-io-buffered.c | ||
| fs-io-buffered.h | ||
| fs-io-direct.c | ||
| fs-io-direct.h | ||
| fs-io-pagecache.c | ||
| fs-io-pagecache.h | ||
| fs-io.c | ||
| fs-io.h | ||
| fs-ioctl.c | ||
| fs-ioctl.h | ||
| fs.c | ||
| fs.h | ||
| fsck.c | ||
| fsck.h | ||
| inode.c | ||
| inode.h | ||
| io_misc.c | ||
| io_misc.h | ||
| io_read.c | ||
| io_read.h | ||
| io_write.c | ||
| io_write.h | ||
| io_write_types.h | ||
| journal.c | ||
| journal.h | ||
| journal_io.c | ||
| journal_io.h | ||
| journal_reclaim.c | ||
| journal_reclaim.h | ||
| journal_sb.c | ||
| journal_sb.h | ||
| journal_seq_blacklist.c | ||
| journal_seq_blacklist.h | ||
| journal_types.h | ||
| Kconfig | ||
| keylist.c | ||
| keylist.h | ||
| keylist_types.h | ||
| logged_ops.c | ||
| logged_ops.h | ||
| lru.c | ||
| lru.h | ||
| Makefile | ||
| mean_and_variance.c | ||
| mean_and_variance.h | ||
| mean_and_variance_test.c | ||
| migrate.c | ||
| migrate.h | ||
| move.c | ||
| move.h | ||
| move_types.h | ||
| movinggc.c | ||
| movinggc.h | ||
| nocow_locking.c | ||
| nocow_locking.h | ||
| nocow_locking_types.h | ||
| opts.c | ||
| opts.h | ||
| printbuf.c | ||
| printbuf.h | ||
| quota.c | ||
| quota.h | ||
| quota_types.h | ||
| rebalance.c | ||
| rebalance.h | ||
| rebalance_types.h | ||
| recovery.c | ||
| recovery.h | ||
| recovery_types.h | ||
| reflink.c | ||
| reflink.h | ||
| replicas.c | ||
| replicas.h | ||
| replicas_types.h | ||
| sb-clean.c | ||
| sb-clean.h | ||
| sb-errors.c | ||
| sb-errors.h | ||
| sb-errors_types.h | ||
| sb-members.c | ||
| sb-members.h | ||
| seqmutex.h | ||
| siphash.c | ||
| siphash.h | ||
| six.c | ||
| six.h | ||
| snapshot.c | ||
| snapshot.h | ||
| str_hash.h | ||
| subvolume.c | ||
| subvolume.h | ||
| subvolume_types.h | ||
| super-io.c | ||
| super-io.h | ||
| super.c | ||
| super.h | ||
| super_types.h | ||
| sysfs.c | ||
| sysfs.h | ||
| tests.c | ||
| tests.h | ||
| trace.c | ||
| trace.h | ||
| two_state_shared_lock.c | ||
| two_state_shared_lock.h | ||
| util.c | ||
| util.h | ||
| varint.c | ||
| varint.h | ||
| vstructs.h | ||
| xattr.c | ||
| xattr.h | ||