mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
![Robert Jarzmik](/assets/img/avatar_default.png)
On lubbock board, the probe of the driver crashes by dereferencing very early a platform_data structure which is not set, in pxa2xx_configure_sockets(). The stack fixed is : [ 0.244353] SA1111 Microprocessor Companion Chip: silicon revision 1, metal revision 1 [ 0.256321] sa1111 sa1111: Providing IRQ336-390 [ 0.340899] clocksource: Switched to clocksource oscr0 [ 0.472263] Unable to handle kernel NULL pointer dereference at virtual address 00000004 [ 0.480469] pgd = c0004000 [ 0.483432] [00000004] *pgd=00000000 [ 0.487105] Internal error: Oops: f5 [#1] ARM [ 0.491497] Modules linked in: [ 0.494650] CPU: 0 PID: 1 Comm: swapper Not tainted 4.8.0-rc3-00080-g1aaa68426f0c-dirty #2068 [ 0.503229] Hardware name: Intel DBPXA250 Development Platform (aka Lubbock) [ 0.510344] task: c3e42000 task.stack: c3e44000 [ 0.514984] PC is at pxa2xx_configure_sockets+0x4/0x24 (drivers/pcmcia/pxa2xx_base.c:227) [ 0.520193] LR is at pcmcia_lubbock_init+0x1c/0x38 [ 0.525079] pc : [<c0247c30>] lr : [<c02479b0>] psr: a0000053 [ 0.525079] sp : c3e45e70 ip : 100019ff fp : 00000000 [ 0.536651] r10: c0828900 r9 : c0434838 r8 : 00000000 [ 0.541953] r7 : c0820700 r6 : c0857b30 r5 : c3ec1400 r4 : c0820758 [ 0.548549] r3 : 00000000 r2 : 0000000c r1 : c3c09c40 r0 : c3ec1400 [ 0.555154] Flags: NzCv IRQs on FIQs off Mode SVC_32 ISA ARM Segment none [ 0.562450] Control: 0000397f Table: a0004000 DAC: 00000053 [ 0.568257] Process swapper (pid: 1, stack limit = 0xc3e44190) [ 0.574154] Stack: (0xc3e45e70 to 0xc3e46000) [ 0.578610] 5e60: c4849800 00000000 c3ec1400 c024769c [ 0.586928] 5e80: 00000000 c3ec140c c3c0ee0c c3ec1400 c3ec1434 c020c410 c3ec1400 c3ec1434 [ 0.595244] 5ea0: c0820700 c080b408 c0828900 c020c5f8 00000000 c0820700 c020c578 c020ac5c [ 0.603560] 5ec0: c3e687cc c3e71e10 c0820700 00000000 c3c02de0 c020bae4 c03c62f7 c03c62f7 [ 0.611872] 5ee0: c3e68780 c0820700 c042e034 00000000 c043c440 c020cdec c080b408 00000005 [ 0.620188] 5f00: c042e034 c00096c0 c0034440 c01c730c 20000053 ffffffff 00000000 00000000 [ 0.628502] 5f20: 00000000 c3ffcb87 c3ffcb90 c00346ac c3e66ba0 c03f7914 00000092 00000005 [ 0.636811] 5f40: 00000005 c03f847c 00000091 c03f847c 00000000 00000005 c0434828 00000005 [ 0.645125] 5f60: c043482c 00000092 c043c440 c0828900 c0434838 c0418d2c 00000005 00000005 [ 0.653430] 5f80: 00000000 c041858c 00000000 c032e9f0 00000000 00000000 00000000 00000000 [ 0.661729] 5fa0: 00000000 c032e9f8 00000000 c000f0f0 00000000 00000000 00000000 00000000 [ 0.670020] 5fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 0.678311] 5fe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 0.686673] (pxa2xx_configure_sockets) from pcmcia_lubbock_init (/drivers/pcmcia/sa1111_lubbock.c:161) [ 0.696026] (pcmcia_lubbock_init) from pcmcia_probe (/drivers/pcmcia/sa1111_generic.c:213) [ 0.704358] (pcmcia_probe) from driver_probe_device (/drivers/base/dd.c:378 /drivers/base/dd.c:499) [ 0.712848] (driver_probe_device) from __driver_attach (/./include/linux/device.h:983 /drivers/base/dd.c:733) [ 0.721414] (__driver_attach) from bus_for_each_dev (/drivers/base/bus.c:313) [ 0.729723] (bus_for_each_dev) from bus_add_driver (/drivers/base/bus.c:708) [ 0.738036] (bus_add_driver) from driver_register (/drivers/base/driver.c:169) [ 0.746185] (driver_register) from do_one_initcall (/init/main.c:778) [ 0.754561] (do_one_initcall) from kernel_init_freeable (/init/main.c:843 /init/main.c:851 /init/main.c:869 /init/main.c:1016) [ 0.763409] (kernel_init_freeable) from kernel_init (/init/main.c:944) [ 0.771660] (kernel_init) from ret_from_fork (/arch/arm/kernel/entry-common.S:119) [ 0.779347] Code: c03c6305 c03c631e c03c632e e5903048 (e993000c) All code ======== 0: c03c6305 eorsgt r6, ip, r5, lsl #6 4: c03c631e eorsgt r6, ip, lr, lsl r3 8: c03c632e eorsgt r6, ip, lr, lsr #6 c: e5903048 ldr r3, [r0, #72] ; 0x48 10:* e993000c ldmib r3, {r2, r3} <-- trapping instruction Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
230 lines
5 KiB
C
230 lines
5 KiB
C
/*
|
|
* linux/drivers/pcmcia/pxa2xx_lubbock.c
|
|
*
|
|
* Author: George Davis
|
|
* Created: Jan 10, 2002
|
|
* Copyright: MontaVista Software Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* Originally based upon linux/drivers/pcmcia/sa1100_neponset.c
|
|
*
|
|
* Lubbock PCMCIA specific routines.
|
|
*
|
|
*/
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/device.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/init.h>
|
|
#include <linux/delay.h>
|
|
|
|
#include <mach/hardware.h>
|
|
#include <asm/hardware/sa1111.h>
|
|
#include <asm/mach-types.h>
|
|
#include <mach/lubbock.h>
|
|
|
|
#include "sa1111_generic.h"
|
|
|
|
static int
|
|
lubbock_pcmcia_configure_socket(struct soc_pcmcia_socket *skt,
|
|
const socket_state_t *state)
|
|
{
|
|
struct sa1111_pcmcia_socket *s = to_skt(skt);
|
|
unsigned int pa_dwr_mask, pa_dwr_set, misc_mask, misc_set;
|
|
int ret = 0;
|
|
|
|
pa_dwr_mask = pa_dwr_set = misc_mask = misc_set = 0;
|
|
|
|
/* Lubbock uses the Maxim MAX1602, with the following connections:
|
|
*
|
|
* Socket 0 (PCMCIA):
|
|
* MAX1602 Lubbock Register
|
|
* Pin Signal
|
|
* ----- ------- ----------------------
|
|
* A0VPP S0_PWR0 SA-1111 GPIO A<0>
|
|
* A1VPP S0_PWR1 SA-1111 GPIO A<1>
|
|
* A0VCC S0_PWR2 SA-1111 GPIO A<2>
|
|
* A1VCC S0_PWR3 SA-1111 GPIO A<3>
|
|
* VX VCC
|
|
* VY +3.3V
|
|
* 12IN +12V
|
|
* CODE +3.3V Cirrus Code, CODE = High (VY)
|
|
*
|
|
* Socket 1 (CF):
|
|
* MAX1602 Lubbock Register
|
|
* Pin Signal
|
|
* ----- ------- ----------------------
|
|
* A0VPP GND VPP is not connected
|
|
* A1VPP GND VPP is not connected
|
|
* A0VCC S1_PWR0 MISC_WR<14>
|
|
* A1VCC S1_PWR1 MISC_WR<15>
|
|
* VX VCC
|
|
* VY +3.3V
|
|
* 12IN GND VPP is not connected
|
|
* CODE +3.3V Cirrus Code, CODE = High (VY)
|
|
*
|
|
*/
|
|
|
|
again:
|
|
switch (skt->nr) {
|
|
case 0:
|
|
pa_dwr_mask = GPIO_A0 | GPIO_A1 | GPIO_A2 | GPIO_A3;
|
|
|
|
switch (state->Vcc) {
|
|
case 0: /* Hi-Z */
|
|
break;
|
|
|
|
case 33: /* VY */
|
|
pa_dwr_set |= GPIO_A3;
|
|
break;
|
|
|
|
case 50: /* VX */
|
|
pa_dwr_set |= GPIO_A2;
|
|
break;
|
|
|
|
default:
|
|
printk(KERN_ERR "%s(): unrecognized Vcc %u\n",
|
|
__func__, state->Vcc);
|
|
ret = -1;
|
|
}
|
|
|
|
switch (state->Vpp) {
|
|
case 0: /* Hi-Z */
|
|
break;
|
|
|
|
case 120: /* 12IN */
|
|
pa_dwr_set |= GPIO_A1;
|
|
break;
|
|
|
|
default: /* VCC */
|
|
if (state->Vpp == state->Vcc)
|
|
pa_dwr_set |= GPIO_A0;
|
|
else {
|
|
printk(KERN_ERR "%s(): unrecognized Vpp %u\n",
|
|
__func__, state->Vpp);
|
|
ret = -1;
|
|
break;
|
|
}
|
|
}
|
|
break;
|
|
|
|
case 1:
|
|
misc_mask = (1 << 15) | (1 << 14);
|
|
|
|
switch (state->Vcc) {
|
|
case 0: /* Hi-Z */
|
|
break;
|
|
|
|
case 33: /* VY */
|
|
misc_set |= 1 << 15;
|
|
break;
|
|
|
|
case 50: /* VX */
|
|
misc_set |= 1 << 14;
|
|
break;
|
|
|
|
default:
|
|
printk(KERN_ERR "%s(): unrecognized Vcc %u\n",
|
|
__func__, state->Vcc);
|
|
ret = -1;
|
|
break;
|
|
}
|
|
|
|
if (state->Vpp != state->Vcc && state->Vpp != 0) {
|
|
printk(KERN_ERR "%s(): CF slot cannot support Vpp %u\n",
|
|
__func__, state->Vpp);
|
|
ret = -1;
|
|
break;
|
|
}
|
|
break;
|
|
|
|
default:
|
|
ret = -1;
|
|
}
|
|
|
|
if (ret == 0)
|
|
ret = sa1111_pcmcia_configure_socket(skt, state);
|
|
|
|
if (ret == 0) {
|
|
lubbock_set_misc_wr(misc_mask, misc_set);
|
|
sa1111_set_io(s->dev, pa_dwr_mask, pa_dwr_set);
|
|
}
|
|
|
|
#if 1
|
|
if (ret == 0 && state->Vcc == 33) {
|
|
struct pcmcia_state new_state;
|
|
|
|
/*
|
|
* HACK ALERT:
|
|
* We can't sense the voltage properly on Lubbock before
|
|
* actually applying some power to the socket (catch 22).
|
|
* Resense the socket Voltage Sense pins after applying
|
|
* socket power.
|
|
*
|
|
* Note: It takes about 2.5ms for the MAX1602 VCC output
|
|
* to rise.
|
|
*/
|
|
mdelay(3);
|
|
|
|
sa1111_pcmcia_socket_state(skt, &new_state);
|
|
|
|
if (!new_state.vs_3v && !new_state.vs_Xv) {
|
|
/*
|
|
* Switch to 5V, Configure socket with 5V voltage
|
|
*/
|
|
lubbock_set_misc_wr(misc_mask, 0);
|
|
sa1111_set_io(s->dev, pa_dwr_mask, 0);
|
|
|
|
/*
|
|
* It takes about 100ms to turn off Vcc.
|
|
*/
|
|
mdelay(100);
|
|
|
|
/*
|
|
* We need to hack around the const qualifier as
|
|
* well to keep this ugly workaround localized and
|
|
* not force it to the rest of the code. Barf bags
|
|
* available in the seat pocket in front of you!
|
|
*/
|
|
((socket_state_t *)state)->Vcc = 50;
|
|
((socket_state_t *)state)->Vpp = 50;
|
|
goto again;
|
|
}
|
|
}
|
|
#endif
|
|
|
|
return ret;
|
|
}
|
|
|
|
static struct pcmcia_low_level lubbock_pcmcia_ops = {
|
|
.owner = THIS_MODULE,
|
|
.configure_socket = lubbock_pcmcia_configure_socket,
|
|
.first = 0,
|
|
.nr = 2,
|
|
};
|
|
|
|
#include "pxa2xx_base.h"
|
|
|
|
int pcmcia_lubbock_init(struct sa1111_dev *sadev)
|
|
{
|
|
/*
|
|
* Set GPIO_A<3:0> to be outputs for the MAX1600,
|
|
* and switch to standby mode.
|
|
*/
|
|
sa1111_set_io_dir(sadev, GPIO_A0|GPIO_A1|GPIO_A2|GPIO_A3, 0, 0);
|
|
sa1111_set_io(sadev, GPIO_A0|GPIO_A1|GPIO_A2|GPIO_A3, 0);
|
|
sa1111_set_sleep_io(sadev, GPIO_A0|GPIO_A1|GPIO_A2|GPIO_A3, 0);
|
|
|
|
/* Set CF Socket 1 power to standby mode. */
|
|
lubbock_set_misc_wr((1 << 15) | (1 << 14), 0);
|
|
|
|
pxa2xx_drv_pcmcia_ops(&lubbock_pcmcia_ops);
|
|
pxa2xx_configure_sockets(&sadev->dev, &lubbock_pcmcia_ops);
|
|
return sa1111_pcmcia_add(sadev, &lubbock_pcmcia_ops,
|
|
pxa2xx_drv_pcmcia_add_one);
|
|
}
|
|
|
|
MODULE_LICENSE("GPL");
|