mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
259b93b21a
Probing of regulators can be a slow operation and can contribute to slower boot times. This is especially true if a regulator is turned on at probe time (with regulator-boot-on or regulator-always-on) and the regulator requires delays (off-on-time, ramp time, etc). While the overall kernel is not ready to switch to async probe by default, as per the discussion on the mailing lists [1] it is believed that the regulator subsystem is in good shape and we can move regulator drivers over wholesale. There is no way to just magically opt in all regulators (regulators are just normal drivers like platform_driver), so we set PROBE_PREFER_ASYNCHRONOUS for all regulators found in 'drivers/regulator' individually. Given the number of drivers touched and the impossibility to test this ahead of time, it wouldn't be shocking at all if this caused a regression for someone. If there is a regression caused by this patch, it's likely to be one of the cases talked about in [1]. As a "quick fix", drivers involved in the regression could be fixed by changing them to PROBE_FORCE_SYNCHRONOUS. That being said, the correct fix would be to directly fix the problem that caused the issue with async probe. The approach here follows a similar approach that was used for the mmc subsystem several years ago [2]. In fact, I ran nearly the same python script to auto-generate the changes. The only thing I changed was to search for "i2c_driver", "spmi_driver", and "spi_driver" in addition to "platform_driver". [1] https://lore.kernel.org/r/06db017f-e985-4434-8d1d-02ca2100cca0@sirena.org.uk [2] https://lore.kernel.org/r/20200903232441.2694866-1-dianders@chromium.org/ Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20230316125351.1.I2a4677392a38db5758dee0788b2cea5872562a82@changeid Signed-off-by: Mark Brown <broonie@kernel.org>
124 lines
3.7 KiB
C
124 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/* NXP PCF50633 PMIC Driver
|
|
*
|
|
* (C) 2006-2008 by Openmoko, Inc.
|
|
* Author: Balaji Rao <balajirrao@openmoko.org>
|
|
* All rights reserved.
|
|
*
|
|
* Broken down from monstrous PCF50633 driver mainly by
|
|
* Harald Welte and Andy Green and Werner Almesberger
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/device.h>
|
|
#include <linux/err.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <linux/mfd/pcf50633/core.h>
|
|
#include <linux/mfd/pcf50633/pmic.h>
|
|
|
|
#define PCF50633_REGULATOR(_name, _id, _min_uV, _uV_step, _min_sel, _n) \
|
|
{ \
|
|
.name = _name, \
|
|
.id = PCF50633_REGULATOR_##_id, \
|
|
.ops = &pcf50633_regulator_ops, \
|
|
.n_voltages = _n, \
|
|
.min_uV = _min_uV, \
|
|
.uV_step = _uV_step, \
|
|
.linear_min_sel = _min_sel, \
|
|
.type = REGULATOR_VOLTAGE, \
|
|
.owner = THIS_MODULE, \
|
|
.vsel_reg = PCF50633_REG_##_id##OUT, \
|
|
.vsel_mask = 0xff, \
|
|
.enable_reg = PCF50633_REG_##_id##OUT + 1, \
|
|
.enable_mask = PCF50633_REGULATOR_ON, \
|
|
}
|
|
|
|
static const struct regulator_ops pcf50633_regulator_ops = {
|
|
.set_voltage_sel = regulator_set_voltage_sel_regmap,
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
|
.list_voltage = regulator_list_voltage_linear,
|
|
.map_voltage = regulator_map_voltage_linear,
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
};
|
|
|
|
static const struct regulator_desc regulators[] = {
|
|
[PCF50633_REGULATOR_AUTO] =
|
|
PCF50633_REGULATOR("auto", AUTO, 1800000, 25000, 0x2f, 128),
|
|
[PCF50633_REGULATOR_DOWN1] =
|
|
PCF50633_REGULATOR("down1", DOWN1, 625000, 25000, 0, 96),
|
|
[PCF50633_REGULATOR_DOWN2] =
|
|
PCF50633_REGULATOR("down2", DOWN2, 625000, 25000, 0, 96),
|
|
[PCF50633_REGULATOR_LDO1] =
|
|
PCF50633_REGULATOR("ldo1", LDO1, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_LDO2] =
|
|
PCF50633_REGULATOR("ldo2", LDO2, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_LDO3] =
|
|
PCF50633_REGULATOR("ldo3", LDO3, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_LDO4] =
|
|
PCF50633_REGULATOR("ldo4", LDO4, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_LDO5] =
|
|
PCF50633_REGULATOR("ldo5", LDO5, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_LDO6] =
|
|
PCF50633_REGULATOR("ldo6", LDO6, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_HCLDO] =
|
|
PCF50633_REGULATOR("hcldo", HCLDO, 900000, 100000, 0, 28),
|
|
[PCF50633_REGULATOR_MEMLDO] =
|
|
PCF50633_REGULATOR("memldo", MEMLDO, 900000, 100000, 0, 28),
|
|
};
|
|
|
|
static int pcf50633_regulator_probe(struct platform_device *pdev)
|
|
{
|
|
struct regulator_dev *rdev;
|
|
struct pcf50633 *pcf;
|
|
struct regulator_config config = { };
|
|
|
|
/* Already set by core driver */
|
|
pcf = dev_to_pcf50633(pdev->dev.parent);
|
|
|
|
config.dev = &pdev->dev;
|
|
config.init_data = dev_get_platdata(&pdev->dev);
|
|
config.driver_data = pcf;
|
|
config.regmap = pcf->regmap;
|
|
|
|
rdev = devm_regulator_register(&pdev->dev, ®ulators[pdev->id],
|
|
&config);
|
|
if (IS_ERR(rdev))
|
|
return PTR_ERR(rdev);
|
|
|
|
platform_set_drvdata(pdev, rdev);
|
|
|
|
if (pcf->pdata->regulator_registered)
|
|
pcf->pdata->regulator_registered(pcf, pdev->id);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver pcf50633_regulator_driver = {
|
|
.driver = {
|
|
.name = "pcf50633-regulator",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
},
|
|
.probe = pcf50633_regulator_probe,
|
|
};
|
|
|
|
static int __init pcf50633_regulator_init(void)
|
|
{
|
|
return platform_driver_register(&pcf50633_regulator_driver);
|
|
}
|
|
subsys_initcall(pcf50633_regulator_init);
|
|
|
|
static void __exit pcf50633_regulator_exit(void)
|
|
{
|
|
platform_driver_unregister(&pcf50633_regulator_driver);
|
|
}
|
|
module_exit(pcf50633_regulator_exit);
|
|
|
|
MODULE_AUTHOR("Balaji Rao <balajirrao@openmoko.org>");
|
|
MODULE_DESCRIPTION("PCF50633 regulator driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:pcf50633-regulator");
|