mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 16:37:50 +00:00
13247018d6
If the initiator suddenly stops sending data during a login while keeping the TCP connection open, the login_work won't be scheduled and will never release the login semaphore; concurrent login operations will therefore get stuck and fail. The bug is due to the inability of the login timeout code to properly handle this particular case. Fix the problem by replacing the old per-NP login timer with a new per-connection timer. The timer is started when an initiator connects to the target; if it expires, it sends a SIGINT signal to the thread pointed at by the conn->login_kworker pointer. conn->login_kworker is set by calling the iscsit_set_login_timer_kworker() helper, initially it will point to the np thread; When the login operation's control is in the process of being passed from the NP-thread to login_work, the conn->login_worker pointer is set to NULL. Finally, login_kworker will be changed to point to the worker thread executing the login_work job. If conn->login_kworker is NULL when the timer expires, it means that the login operation hasn't been completed yet but login_work isn't running, in this case the timer will mark the login process as failed and will schedule login_work so the latter will be forced to free the resources it holds. Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Link: https://lore.kernel.org/r/20230508162219.1731964-2-mlombard@redhat.com Reviewed-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
76 lines
4.5 KiB
C
76 lines
4.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef ISCSI_TARGET_UTIL_H
|
|
#define ISCSI_TARGET_UTIL_H
|
|
|
|
#include <linux/types.h>
|
|
#include <scsi/iscsi_proto.h> /* itt_t */
|
|
|
|
#define MARKER_SIZE 8
|
|
|
|
struct iscsit_cmd;
|
|
struct iscsit_conn;
|
|
struct iscsi_conn_recovery;
|
|
struct iscsit_session;
|
|
|
|
extern int iscsit_add_r2t_to_list(struct iscsit_cmd *, u32, u32, int, u32);
|
|
extern struct iscsi_r2t *iscsit_get_r2t_for_eos(struct iscsit_cmd *, u32, u32);
|
|
extern struct iscsi_r2t *iscsit_get_r2t_from_list(struct iscsit_cmd *);
|
|
extern void iscsit_free_r2t(struct iscsi_r2t *, struct iscsit_cmd *);
|
|
extern void iscsit_free_r2ts_from_list(struct iscsit_cmd *);
|
|
extern struct iscsit_cmd *iscsit_alloc_cmd(struct iscsit_conn *, gfp_t);
|
|
extern struct iscsit_cmd *iscsit_allocate_cmd(struct iscsit_conn *, int);
|
|
extern struct iscsi_seq *iscsit_get_seq_holder_for_datain(struct iscsit_cmd *, u32);
|
|
extern struct iscsi_seq *iscsit_get_seq_holder_for_r2t(struct iscsit_cmd *);
|
|
extern struct iscsi_r2t *iscsit_get_holder_for_r2tsn(struct iscsit_cmd *, u32);
|
|
extern int iscsit_sequence_cmd(struct iscsit_conn *conn, struct iscsit_cmd *cmd,
|
|
unsigned char * ,__be32 cmdsn);
|
|
extern int iscsit_check_unsolicited_dataout(struct iscsit_cmd *, unsigned char *);
|
|
extern struct iscsit_cmd *iscsit_find_cmd_from_itt_or_dump(struct iscsit_conn *,
|
|
itt_t, u32);
|
|
extern struct iscsit_cmd *iscsit_find_cmd_from_ttt(struct iscsit_conn *, u32);
|
|
extern int iscsit_find_cmd_for_recovery(struct iscsit_session *, struct iscsit_cmd **,
|
|
struct iscsi_conn_recovery **, itt_t);
|
|
extern void iscsit_add_cmd_to_immediate_queue(struct iscsit_cmd *, struct iscsit_conn *, u8);
|
|
extern struct iscsi_queue_req *iscsit_get_cmd_from_immediate_queue(struct iscsit_conn *);
|
|
extern int iscsit_add_cmd_to_response_queue(struct iscsit_cmd *, struct iscsit_conn *, u8);
|
|
extern struct iscsi_queue_req *iscsit_get_cmd_from_response_queue(struct iscsit_conn *);
|
|
extern void iscsit_remove_cmd_from_tx_queues(struct iscsit_cmd *, struct iscsit_conn *);
|
|
extern bool iscsit_conn_all_queues_empty(struct iscsit_conn *);
|
|
extern void iscsit_free_queue_reqs_for_conn(struct iscsit_conn *);
|
|
extern void iscsit_release_cmd(struct iscsit_cmd *);
|
|
extern void __iscsit_free_cmd(struct iscsit_cmd *, bool);
|
|
extern void iscsit_free_cmd(struct iscsit_cmd *, bool);
|
|
extern bool iscsit_check_session_usage_count(struct iscsit_session *sess, bool can_sleep);
|
|
extern void iscsit_dec_session_usage_count(struct iscsit_session *);
|
|
extern void iscsit_inc_session_usage_count(struct iscsit_session *);
|
|
extern struct iscsit_conn *iscsit_get_conn_from_cid(struct iscsit_session *, u16);
|
|
extern struct iscsit_conn *iscsit_get_conn_from_cid_rcfr(struct iscsit_session *, u16);
|
|
extern void iscsit_check_conn_usage_count(struct iscsit_conn *);
|
|
extern void iscsit_dec_conn_usage_count(struct iscsit_conn *);
|
|
extern void iscsit_inc_conn_usage_count(struct iscsit_conn *);
|
|
extern void iscsit_handle_nopin_response_timeout(struct timer_list *t);
|
|
extern void iscsit_mod_nopin_response_timer(struct iscsit_conn *);
|
|
extern void iscsit_start_nopin_response_timer(struct iscsit_conn *);
|
|
extern void iscsit_stop_nopin_response_timer(struct iscsit_conn *);
|
|
extern void iscsit_handle_nopin_timeout(struct timer_list *t);
|
|
extern void __iscsit_start_nopin_timer(struct iscsit_conn *);
|
|
extern void iscsit_start_nopin_timer(struct iscsit_conn *);
|
|
extern void iscsit_stop_nopin_timer(struct iscsit_conn *);
|
|
extern void iscsit_login_timeout(struct timer_list *t);
|
|
extern void iscsit_start_login_timer(struct iscsit_conn *, struct task_struct *kthr);
|
|
extern void iscsit_stop_login_timer(struct iscsit_conn *);
|
|
extern int iscsit_set_login_timer_kworker(struct iscsit_conn *, struct task_struct *kthr);
|
|
extern int iscsit_send_tx_data(struct iscsit_cmd *, struct iscsit_conn *, int);
|
|
extern int iscsit_fe_sendpage_sg(struct iscsit_cmd *, struct iscsit_conn *);
|
|
extern int iscsit_tx_login_rsp(struct iscsit_conn *, u8, u8);
|
|
extern void iscsit_print_session_params(struct iscsit_session *);
|
|
extern int iscsit_print_dev_to_proc(char *, char **, off_t, int);
|
|
extern int iscsit_print_sessions_to_proc(char *, char **, off_t, int);
|
|
extern int iscsit_print_tpg_to_proc(char *, char **, off_t, int);
|
|
extern int rx_data(struct iscsit_conn *, struct kvec *, int, int);
|
|
extern int tx_data(struct iscsit_conn *, struct kvec *, int, int);
|
|
extern void iscsit_collect_login_stats(struct iscsit_conn *, u8, u8);
|
|
extern struct iscsi_tiqn *iscsit_snmp_get_tiqn(struct iscsit_conn *);
|
|
extern void iscsit_fill_cxn_timeout_err_stats(struct iscsit_session *);
|
|
|
|
#endif /*** ISCSI_TARGET_UTIL_H ***/
|