Eric Dumazet 55caf900e1 net: add vlan_get_protocol_and_depth() helper ... [ Upstream commit 4063384ef7 ] Before blamed commit, pskb_may_pull() was used instead of skb_header_pointer() in __vlan_get_protocol() and friends. Few callers depended on skb->head being populated with MAC header, syzbot caught one of them (skb_mac_gso_segment()) Add vlan_get_protocol_and_depth() to make the intent clearer and use it where sensible. This is a more generic fix than commit e9d3f80935 ("net/af_packet: make sure to pull mac header") which was dealing with a similar issue. kernel BUG at include/linux/skbuff.h:2655 ! invalid opcode: 0000 [#1] SMP KASAN CPU: 0 PID: 1441 Comm: syz-executor199 Not tainted 6.1.24-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 RIP: 0010:__skb_pull include/linux/skbuff.h:2655 [inline] RIP: 0010:skb_mac_gso_segment+0x68f/0x6a0 net/core/gro.c:136 Code: fd 48 8b 5c 24 10 44 89 6b 70 48 c7 c7 c0 ae 0d 86 44 89 e6 e8 a1 91 d0 00 48 c7 c7 00 af 0d 86 48 89 de 31 d2 e8 d1 4a e9 ff <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 55 48 89 e5 41 RSP: 0018:ffffc90001bd7520 EFLAGS: 00010286 RAX: ffffffff8469736a RBX: ffff88810f31dac0 RCX: ffff888115a18b00 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: ffffc90001bd75e8 R08: ffffffff84697183 R09: fffff5200037adf9 R10: 0000000000000000 R11: dffffc0000000001 R12: 0000000000000012 R13: 000000000000fee5 R14: 0000000000005865 R15: 000000000000fed7 FS: 000055555633f300(0000) GS:ffff8881f6a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000000 CR3: 0000000116fea000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> [<ffffffff847018dd>] __skb_gso_segment+0x32d/0x4c0 net/core/dev.c:3419 [<ffffffff8470398a>] skb_gso_segment include/linux/netdevice.h:4819 [inline] [<ffffffff8470398a>] validate_xmit_skb+0x3aa/0xee0 net/core/dev.c:3725 [<ffffffff84707042>] __dev_queue_xmit+0x1332/0x3300 net/core/dev.c:4313 [<ffffffff851a9ec7>] dev_queue_xmit+0x17/0x20 include/linux/netdevice.h:3029 [<ffffffff851b4a82>] packet_snd net/packet/af_packet.c:3111 [inline] [<ffffffff851b4a82>] packet_sendmsg+0x49d2/0x6470 net/packet/af_packet.c:3142 [<ffffffff84669a12>] sock_sendmsg_nosec net/socket.c:716 [inline] [<ffffffff84669a12>] sock_sendmsg net/socket.c:736 [inline] [<ffffffff84669a12>] __sys_sendto+0x472/0x5f0 net/socket.c:2139 [<ffffffff84669c75>] __do_sys_sendto net/socket.c:2151 [inline] [<ffffffff84669c75>] __se_sys_sendto net/socket.c:2147 [inline] [<ffffffff84669c75>] __x64_sys_sendto+0xe5/0x100 net/socket.c:2147 [<ffffffff8551d40f>] do_syscall_x64 arch/x86/entry/common.c:50 [inline] [<ffffffff8551d40f>] do_syscall_64+0x2f/0x50 arch/x86/entry/common.c:80 [<ffffffff85600087>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: 469aceddfa ("vlan: consolidate VLAN parsing code and limit max parsing depth") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Toke Høiland-Jørgensen <toke@redhat.com> Cc: Willem de Bruijn <willemb@google.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-24 17:32:32 +01:00
..
netfilter	netfilter: ebtables: fix table blob use-after-free	2023-03-11 13:55:24 +01:00
br.c	net: bridge: mst: Multiple Spanning Tree (MST) mode	2022-03-17 16:49:57 -07:00
br_arp_nd_proxy.c	net: bridge: Use netif_rx().	2022-03-04 12:02:19 +00:00
br_cfm.c	bridge: cfm: remove redundant return	2021-06-22 10:35:15 -07:00
br_cfm_netlink.c	bridge: cfm: Netlink Notifications.	2020-10-29 18:39:44 -07:00
br_device.c	bridge: move from strlcpy with unused retval to strscpy	2022-08-22 17:57:30 -07:00
br_fdb.c	rtnetlink: add extack support in fdb del handlers	2022-05-09 11:58:20 +01:00
br_forward.c	net: add vlan_get_protocol_and_depth() helper	2023-05-24 17:32:32 +01:00
br_if.c	net: bridge: assign path_cost for 2.5G and 5G link speed	2022-09-30 12:35:29 +01:00
br_input.c	net: bridge: Clear offload_fwd_mark when passing frame up bridge interface.	2022-05-19 09:20:44 +02:00
br_ioctl.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
br_mdb.c	net: bridge: allow add/remove permanent mdb entries on disabled ports	2022-06-15 09:35:21 +01:00
br_mrp.c	net: bridge: mrp: Update the Test frames for MRA	2021-06-28 15:46:10 -07:00
br_mrp_netlink.c	bridge: mrp: Use hlist_head instead of list_head for mrp	2020-11-09 16:42:12 -08:00
br_mrp_switchdev.c	bridge: mrp: Extend br_mrp_switchdev to detect better the errors	2021-02-16 14:47:46 -08:00
br_mst.c	net: bridge: mst: Add helper to query a port's MST state	2022-03-17 16:49:58 -07:00
br_multicast.c	net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled	2022-02-16 20:35:00 -08:00
br_multicast_eht.c	net: bridge: multicast: use multicast contexts instead of bridge or port	2021-07-20 05:41:19 -07:00
br_netfilter_hooks.c	netfilter: br_netfilter: fix recent physdev match breakage	2023-04-26 14:28:32 +02:00
br_netfilter_ipv6.c	netfilter: br_netfilter: Drop dst references before setting.	2022-08-31 12:12:32 +02:00
br_netlink.c	bridge: Fix flushing of dynamic FDB entries	2022-11-02 20:47:09 -07:00
br_netlink_tunnel.c	net: bridge: notify on vlan tunnel changes done via the old api	2020-07-12 15:18:24 -07:00
br_nf_core.c	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2019-12-24 22:28:54 -08:00
br_private.h	rtnetlink: add extack support in fdb del handlers	2022-05-09 11:58:20 +01:00
br_private_cfm.h	bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.	2020-10-29 18:39:43 -07:00
br_private_mcast_eht.h	net: bridge: multicast: use multicast contexts instead of bridge or port	2021-07-20 05:41:19 -07:00
br_private_mrp.h	net: bridge: mrp: Update the Test frames for MRA	2021-06-28 15:46:10 -07:00
br_private_stp.h
br_private_tunnel.h	net: bridge: change return type of br_handle_ingress_vlan_tunnel	2021-08-24 16:51:09 -07:00
br_stp.c	net: bridge: mst: Multiple Spanning Tree (MST) mode	2022-03-17 16:49:57 -07:00
br_stp_bpdu.c	net: bridge: add STP xstats	2019-12-14 20:02:36 -08:00
br_stp_if.c	net: use eth_hw_addr_set()	2021-10-02 14:18:25 +01:00
br_stp_timer.c
br_switchdev.c	net: bridge: switchdev: don't notify FDB entries with "master dynamic"	2023-04-26 14:28:35 +02:00
br_sysfs_br.c	bridge: Fix flushing of dynamic FDB entries	2022-11-02 20:47:09 -07:00
br_sysfs_if.c	bridge: move from strlcpy with unused retval to strscpy	2022-08-22 17:57:30 -07:00
br_vlan.c	bridge: switchdev: Fix memory leaks when changing VLAN protocol	2022-11-15 13:38:11 +01:00
br_vlan_options.c	net: bridge: mst: Allow changing a VLAN's MSTI	2022-03-17 16:49:57 -07:00
br_vlan_tunnel.c	net: bridge: change return type of br_handle_ingress_vlan_tunnel	2021-08-24 16:51:09 -07:00
Kconfig	bridge: cfm: Add BRIDGE_CFM to Kconfig.	2020-10-29 18:39:43 -07:00
Makefile	net: bridge: mst: Multiple Spanning Tree (MST) mode	2022-03-17 16:49:57 -07:00