mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 03:40:04 +00:00
67d7c3023a
I added $(srctree)/ to some included Makefiles in the following commits: -3204a7fb98
("kbuild: prefix $(srctree)/ to some included Makefiles") -d828563955
("kbuild: do not require sub-make for separate output tree builds") They were a preparation for removing --include-dir flag. I have never thought --include-dir useful. Rather, it _is_ harmful. For example, run the following commands: $ make -s ARCH=x86 mrproper defconfig $ make ARCH=arm O=foo dtbs make[1]: Entering directory '/tmp/linux/foo' HOSTCC scripts/basic/fixdep Error: kernelrelease not valid - run 'make prepare' to update it UPD include/config/kernel.release make[1]: Leaving directory '/tmp/linux/foo' The first command configures the source tree for x86. The next command tries to build ARM device trees in the separate foo/ directory - this must stop because the directory foo/ has not been configured yet. However, due to --include-dir=$(abs_srctree), the top Makefile includes the wrong include/config/auto.conf from the source tree and continues building. Kbuild traverses the directory tree, but of course it does not work correctly. The Error message is also pointless - 'make prepare' does not help at all for fixing the issue. This commit fixes more arch Makefile, and finally removes --include-dir from the top Makefile. There are more breakages under drivers/, but I do not volunteer to fix them all. I just moved --include-dir to drivers/Makefile. With this commit, the second command will stop with a sensible message. $ make -s ARCH=x86 mrproper defconfig $ make ARCH=arm O=foo dtbs make[1]: Entering directory '/tmp/linux/foo' SYNC include/config/auto.conf.cmd *** *** The source tree is not clean, please run 'make ARCH=arm mrproper' *** in /tmp/linux *** make[2]: *** [../Makefile:646: outputmakefile] Error 1 /tmp/linux/Makefile:770: include/config/auto.conf.cmd: No such file or directory make[1]: *** [/tmp/linux/Makefile:793: include/config/auto.conf.cmd] Error 2 make[1]: Leaving directory '/tmp/linux/foo' make: *** [Makefile:226: __sub-make] Error 2 Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
75 lines
2.6 KiB
Makefile
75 lines
2.6 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Copyright (C) 2000, 2002, 2003 Jeff Dike (jdike@karaya.com)
|
|
#
|
|
|
|
# pcap is broken in 2.5 because kbuild doesn't allow pcap.a to be linked
|
|
# in to pcap.o
|
|
|
|
slip-objs := slip_kern.o slip_user.o
|
|
slirp-objs := slirp_kern.o slirp_user.o
|
|
daemon-objs := daemon_kern.o daemon_user.o
|
|
vector-objs := vector_kern.o vector_user.o vector_transports.o
|
|
umcast-objs := umcast_kern.o umcast_user.o
|
|
net-objs := net_kern.o net_user.o
|
|
mconsole-objs := mconsole_kern.o mconsole_user.o
|
|
hostaudio-objs := hostaudio_kern.o
|
|
ubd-objs := ubd_kern.o ubd_user.o
|
|
port-objs := port_kern.o port_user.o
|
|
harddog-objs := harddog_kern.o harddog_user.o
|
|
rtc-objs := rtc_kern.o rtc_user.o
|
|
|
|
LDFLAGS_pcap.o = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libpcap.a)
|
|
|
|
LDFLAGS_vde.o = $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
|
|
|
|
targets := pcap_kern.o pcap_user.o vde_kern.o vde_user.o
|
|
|
|
$(obj)/pcap.o: $(obj)/pcap_kern.o $(obj)/pcap_user.o
|
|
$(LD) -r -dp -o $@ $^ $(ld_flags)
|
|
|
|
$(obj)/vde.o: $(obj)/vde_kern.o $(obj)/vde_user.o
|
|
$(LD) -r -dp -o $@ $^ $(ld_flags)
|
|
|
|
#XXX: The call below does not work because the flags are added before the
|
|
# object name, so nothing from the library gets linked.
|
|
#$(call if_changed,ld)
|
|
|
|
# When the above is fixed, don't forget to add this too!
|
|
#targets += $(obj)/pcap.o
|
|
|
|
obj-y := stdio_console.o fd.o chan_kern.o chan_user.o line.o
|
|
obj-$(CONFIG_SSL) += ssl.o
|
|
obj-$(CONFIG_STDERR_CONSOLE) += stderr_console.o
|
|
|
|
obj-$(CONFIG_UML_NET_SLIP) += slip.o slip_common.o
|
|
obj-$(CONFIG_UML_NET_SLIRP) += slirp.o slip_common.o
|
|
obj-$(CONFIG_UML_NET_DAEMON) += daemon.o
|
|
obj-$(CONFIG_UML_NET_VECTOR) += vector.o
|
|
obj-$(CONFIG_UML_NET_VDE) += vde.o
|
|
obj-$(CONFIG_UML_NET_MCAST) += umcast.o
|
|
obj-$(CONFIG_UML_NET_PCAP) += pcap.o
|
|
obj-$(CONFIG_UML_NET) += net.o
|
|
obj-$(CONFIG_MCONSOLE) += mconsole.o
|
|
obj-$(CONFIG_MMAPPER) += mmapper_kern.o
|
|
obj-$(CONFIG_BLK_DEV_UBD) += ubd.o
|
|
obj-$(CONFIG_HOSTAUDIO) += hostaudio.o
|
|
obj-$(CONFIG_NULL_CHAN) += null.o
|
|
obj-$(CONFIG_PORT_CHAN) += port.o
|
|
obj-$(CONFIG_PTY_CHAN) += pty.o
|
|
obj-$(CONFIG_TTY_CHAN) += tty.o
|
|
obj-$(CONFIG_XTERM_CHAN) += xterm.o xterm_kern.o
|
|
obj-$(CONFIG_UML_WATCHDOG) += harddog.o
|
|
obj-$(CONFIG_BLK_DEV_COW_COMMON) += cow_user.o
|
|
obj-$(CONFIG_UML_RANDOM) += random.o
|
|
obj-$(CONFIG_VIRTIO_UML) += virtio_uml.o
|
|
obj-$(CONFIG_UML_RTC) += rtc.o
|
|
obj-$(CONFIG_UML_PCI_OVER_VIRTIO) += virt-pci.o
|
|
|
|
# pcap_user.o must be added explicitly.
|
|
USER_OBJS := fd.o null.o pty.o tty.o xterm.o slip_common.o pcap_user.o vde_user.o vector_user.o
|
|
CFLAGS_null.o = -DDEV_NULL=$(DEV_NULL_PATH)
|
|
|
|
CFLAGS_xterm.o += '-DCONFIG_XTERM_CHAN_DEFAULT_EMULATOR="$(CONFIG_XTERM_CHAN_DEFAULT_EMULATOR)"'
|
|
|
|
include $(srctree)/arch/um/scripts/Makefile.rules
|