Eric Dumazet 9036b6342f net: read sk->sk_family once in sk_mc_loop() ... [ Upstream commit a3e0fdf71b ] syzbot is playing with IPV6_ADDRFORM quite a lot these days, and managed to hit the WARN_ON_ONCE(1) in sk_mc_loop() We have many more similar issues to fix. WARNING: CPU: 1 PID: 1593 at net/core/sock.c:782 sk_mc_loop+0x165/0x260 Modules linked in: CPU: 1 PID: 1593 Comm: kworker/1:3 Not tainted 6.1.40-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Workqueue: events_power_efficient gc_worker RIP: 0010:sk_mc_loop+0x165/0x260 net/core/sock.c:782 Code: 34 1b fd 49 81 c7 18 05 00 00 4c 89 f8 48 c1 e8 03 42 80 3c 20 00 74 08 4c 89 ff e8 25 36 6d fd 4d 8b 37 eb 13 e8 db 33 1b fd <0f> 0b b3 01 eb 34 e8 d0 33 1b fd 45 31 f6 49 83 c6 38 4c 89 f0 48 RSP: 0018:ffffc90000388530 EFLAGS: 00010246 RAX: ffffffff846d9b55 RBX: 0000000000000011 RCX: ffff88814f884980 RDX: 0000000000000102 RSI: ffffffff87ae5160 RDI: 0000000000000011 RBP: ffffc90000388550 R08: 0000000000000003 R09: ffffffff846d9a65 R10: 0000000000000002 R11: ffff88814f884980 R12: dffffc0000000000 R13: ffff88810dbee000 R14: 0000000000000010 R15: ffff888150084000 FS: 0000000000000000(0000) GS:ffff8881f6b00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000180 CR3: 000000014ee5b000 CR4: 00000000003506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <IRQ> [<ffffffff8507734f>] ip6_finish_output2+0x33f/0x1ae0 net/ipv6/ip6_output.c:83 [<ffffffff85062766>] __ip6_finish_output net/ipv6/ip6_output.c:200 [inline] [<ffffffff85062766>] ip6_finish_output+0x6c6/0xb10 net/ipv6/ip6_output.c:211 [<ffffffff85061f8c>] NF_HOOK_COND include/linux/netfilter.h:298 [inline] [<ffffffff85061f8c>] ip6_output+0x2bc/0x3d0 net/ipv6/ip6_output.c:232 [<ffffffff852071cf>] dst_output include/net/dst.h:444 [inline] [<ffffffff852071cf>] ip6_local_out+0x10f/0x140 net/ipv6/output_core.c:161 [<ffffffff83618fb4>] ipvlan_process_v6_outbound drivers/net/ipvlan/ipvlan_core.c:483 [inline] [<ffffffff83618fb4>] ipvlan_process_outbound drivers/net/ipvlan/ipvlan_core.c:529 [inline] [<ffffffff83618fb4>] ipvlan_xmit_mode_l3 drivers/net/ipvlan/ipvlan_core.c:602 [inline] [<ffffffff83618fb4>] ipvlan_queue_xmit+0x1174/0x1be0 drivers/net/ipvlan/ipvlan_core.c:677 [<ffffffff8361ddd9>] ipvlan_start_xmit+0x49/0x100 drivers/net/ipvlan/ipvlan_main.c:229 [<ffffffff84763fc0>] netdev_start_xmit include/linux/netdevice.h:4925 [inline] [<ffffffff84763fc0>] xmit_one net/core/dev.c:3644 [inline] [<ffffffff84763fc0>] dev_hard_start_xmit+0x320/0x980 net/core/dev.c:3660 [<ffffffff8494c650>] sch_direct_xmit+0x2a0/0x9c0 net/sched/sch_generic.c:342 [<ffffffff8494d883>] qdisc_restart net/sched/sch_generic.c:407 [inline] [<ffffffff8494d883>] __qdisc_run+0xb13/0x1e70 net/sched/sch_generic.c:415 [<ffffffff8478c426>] qdisc_run+0xd6/0x260 include/net/pkt_sched.h:125 [<ffffffff84796eac>] net_tx_action+0x7ac/0x940 net/core/dev.c:5247 [<ffffffff858002bd>] __do_softirq+0x2bd/0x9bd kernel/softirq.c:599 [<ffffffff814c3fe8>] invoke_softirq kernel/softirq.c:430 [inline] [<ffffffff814c3fe8>] __irq_exit_rcu+0xc8/0x170 kernel/softirq.c:683 [<ffffffff814c3f09>] irq_exit_rcu+0x9/0x20 kernel/softirq.c:695 Fixes: 7ad6848c7e ("ip: fix mc_loop checks for tunnels with multicast outer addresses") Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://lore.kernel.org/r/20230830101244.1146934-1-edumazet@google.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-09-19 12:28:01 +02:00
..
bpf_sk_storage.c	bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing	2023-08-11 12:08:12 +02:00
datagram.c	net: datagram: fix data-races in datagram_poll()	2023-05-24 17:32:32 +01:00
dev.c	net: sched: add rcu annotations around qdisc->qdisc_sleeping	2023-06-14 11:15:21 +02:00
dev.h	net: add skb_defer_max sysctl	2022-05-16 11:33:59 +01:00
dev_addr_lists.c	net: extract a few internals from netdevice.h	2022-04-07 20:32:09 -07:00
dev_addr_lists_test.c
dev_ioctl.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
drop_monitor.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
dst.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
dst_cache.c
failover.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
fib_notifier.c
fib_rules.c	fib: expand fib_rule_policy	2021-12-16 07:18:35 -08:00
filter.c	bpf: reject unhashed sockets in bpf_sk_assign	2023-09-13 09:42:31 +02:00
flow_dissector.c	net/ipv6: SKB symmetric hash should incorporate transport ports	2023-09-19 12:27:54 +02:00
flow_offload.c	flow_offload: Introduce flow_match_l2tpv3	2022-09-20 09:13:38 +02:00
gen_estimator.c
gen_stats.c	net: sched: fix misuse of qcpu->backlog in gnet_stats_add_queue_cpu	2022-08-16 19:38:20 -07:00
gro.c	skb: Do mix page pool and page referenced frags in GRO	2023-02-09 11:28:05 +01:00
gro_cells.c	net: drop the weight argument from netif_napi_add	2022-09-28 18:57:14 -07:00
hwbm.c
link_watch.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
lwt_bpf.c	lwt: Fix return values of BPF xmit ops	2023-09-13 09:42:33 +02:00
lwtunnel.c	xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available	2022-10-12 10:45:51 +02:00
Makefile	devlink: move code to a dedicated directory	2023-08-30 16:11:00 +02:00
neighbour.c	neighbour: delete neigh_lookup_nodev as not used	2023-06-21 16:01:03 +02:00
net-procfs.c	net: extract a few internals from netdevice.h	2022-04-07 20:32:09 -07:00
net-sysfs.c	net-sysfs: Convert to use sysfs_emit() APIs	2022-09-30 12:27:44 +01:00
net-sysfs.h
net-traces.c
net_namespace.c	net: fix UaF in netns ops registration error path	2023-02-01 08:34:43 +01:00
netclassid_cgroup.c	core: Variable type completion	2022-08-31 09:40:34 +01:00
netevent.c
netpoll.c	net: don't let netpoll invoke NAPI if in xmit context	2023-04-13 16:55:21 +02:00
netprio_cgroup.c
of_net.c	Revert "of: net: support NVMEM cells with MAC in text format"	2022-01-12 14:14:36 +00:00
page_pool.c	page_pool: fix inconsistency for page_pool_ring_[un]lock()	2023-06-05 09:26:20 +02:00
pktgen.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
ptp_classifier.c	ptp: Add generic PTP is_sync() function	2022-03-07 11:31:34 +00:00
request_sock.c
rtnetlink.c	rtnetlink: Reject negative ifindexes in RTM_NEWLINK	2023-08-30 16:11:04 +02:00
scm.c	scm: add user copy checks to put_cmsg()	2023-03-10 09:33:54 +01:00
secure_seq.c	tcp: Fix data-races around sysctl knobs related to SYN option.	2022-07-20 10:14:49 +01:00
selftests.c
skbuff.c	net: deal with integer overflows in kmalloc_reserve()	2023-09-19 12:27:58 +02:00
skmsg.c	bpf, sockmap: Fix bug that strp_done cannot be called	2023-08-16 18:27:26 +02:00
sock.c	net: read sk->sk_family once in sk_mc_loop()	2023-09-19 12:28:01 +02:00
sock_destructor.h
sock_diag.c	net: Don't include filter.h from net/sock.h	2021-12-29 08:48:14 -08:00
sock_map.c	bpf, sockmap: Fix map type error in sock_map_del_link	2023-08-16 18:27:26 +02:00
sock_reuseport.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-12-31 13:32:04 +01:00
stream.c	net: deal with most data-races in sk_wait_event()	2023-05-24 17:32:32 +01:00
sysctl_net_core.c	net: sysctl: remove unused variable long_max	2022-09-07 15:31:19 +01:00
timestamping.c
tso.c
utils.c	net: core: Use csum_replace_by_diff() and csum_sub() instead of opencoding	2022-02-21 11:40:44 +00:00
xdp.c	xdp: improve page_pool xdp_return performance	2022-09-26 11:28:19 -07:00