John Fastabend 90a9631cf8 bpf: sockmap update/simplify memory accounting scheme ... Instead of tracking wmem_queued and sk_mem_charge by incrementing in the verdict SK_REDIRECT paths and decrementing in the tx work path use skb_set_owner_w and sock_writeable helpers. This solves a few issues with the current code. First, in SK_REDIRECT inc on sk_wmem_queued and sk_mem_charge were being done without the peers sock lock being held. Under stress this can result in accounting errors when tx work and/or multiple verdict decisions are working on the peer psock. Additionally, this cleans up the code because we can rely on the default destructor to decrement memory accounting on kfree_skb. Also this will trigger sk_write_space when space becomes available on kfree_skb() which wasn't happening before and prevent __sk_free from being called until all in-flight packets are completed. Fixes: 174a79ff95 ("bpf: sockmap with sk redirect support") Signed-off-by: John Fastabend <john.fastabend@gmail.com> Acked-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-09-01 20:29:32 -07:00
..
arraymap.c	bpf: inline map in map lookup functions for array and htab	2017-08-19 21:56:34 -07:00
bpf_lru_list.c	bpf: lru: Lower the PERCPU_NR_SCANS from 16 to 4	2017-04-17 13:55:52 -04:00
bpf_lru_list.h	bpf: Only set node->ref = 1 if it has not been set	2017-09-01 09:57:39 -07:00
cgroup.c	bpf: BPF support for sock_ops	2017-07-01 16:15:13 -07:00
core.c	bpf: sock_map fixes for !CONFIG_BPF_SYSCALL and !STREAM_PARSER	2017-08-16 15:34:13 -07:00
devmap.c	bpf: netdev is never null in __dev_map_flush	2017-08-23 22:43:40 -07:00
hashtab.c	bpf: Only set node->ref = 1 if it has not been set	2017-09-01 09:57:39 -07:00
helpers.c	bpf: rename ARG_PTR_TO_STACK	2017-01-09 16:56:27 -05:00
inode.c	bpf: Implement show_options	2017-07-06 03:31:46 -04:00
lpm_trie.c	bpf: Allow selecting numa node during map creation	2017-08-19 21:35:43 -07:00
Makefile	bpf: sock_map fixes for !CONFIG_BPF_SYSCALL and !STREAM_PARSER	2017-08-16 15:34:13 -07:00
map_in_map.c	bpf: Add syscall lookup support for fd array and htab	2017-06-29 13:13:25 -04:00
map_in_map.h	bpf: Add syscall lookup support for fd array and htab	2017-06-29 13:13:25 -04:00
percpu_freelist.c	bpf: introduce percpu_freelist	2016-03-08 15:28:31 -05:00
percpu_freelist.h	bpf: introduce percpu_freelist	2016-03-08 15:28:31 -05:00
sockmap.c	bpf: sockmap update/simplify memory accounting scheme	2017-09-01 20:29:32 -07:00
stackmap.c	bpf: Allow selecting numa node during map creation	2017-08-19 21:35:43 -07:00
syscall.c	bpf: convert sockmap field attach_bpf_fd2 to type	2017-08-28 11:13:21 -07:00
tnum.c	bpf/verifier: track signed and unsigned min/max values	2017-08-08 17:51:34 -07:00
verifier.c	bpf/verifier: document liveness analysis	2017-08-23 22:38:08 -07:00