linux-stable/drivers/net/ethernet
Maor Dickman 90b22b9bcd net/mlx5e: Disable Rx ntuple offload for uplink representor
Rx ntuple offload is not supported in switchdev mode.
Tryng to enable it cause kernel panic.

 BUG: kernel NULL pointer dereference, address: 0000000000000008
 #PF: supervisor read access in kernel mode
 #PF: error_code(0x0000) - not-present page
 PGD 80000001065a5067 P4D 80000001065a5067 PUD 106594067 PMD 0
 Oops: 0000 [#1] SMP PTI
 CPU: 7 PID: 1089 Comm: ethtool Not tainted 5.13.0-rc7_for_upstream_min_debug_2021_06_23_16_44 #1
 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt.qemu.org 04/01/2014
 RIP: 0010:mlx5e_arfs_enable+0x70/0xd0 [mlx5_core]
 Code: 44 24 10 00 00 00 00 48 c7 44 24 18 00 00 00 00 49 63 c4 48 89 e2 44 89 e6 48 69 c0 20 08 00 00 48 89 ef 48 03 85 68 ac 00 00 <48> 8b 40 08 48 89 44 24 08 e8 d2 aa fd ff 48 83 05 82 96 18 00 01
 RSP: 0018:ffff8881047679e0 EFLAGS: 00010246
 RAX: 0000000000000000 RBX: 0000004000000000 RCX: 0000004000000000
 RDX: ffff8881047679e0 RSI: 0000000000000000 RDI: ffff888115100880
 RBP: ffff888115100880 R08: ffffffffa00f6cb0 R09: ffff888104767a18
 R10: ffff8881151000a0 R11: ffff888109479540 R12: 0000000000000000
 R13: ffff888104767bb8 R14: ffff888115100000 R15: ffff8881151000a0
 FS:  00007f41a64ab740(0000) GS:ffff8882f5dc0000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
 CR2: 0000000000000008 CR3: 0000000104cbc005 CR4: 0000000000370ea0
 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
 Call Trace:
  set_feature_arfs+0x1e/0x40 [mlx5_core]
  mlx5e_handle_feature+0x43/0xa0 [mlx5_core]
  mlx5e_set_features+0x139/0x1b0 [mlx5_core]
  __netdev_update_features+0x2b3/0xaf0
  ethnl_set_features+0x176/0x3a0
  ? __nla_parse+0x22/0x30
  genl_family_rcv_msg_doit+0xe2/0x140
  genl_rcv_msg+0xde/0x1d0
  ? features_reply_size+0xe0/0xe0
  ? genl_get_cmd+0xd0/0xd0
  netlink_rcv_skb+0x4e/0xf0
  genl_rcv+0x24/0x40
  netlink_unicast+0x1f6/0x2b0
  netlink_sendmsg+0x225/0x450
  sock_sendmsg+0x33/0x40
  __sys_sendto+0xd4/0x120
  ? __sys_recvmsg+0x4e/0x90
  ? exc_page_fault+0x219/0x740
  __x64_sys_sendto+0x25/0x30
  do_syscall_64+0x3f/0x80
  entry_SYSCALL_64_after_hwframe+0x44/0xae
 RIP: 0033:0x7f41a65b0cba
 Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb b8 0f 1f 00 f3 0f 1e fa 41 89 ca 64 8b 04 25 18 00 00 00 85 c0 75 15 b8 2c 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 76 c3 0f 1f 44 00 00 55 48 83 ec 30 44 89 4c
 RSP: 002b:00007ffd8d688358 EFLAGS: 00000246 ORIG_RAX: 000000000000002c
 RAX: ffffffffffffffda RBX: 00000000010f42a0 RCX: 00007f41a65b0cba
 RDX: 0000000000000058 RSI: 00000000010f43b0 RDI: 0000000000000003
 RBP: 000000000047ae60 R08: 00007f41a667c000 R09: 000000000000000c
 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000010f4340
 R13: 00000000010f4350 R14: 00007ffd8d688400 R15: 00000000010f42a0
 Modules linked in: mlx5_vdpa vhost_iotlb vdpa xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xt_addrtype iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 br_netfilter rpcrdma rdma_ucm ib_iser libiscsi scsi_transport_iscsi ib_umad ib_ipoib rdma_cm iw_cm ib_cm mlx5_ib ib_uverbs ib_core overlay mlx5_core ptp pps_core fuse
 CR2: 0000000000000008
 ---[ end trace c66523f2aba94b43 ]---

Fixes: 7a9fb35e8c ("net/mlx5e: Do not reload ethernet ports when changing eswitch mode")
Signed-off-by: Maor Dickman <maord@nvidia.com>
Reviewed-by: Roi Dayan <roid@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
2021-07-27 16:10:02 -07:00
..
3com
8390
actions
adaptec
aeroflex net: ethernet: aeroflex: fix UAF in greth_of_remove 2021-06-19 11:45:10 -07:00
agere
alacritech
allwinner
alteon
altera
amazon Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next 2021-06-28 15:28:03 -07:00
amd
apm
apple
aquantia net: atlantic: fix the macsec key length 2021-06-24 12:41:13 -07:00
arc
atheros atl1c: fix Mikrotik 10/25G NIC detection 2021-07-08 13:31:43 -07:00
broadcom bnxt_en: Fix static checker warning in bnxt_fw_reset_task() 2021-07-26 22:40:26 +01:00
brocade
cadence
calxeda
cavium liquidio: Fix unintentional sign extension issue on left shift of u16 2021-07-15 10:27:33 -07:00
chelsio cxgb4: fix IRQ free race during driver unload 2021-07-08 13:34:13 -07:00
cirrus
cisco
cortina
davicom
dec
dlink
emulex Revert "be2net: disable bh with spin_lock in be_process_mcc" 2021-06-25 11:44:16 -07:00
ezchip net: ethernet: ezchip: fix error handling 2021-06-19 11:46:00 -07:00
faraday
freescale dpaa2-switch: seed the buffer pool after allocating the swp 2021-07-22 05:46:57 -07:00
fujitsu
google gve: DQO: Remove incorrect prefetch 2021-07-02 12:06:17 -07:00
hisilicon net: hns3: change the method of obtaining default ptp cycle 2021-07-27 20:59:32 +01:00
huawei
i825xx
ibm ibmvnic: Remove the proper scrq flush 2021-07-21 08:57:41 -07:00
intel i40e: Fix log TC creation failure when max num of queues is exceeded 2021-07-23 07:44:48 -07:00
marvell octeontx2-af: Do NIX_RX_SW_SYNC twice 2021-07-27 11:52:11 +01:00
mediatek
mellanox net/mlx5e: Disable Rx ntuple offload for uplink representor 2021-07-27 16:10:02 -07:00
micrel net: phy: micrel: move phy reg offsets to common header 2021-06-14 12:54:43 -07:00
microchip net: sparx5: fix unmet dependencies warning 2021-07-22 00:44:32 -07:00
microsoft Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2021-06-29 15:45:27 -07:00
moxa net: moxa: fix UAF in moxart_mac_probe 2021-07-09 11:01:01 -07:00
mscc net: ocelot: fix switchdev objects synced for wrong netdev with LAG offload 2021-07-13 09:30:46 -07:00
myricom
natsemi
neterion Networking changes for 5.14. 2021-06-30 15:51:09 -07:00
netronome fallthrough fixes for Clang for 5.14-rc2 2021-07-15 13:57:31 -07:00
ni
nvidia
nxp
oki-semi
packetengines
pasemi
pensando ionic: count csum_none when offload enabled 2021-07-23 21:57:41 +01:00
qlogic net/qla3xxx: fix schedule while atomic in ql_wait_for_drvr_lock and ql_adapter_reset 2021-07-26 14:17:06 +01:00
qualcomm net: qcom/emac: fix UAF in emac_remove 2021-07-09 11:01:01 -07:00
rdc
realtek r8169: Avoid duplicate sysfs entry creation error 2021-07-21 07:54:30 -07:00
renesas ravb: Remove extra TAB 2021-07-21 22:55:59 -07:00
rocker
samsung
seeq
sfc sfc: add logs explaining XDP_TX/REDIRECT is not available 2021-07-13 10:02:41 -07:00
sgi
silan
sis
smsc
socionext netsec: Remove rcu_read_lock() around XDP program invocation 2021-06-24 19:46:12 +02:00
stmicro net: stmmac: add est_irq_status callback function for GMAC 4.10 and 5.10 2021-07-26 12:29:44 +01:00
sun NIU: fix incorrect error return, missed in previous revert 2021-07-23 17:48:52 +01:00
synopsys
tehuti
ti net: ti: fix UAF in tlan_remove_one 2021-07-09 11:01:01 -07:00
toshiba
tundra
via
wiznet
xilinx net: ll_temac: Remove left-over debug message 2021-06-21 14:44:09 -07:00
xircom
xscale net: ixp46x: fix ptp build failure 2021-07-21 09:10:24 -07:00
dnet.c
dnet.h
ec_bhf.c net: ethernet: fix potential use-after-free in ec_bhf_remove 2021-06-18 13:01:17 -07:00
ethoc.c
fealnx.c
jme.c
jme.h
Kconfig
korina.c
lantiq_etop.c
lantiq_xrx200.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2021-06-18 19:47:02 -07:00
Makefile