Stephen Smalley 923190d32d selinux: fix inode security list corruption ... sb_finish_set_opts() can race with inode_free_security() when initializing inode security structures for inodes created prior to initial policy load or by the filesystem during ->mount(). This appears to have always been a possible race, but commit 3dc91d4 ("SELinux: Fix possible NULL pointer dereference in selinux_inode_permission()") made it more evident by immediately reusing the unioned list/rcu element of the inode security structure for call_rcu() upon an inode_free_security(). But the underlying issue was already present before that commit as a possible use-after-free of isec. Shivnandan Kumar reported the list corruption and proposed a patch to split the list and rcu elements out of the union as separate fields of the inode_security_struct so that setting the rcu element would not affect the list element. However, this would merely hide the issue and not truly fix the code. This patch instead moves up the deletion of the list entry prior to dropping the sbsec->isec_lock initially. Then, if the inode is dropped subsequently, there will be no further references to the isec. Reported-by: Shivnandan Kumar <shivnandan.k@samsung.com> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov> Cc: stable@vger.kernel.org Signed-off-by: Paul Moore <pmoore@redhat.com>		2014-10-15 10:37:02 -04:00
..
include	selinux: make the netif cache namespace aware	2014-09-10 17:09:57 -04:00
ss	selinux: normalize audit log formatting	2014-09-22 17:02:10 -04:00
.gitignore	SELinux: add .gitignore files for dynamic classes	2009-10-24 09:42:27 +08:00
avc.c	selinux: Report permissive mode in avc: denied messages.	2014-06-03 14:21:48 -05:00
exports.c	selinux: sparse fix: include selinux.h in exports.c	2011-09-09 16:56:32 -07:00
hooks.c	selinux: fix inode security list corruption	2014-10-15 10:37:02 -04:00
Kconfig
Makefile	selinux: change to new flag variable	2010-10-21 10:12:40 +11:00
netif.c	selinux: make the netif cache namespace aware	2014-09-10 17:09:57 -04:00
netlabel.c	selinux: ensure that the cached NetLabel secattr matches the desired SID	2013-12-04 16:08:17 -05:00
netlink.c	selinux: replace obsolete NLMSG_* with type safe nlmsg_*	2013-03-28 14:25:49 -04:00
netnode.c	selinux: reduce the number of calls to synchronize_net() when flushing caches	2014-06-26 14:33:56 -04:00
netport.c	selinux: reduce the number of calls to synchronize_net() when flushing caches	2014-06-26 14:33:56 -04:00
nlmsgtab.c	selinux: add SOCK_DIAG_BY_FAMILY to the list of netlink message types	2014-02-05 12:20:48 -05:00
selinuxfs.c	Merge commit 'v3.14' into next	2014-04-14 11:23:14 +10:00
xfrm.c	selinux: add gfp argument to security_xfrm_policy_alloc and fix callers	2014-03-10 08:30:02 +01:00