mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-16 07:35:14 +00:00
Code Issues Releases Wiki Activity
linux-stable/sound/isa
History
Takashi Iwai b6963f63fe ALSA: sb: Fix potential ABBA deadlock in CSP driver 
commit 1c2b951915 upstream.

SB16 CSP driver may hit potentially a typical ABBA deadlock in two
code paths:

 In snd_sb_csp_stop():
     spin_lock_irqsave(&p->chip->mixer_lock, flags);
     spin_lock(&p->chip->reg_lock);

 In snd_sb_csp_load():
     spin_lock_irqsave(&p->chip->reg_lock, flags);
     spin_lock(&p->chip->mixer_lock);

Also the similar pattern is seen in snd_sb_csp_start().

Although the practical impact is very small (those states aren't
triggered in the same running state and this happens only on a real
hardware, decades old ISA sound boards -- which must be very difficult
to find nowadays), it's a real scenario and has to be fixed.

This patch addresses those deadlocks by splitting the locks in
snd_sb_csp_start() and snd_sb_csp_stop() for avoiding the nested
locks.

Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/7b0fcdaf-cd4f-4728-2eae-48c151a92e10@gmail.com
Link: https://lore.kernel.org/r/20210716132723.13216-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-07-28 11:13:49 +02:00
..
ad1816a ALSA: ad1816a: Fix sparse warning wrt PCM format type 2018-07-27 09:05:27 +02:00
ad1848
cs423x ALSA: cs4236: fix error return comparison of an unsigned integer 2020-01-09 10:19:02 +01:00
es1688 ALSA: es1688: Add the missed snd_card_free() 2020-06-22 09:05:02 +02:00
galaxy ALSA: galaxy: Mark expected switch fall-throughs 2018-08-03 12:20:58 +02:00
gus ALSA: isa: Remove empty init and exit 2018-08-03 16:11:35 +02:00
msnd ALSA: msnd: Use NULL instead of 0 2018-07-26 08:31:33 +02:00
opti9xx ALSA: opti9xx: shut up gcc-10 range warning 2020-05-06 08:13:32 +02:00
sb ALSA: sb: Fix potential ABBA deadlock in CSP driver 2021-07-28 11:13:49 +02:00
wavefront ALSA: isa/wavefront: prevent out of bounds write in ioctl 2020-06-25 15:32:48 +02:00
wss ALSA: wss: Fix invalid snd_free_pages() at error path 2018-12-05 19:32:08 +01:00
adlib.c
als100.c
azt2320.c
cmi8328.c ALSA: cmi8328: array_find() can be static 2018-04-23 08:48:54 +02:00
cmi8330.c ALSA: isa: Fix error return code in snd_cmi8330_probe() 2021-07-20 16:16:13 +02:00
es18xx.c ALSA: es18xx: mark expected switch fall-through 2018-08-03 12:21:02 +02:00
Kconfig ALSA: Fix references to Documentation/.*/MultiSound 2018-06-26 17:45:31 +02:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
opl3sa2.c
sc6000.c ALSA: sc6000: fix spelling mistake: "iomaped" -> "iomapped" 2018-05-02 16:01:15 +02:00
sscape.c