mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 17:08:10 +00:00
e09f98606d
When swapping extents, we can corrupt inodes by swapping data forks that are in incompatible formats. This is caused by the two indoes having different fork offsets due to the presence of an attribute fork on an attr2 filesystem. xfs_fsr tries to be smart about setting the fork offset, but the trick it plays only works on attr1 (old fixed format attribute fork) filesystems. Changing the way xfs_fsr sets up the attribute fork will prevent this situation from ever occurring, so in the kernel code we can get by with a preventative fix - check that the data fork in the defragmented inode is in a format valid for the inode it is being swapped into. This will lead to files that will silently and potentially repeatedly fail defragmentation, so issue a warning to the log when this particular failure occurs to let us know that xfs_fsr needs updating/fixing. To help identify how to improve xfs_fsr to avoid this issue, add trace points for the inodes being swapped so that we can determine why the swap was rejected and to confirm that the code is making the right decisions and modifications when swapping forks. A further complication is even when the swap is allowed to proceed when the fork offset is different between the two inodes then value for the maximum number of extents the data fork can hold can be wrong. Make sure these are also set correctly after the swap occurs. Signed-off-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Alex Elder <aelder@sgi.com> |
||
|---|---|---|
| .. | ||
| linux-2.6 | ||
| quota | ||
| support | ||
| Kconfig | ||
| Makefile | ||
| xfs.h | ||
| xfs_acl.h | ||
| xfs_ag.h | ||
| xfs_alloc.c | ||
| xfs_alloc.h | ||
| xfs_alloc_btree.c | ||
| xfs_alloc_btree.h | ||
| xfs_arch.h | ||
| xfs_attr.c | ||
| xfs_attr.h | ||
| xfs_attr_leaf.c | ||
| xfs_attr_leaf.h | ||
| xfs_attr_sf.h | ||
| xfs_bit.c | ||
| xfs_bit.h | ||
| xfs_bmap.c | ||
| xfs_bmap.h | ||
| xfs_bmap_btree.c | ||
| xfs_bmap_btree.h | ||
| xfs_btree.c | ||
| xfs_btree.h | ||
| xfs_btree_trace.c | ||
| xfs_btree_trace.h | ||
| xfs_buf_item.c | ||
| xfs_buf_item.h | ||
| xfs_da_btree.c | ||
| xfs_da_btree.h | ||
| xfs_dfrag.c | ||
| xfs_dfrag.h | ||
| xfs_dinode.h | ||
| xfs_dir2.c | ||
| xfs_dir2.h | ||
| xfs_dir2_block.c | ||
| xfs_dir2_block.h | ||
| xfs_dir2_data.c | ||
| xfs_dir2_data.h | ||
| xfs_dir2_leaf.c | ||
| xfs_dir2_leaf.h | ||
| xfs_dir2_node.c | ||
| xfs_dir2_node.h | ||
| xfs_dir2_sf.c | ||
| xfs_dir2_sf.h | ||
| xfs_dmapi.h | ||
| xfs_dmops.c | ||
| xfs_error.c | ||
| xfs_error.h | ||
| xfs_extfree_item.c | ||
| xfs_extfree_item.h | ||
| xfs_filestream.c | ||
| xfs_filestream.h | ||
| xfs_fs.h | ||
| xfs_fsops.c | ||
| xfs_fsops.h | ||
| xfs_ialloc.c | ||
| xfs_ialloc.h | ||
| xfs_ialloc_btree.c | ||
| xfs_ialloc_btree.h | ||
| xfs_iget.c | ||
| xfs_inode.c | ||
| xfs_inode.h | ||
| xfs_inode_item.c | ||
| xfs_inode_item.h | ||
| xfs_inum.h | ||
| xfs_iomap.c | ||
| xfs_iomap.h | ||
| xfs_itable.c | ||
| xfs_itable.h | ||
| xfs_log.c | ||
| xfs_log.h | ||
| xfs_log_priv.h | ||
| xfs_log_recover.c | ||
| xfs_log_recover.h | ||
| xfs_mount.c | ||
| xfs_mount.h | ||
| xfs_mru_cache.c | ||
| xfs_mru_cache.h | ||
| xfs_quota.h | ||
| xfs_refcache.h | ||
| xfs_rename.c | ||
| xfs_rtalloc.c | ||
| xfs_rtalloc.h | ||
| xfs_rw.c | ||
| xfs_rw.h | ||
| xfs_sb.h | ||
| xfs_trans.c | ||
| xfs_trans.h | ||
| xfs_trans_ail.c | ||
| xfs_trans_buf.c | ||
| xfs_trans_extfree.c | ||
| xfs_trans_inode.c | ||
| xfs_trans_item.c | ||
| xfs_trans_priv.h | ||
| xfs_trans_space.h | ||
| xfs_types.h | ||
| xfs_utils.c | ||
| xfs_utils.h | ||
| xfs_vnodeops.c | ||
| xfs_vnodeops.h | ||