mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 03:10:12 +00:00
![Srinivas Kandagatla](/assets/img/avatar_default.png)
running kernel with CONFIG_DEBUG_LOCKS_ALLOC enabled will below warning:
BUG: key ffff502e09807098 has not been registered!
DEBUG_LOCKS_WARN_ON(1)
WARNING: CPU: 5 PID: 129 at kernel/locking/lockdep.c:4623
lockdep_init_map_waits+0xe8/0x250
Modules linked in:
CPU: 5 PID: 129 Comm: kworker/5:1 Tainted: G
W 5.10.0-rc1-00277-ged49f224ca3f-dirty #1210
Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT)
Workqueue: events deferred_probe_work_func
pstate: 80c00005 (Nzcv daif +PAN +UAO -TCO BTYPE=--)
pc : lockdep_init_map_waits+0xe8/0x250
lr : lockdep_init_map_waits+0xe8/0x250
[ Trimmed ]
Call trace:
lockdep_init_map_waits+0xe8/0x250
__kernfs_create_file+0x78/0x180
sysfs_add_file_mode_ns+0x94/0x1c8
internal_create_group+0x110/0x3e0
sysfs_create_group+0x18/0x28
devm_device_add_group+0x4c/0xb0
add_all_attributes+0x438/0x490
sdw_slave_sysfs_dpn_init+0x128/0x138
sdw_slave_sysfs_init+0x80/0xa0
sdw_drv_probe+0x94/0x170
really_probe+0x118/0x3e0
driver_probe_device+0x5c/0xc0
[ Trimmed ]
CPU: 5 PID: 129 Comm: kworker/5:1 Tainted: G
W 5.10.0-rc1-00277-ged49f224ca3f-dirty #1210
Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT)
Workqueue: events deferred_probe_work_func
Call trace:
dump_backtrace+0x0/0x1c0
show_stack+0x18/0x68
dump_stack+0xd8/0x134
__warn+0xa0/0x158
report_bug+0xc8/0x178
bug_handler+0x20/0x78
brk_handler+0x70/0xc8
[ Trimmed ]
Fix this by initializing dynamically allocated sysfs attribute to keep lockdep happy!
Fixes: bcac590299
("soundwire: add Slave sysfs support")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20201104112941.1134-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
301 lines
7.2 KiB
C
301 lines
7.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
// Copyright(c) 2015-2020 Intel Corporation.
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/sysfs.h>
|
|
#include <linux/soundwire/sdw.h>
|
|
#include <linux/soundwire/sdw_type.h>
|
|
#include "bus.h"
|
|
#include "sysfs_local.h"
|
|
|
|
struct dpn_attribute {
|
|
struct device_attribute dev_attr;
|
|
int N;
|
|
int dir;
|
|
const char *format_string;
|
|
};
|
|
|
|
/*
|
|
* Since we can't use ARRAY_SIZE, hard-code number of dpN attributes.
|
|
* This needs to be updated when adding new attributes - an error will be
|
|
* flagged on a mismatch.
|
|
*/
|
|
#define SDW_DPN_ATTRIBUTES 15
|
|
|
|
#define sdw_dpn_attribute_alloc(field) \
|
|
static int field##_attribute_alloc(struct device *dev, \
|
|
struct attribute **res, \
|
|
int N, int dir, \
|
|
const char *format_string) \
|
|
{ \
|
|
struct dpn_attribute *dpn_attr; \
|
|
\
|
|
dpn_attr = devm_kzalloc(dev, sizeof(*dpn_attr), GFP_KERNEL); \
|
|
if (!dpn_attr) \
|
|
return -ENOMEM; \
|
|
dpn_attr->N = N; \
|
|
dpn_attr->dir = dir; \
|
|
sysfs_attr_init(&dpn_attr->dev_attr.attr); \
|
|
dpn_attr->format_string = format_string; \
|
|
dpn_attr->dev_attr.attr.name = __stringify(field); \
|
|
dpn_attr->dev_attr.attr.mode = 0444; \
|
|
dpn_attr->dev_attr.show = field##_show; \
|
|
\
|
|
*res = &dpn_attr->dev_attr.attr; \
|
|
\
|
|
return 0; \
|
|
}
|
|
|
|
#define sdw_dpn_attr(field) \
|
|
\
|
|
static ssize_t field##_dpn_show(struct sdw_slave *slave, \
|
|
int N, \
|
|
int dir, \
|
|
const char *format_string, \
|
|
char *buf) \
|
|
{ \
|
|
struct sdw_dpn_prop *dpn; \
|
|
unsigned long mask; \
|
|
int bit; \
|
|
int i; \
|
|
\
|
|
if (dir) { \
|
|
dpn = slave->prop.src_dpn_prop; \
|
|
mask = slave->prop.source_ports; \
|
|
} else { \
|
|
dpn = slave->prop.sink_dpn_prop; \
|
|
mask = slave->prop.sink_ports; \
|
|
} \
|
|
\
|
|
i = 0; \
|
|
for_each_set_bit(bit, &mask, 32) { \
|
|
if (bit == N) { \
|
|
return sprintf(buf, format_string, \
|
|
dpn[i].field); \
|
|
} \
|
|
i++; \
|
|
} \
|
|
return -EINVAL; \
|
|
} \
|
|
\
|
|
static ssize_t field##_show(struct device *dev, \
|
|
struct device_attribute *attr, \
|
|
char *buf) \
|
|
{ \
|
|
struct sdw_slave *slave = dev_to_sdw_dev(dev); \
|
|
struct dpn_attribute *dpn_attr = \
|
|
container_of(attr, struct dpn_attribute, dev_attr); \
|
|
\
|
|
return field##_dpn_show(slave, \
|
|
dpn_attr->N, dpn_attr->dir, \
|
|
dpn_attr->format_string, \
|
|
buf); \
|
|
} \
|
|
sdw_dpn_attribute_alloc(field)
|
|
|
|
sdw_dpn_attr(imp_def_interrupts);
|
|
sdw_dpn_attr(max_word);
|
|
sdw_dpn_attr(min_word);
|
|
sdw_dpn_attr(type);
|
|
sdw_dpn_attr(max_grouping);
|
|
sdw_dpn_attr(simple_ch_prep_sm);
|
|
sdw_dpn_attr(ch_prep_timeout);
|
|
sdw_dpn_attr(max_ch);
|
|
sdw_dpn_attr(min_ch);
|
|
sdw_dpn_attr(max_async_buffer);
|
|
sdw_dpn_attr(block_pack_mode);
|
|
sdw_dpn_attr(port_encoding);
|
|
|
|
#define sdw_dpn_array_attr(field) \
|
|
\
|
|
static ssize_t field##_dpn_show(struct sdw_slave *slave, \
|
|
int N, \
|
|
int dir, \
|
|
const char *format_string, \
|
|
char *buf) \
|
|
{ \
|
|
struct sdw_dpn_prop *dpn; \
|
|
unsigned long mask; \
|
|
ssize_t size = 0; \
|
|
int bit; \
|
|
int i; \
|
|
int j; \
|
|
\
|
|
if (dir) { \
|
|
dpn = slave->prop.src_dpn_prop; \
|
|
mask = slave->prop.source_ports; \
|
|
} else { \
|
|
dpn = slave->prop.sink_dpn_prop; \
|
|
mask = slave->prop.sink_ports; \
|
|
} \
|
|
\
|
|
i = 0; \
|
|
for_each_set_bit(bit, &mask, 32) { \
|
|
if (bit == N) { \
|
|
for (j = 0; j < dpn[i].num_##field; j++) \
|
|
size += sprintf(buf + size, \
|
|
format_string, \
|
|
dpn[i].field[j]); \
|
|
size += sprintf(buf + size, "\n"); \
|
|
return size; \
|
|
} \
|
|
i++; \
|
|
} \
|
|
return -EINVAL; \
|
|
} \
|
|
static ssize_t field##_show(struct device *dev, \
|
|
struct device_attribute *attr, \
|
|
char *buf) \
|
|
{ \
|
|
struct sdw_slave *slave = dev_to_sdw_dev(dev); \
|
|
struct dpn_attribute *dpn_attr = \
|
|
container_of(attr, struct dpn_attribute, dev_attr); \
|
|
\
|
|
return field##_dpn_show(slave, \
|
|
dpn_attr->N, dpn_attr->dir, \
|
|
dpn_attr->format_string, \
|
|
buf); \
|
|
} \
|
|
sdw_dpn_attribute_alloc(field)
|
|
|
|
sdw_dpn_array_attr(words);
|
|
sdw_dpn_array_attr(ch_combinations);
|
|
sdw_dpn_array_attr(channels);
|
|
|
|
static int add_all_attributes(struct device *dev, int N, int dir)
|
|
{
|
|
struct attribute **dpn_attrs;
|
|
struct attribute_group *dpn_group;
|
|
int i = 0;
|
|
int ret;
|
|
|
|
/* allocate attributes, last one is NULL */
|
|
dpn_attrs = devm_kcalloc(dev, SDW_DPN_ATTRIBUTES + 1,
|
|
sizeof(struct attribute *),
|
|
GFP_KERNEL);
|
|
if (!dpn_attrs)
|
|
return -ENOMEM;
|
|
|
|
ret = max_word_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = min_word_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = words_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = type_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = max_grouping_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = simple_ch_prep_sm_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = ch_prep_timeout_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = imp_def_interrupts_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "0x%x\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = min_ch_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = max_ch_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = channels_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = ch_combinations_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = max_async_buffer_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = block_pack_mode_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = port_encoding_attribute_alloc(dev, &dpn_attrs[i++],
|
|
N, dir, "%d\n");
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/* paranoia check for editing mistakes */
|
|
if (i != SDW_DPN_ATTRIBUTES) {
|
|
dev_err(dev, "mismatch in attributes, allocated %d got %d\n",
|
|
SDW_DPN_ATTRIBUTES, i);
|
|
return -EINVAL;
|
|
}
|
|
|
|
dpn_group = devm_kzalloc(dev, sizeof(*dpn_group), GFP_KERNEL);
|
|
if (!dpn_group)
|
|
return -ENOMEM;
|
|
|
|
dpn_group->attrs = dpn_attrs;
|
|
dpn_group->name = devm_kasprintf(dev, GFP_KERNEL, "dp%d_%s",
|
|
N, dir ? "src" : "sink");
|
|
if (!dpn_group->name)
|
|
return -ENOMEM;
|
|
|
|
ret = devm_device_add_group(dev, dpn_group);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int sdw_slave_sysfs_dpn_init(struct sdw_slave *slave)
|
|
{
|
|
unsigned long mask;
|
|
int ret;
|
|
int i;
|
|
|
|
mask = slave->prop.source_ports;
|
|
for_each_set_bit(i, &mask, 32) {
|
|
ret = add_all_attributes(&slave->dev, i, 1);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
|
|
mask = slave->prop.sink_ports;
|
|
for_each_set_bit(i, &mask, 32) {
|
|
ret = add_all_attributes(&slave->dev, i, 0);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|