mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-24 19:35:58 +00:00
259b93b21a
Probing of regulators can be a slow operation and can contribute to slower boot times. This is especially true if a regulator is turned on at probe time (with regulator-boot-on or regulator-always-on) and the regulator requires delays (off-on-time, ramp time, etc). While the overall kernel is not ready to switch to async probe by default, as per the discussion on the mailing lists [1] it is believed that the regulator subsystem is in good shape and we can move regulator drivers over wholesale. There is no way to just magically opt in all regulators (regulators are just normal drivers like platform_driver), so we set PROBE_PREFER_ASYNCHRONOUS for all regulators found in 'drivers/regulator' individually. Given the number of drivers touched and the impossibility to test this ahead of time, it wouldn't be shocking at all if this caused a regression for someone. If there is a regression caused by this patch, it's likely to be one of the cases talked about in [1]. As a "quick fix", drivers involved in the regression could be fixed by changing them to PROBE_FORCE_SYNCHRONOUS. That being said, the correct fix would be to directly fix the problem that caused the issue with async probe. The approach here follows a similar approach that was used for the mmc subsystem several years ago [2]. In fact, I ran nearly the same python script to auto-generate the changes. The only thing I changed was to search for "i2c_driver", "spmi_driver", and "spi_driver" in addition to "platform_driver". [1] https://lore.kernel.org/r/06db017f-e985-4434-8d1d-02ca2100cca0@sirena.org.uk [2] https://lore.kernel.org/r/20200903232441.2694866-1-dianders@chromium.org/ Signed-off-by: Douglas Anderson <dianders@chromium.org> Link: https://lore.kernel.org/r/20230316125351.1.I2a4677392a38db5758dee0788b2cea5872562a82@changeid Signed-off-by: Mark Brown <broonie@kernel.org>
247 lines
7.6 KiB
C
247 lines
7.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
|
|
*
|
|
* Author: Andrew F. Davis <afd@ti.com>
|
|
*
|
|
* Based on the TPS65912 driver
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/regulator/driver.h>
|
|
|
|
#include <linux/mfd/tps65086.h>
|
|
|
|
enum tps65086_regulators { BUCK1, BUCK2, BUCK3, BUCK4, BUCK5, BUCK6, LDOA1,
|
|
LDOA2, LDOA3, SWA1, SWB1, SWB2, VTT };
|
|
|
|
#define TPS65086_REGULATOR(_name, _of, _id, _nv, _vr, _vm, _er, _em, _lr, _dr, _dm) \
|
|
[_id] = { \
|
|
.desc = { \
|
|
.name = _name, \
|
|
.of_match = of_match_ptr(_of), \
|
|
.regulators_node = "regulators", \
|
|
.of_parse_cb = tps65086_of_parse_cb, \
|
|
.id = _id, \
|
|
.ops = ®_ops, \
|
|
.n_voltages = _nv, \
|
|
.type = REGULATOR_VOLTAGE, \
|
|
.owner = THIS_MODULE, \
|
|
.vsel_reg = _vr, \
|
|
.vsel_mask = _vm, \
|
|
.enable_reg = _er, \
|
|
.enable_mask = _em, \
|
|
.volt_table = NULL, \
|
|
.linear_ranges = _lr, \
|
|
.n_linear_ranges = ARRAY_SIZE(_lr), \
|
|
}, \
|
|
.decay_reg = _dr, \
|
|
.decay_mask = _dm, \
|
|
}
|
|
|
|
#define TPS65086_SWITCH(_name, _of, _id, _er, _em) \
|
|
[_id] = { \
|
|
.desc = { \
|
|
.name = _name, \
|
|
.of_match = of_match_ptr(_of), \
|
|
.regulators_node = "regulators", \
|
|
.of_parse_cb = tps65086_of_parse_cb, \
|
|
.id = _id, \
|
|
.ops = &switch_ops, \
|
|
.type = REGULATOR_VOLTAGE, \
|
|
.owner = THIS_MODULE, \
|
|
.enable_reg = _er, \
|
|
.enable_mask = _em, \
|
|
}, \
|
|
}
|
|
|
|
struct tps65086_regulator {
|
|
struct regulator_desc desc;
|
|
unsigned int decay_reg;
|
|
unsigned int decay_mask;
|
|
};
|
|
|
|
static const struct linear_range tps65086_10mv_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(0, 0x0, 0x0, 0),
|
|
REGULATOR_LINEAR_RANGE(410000, 0x1, 0x7F, 10000),
|
|
};
|
|
|
|
static const struct linear_range tps65086_buck126_25mv_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(0, 0x0, 0x0, 0),
|
|
REGULATOR_LINEAR_RANGE(1000000, 0x1, 0x18, 0),
|
|
REGULATOR_LINEAR_RANGE(1025000, 0x19, 0x7F, 25000),
|
|
};
|
|
|
|
static const struct linear_range tps65086_buck345_25mv_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(0, 0x0, 0x0, 0),
|
|
REGULATOR_LINEAR_RANGE(425000, 0x1, 0x7F, 25000),
|
|
};
|
|
|
|
static const struct linear_range tps65086_ldoa1_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(1350000, 0x0, 0x0, 0),
|
|
REGULATOR_LINEAR_RANGE(1500000, 0x1, 0x7, 100000),
|
|
REGULATOR_LINEAR_RANGE(2300000, 0x8, 0xB, 100000),
|
|
REGULATOR_LINEAR_RANGE(2850000, 0xC, 0xD, 150000),
|
|
REGULATOR_LINEAR_RANGE(3300000, 0xE, 0xE, 0),
|
|
};
|
|
|
|
static const struct linear_range tps65086_ldoa23_ranges[] = {
|
|
REGULATOR_LINEAR_RANGE(700000, 0x0, 0xD, 50000),
|
|
REGULATOR_LINEAR_RANGE(1400000, 0xE, 0xF, 100000),
|
|
};
|
|
|
|
/* Operations permitted on regulators */
|
|
static const struct regulator_ops reg_ops = {
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
.set_voltage_sel = regulator_set_voltage_sel_regmap,
|
|
.map_voltage = regulator_map_voltage_linear_range,
|
|
.get_voltage_sel = regulator_get_voltage_sel_regmap,
|
|
.list_voltage = regulator_list_voltage_linear_range,
|
|
};
|
|
|
|
/* Operations permitted on load switches */
|
|
static const struct regulator_ops switch_ops = {
|
|
.enable = regulator_enable_regmap,
|
|
.disable = regulator_disable_regmap,
|
|
.is_enabled = regulator_is_enabled_regmap,
|
|
};
|
|
|
|
static int tps65086_of_parse_cb(struct device_node *dev,
|
|
const struct regulator_desc *desc,
|
|
struct regulator_config *config);
|
|
|
|
static struct tps65086_regulator regulators[] = {
|
|
TPS65086_REGULATOR("BUCK1", "buck1", BUCK1, 0x80, TPS65086_BUCK1CTRL,
|
|
BUCK_VID_MASK, TPS65086_BUCK123CTRL, BIT(0),
|
|
tps65086_10mv_ranges, TPS65086_BUCK1CTRL,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("BUCK2", "buck2", BUCK2, 0x80, TPS65086_BUCK2CTRL,
|
|
BUCK_VID_MASK, TPS65086_BUCK123CTRL, BIT(1),
|
|
tps65086_10mv_ranges, TPS65086_BUCK2CTRL,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("BUCK3", "buck3", BUCK3, 0x80, TPS65086_BUCK3VID,
|
|
BUCK_VID_MASK, TPS65086_BUCK123CTRL, BIT(2),
|
|
tps65086_10mv_ranges, TPS65086_BUCK3DECAY,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("BUCK4", "buck4", BUCK4, 0x80, TPS65086_BUCK4VID,
|
|
BUCK_VID_MASK, TPS65086_BUCK4CTRL, BIT(0),
|
|
tps65086_10mv_ranges, TPS65086_BUCK4VID,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("BUCK5", "buck5", BUCK5, 0x80, TPS65086_BUCK5VID,
|
|
BUCK_VID_MASK, TPS65086_BUCK5CTRL, BIT(0),
|
|
tps65086_10mv_ranges, TPS65086_BUCK5CTRL,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("BUCK6", "buck6", BUCK6, 0x80, TPS65086_BUCK6VID,
|
|
BUCK_VID_MASK, TPS65086_BUCK6CTRL, BIT(0),
|
|
tps65086_10mv_ranges, TPS65086_BUCK6CTRL,
|
|
BIT(0)),
|
|
TPS65086_REGULATOR("LDOA1", "ldoa1", LDOA1, 0xF, TPS65086_LDOA1CTRL,
|
|
VDOA1_VID_MASK, TPS65086_LDOA1CTRL, BIT(0),
|
|
tps65086_ldoa1_ranges, 0, 0),
|
|
TPS65086_REGULATOR("LDOA2", "ldoa2", LDOA2, 0x10, TPS65086_LDOA2VID,
|
|
VDOA23_VID_MASK, TPS65086_LDOA2CTRL, BIT(0),
|
|
tps65086_ldoa23_ranges, 0, 0),
|
|
TPS65086_REGULATOR("LDOA3", "ldoa3", LDOA3, 0x10, TPS65086_LDOA3VID,
|
|
VDOA23_VID_MASK, TPS65086_LDOA3CTRL, BIT(0),
|
|
tps65086_ldoa23_ranges, 0, 0),
|
|
TPS65086_SWITCH("SWA1", "swa1", SWA1, TPS65086_SWVTT_EN, BIT(5)),
|
|
TPS65086_SWITCH("SWB1", "swb1", SWB1, TPS65086_SWVTT_EN, BIT(6)),
|
|
TPS65086_SWITCH("SWB2", "swb2", SWB2, TPS65086_SWVTT_EN, BIT(7)),
|
|
TPS65086_SWITCH("VTT", "vtt", VTT, TPS65086_SWVTT_EN, BIT(4)),
|
|
};
|
|
|
|
static int tps65086_of_parse_cb(struct device_node *node,
|
|
const struct regulator_desc *desc,
|
|
struct regulator_config *config)
|
|
{
|
|
int ret;
|
|
|
|
/* Check for 25mV step mode */
|
|
if (of_property_read_bool(node, "ti,regulator-step-size-25mv")) {
|
|
switch (desc->id) {
|
|
case BUCK1:
|
|
case BUCK2:
|
|
case BUCK6:
|
|
regulators[desc->id].desc.linear_ranges =
|
|
tps65086_buck126_25mv_ranges;
|
|
regulators[desc->id].desc.n_linear_ranges =
|
|
ARRAY_SIZE(tps65086_buck126_25mv_ranges);
|
|
break;
|
|
case BUCK3:
|
|
case BUCK4:
|
|
case BUCK5:
|
|
regulators[desc->id].desc.linear_ranges =
|
|
tps65086_buck345_25mv_ranges;
|
|
regulators[desc->id].desc.n_linear_ranges =
|
|
ARRAY_SIZE(tps65086_buck345_25mv_ranges);
|
|
break;
|
|
default:
|
|
dev_warn(config->dev, "25mV step mode only valid for BUCK regulators\n");
|
|
}
|
|
}
|
|
|
|
/* Check for decay mode */
|
|
if (desc->id <= BUCK6 && of_property_read_bool(node, "ti,regulator-decay")) {
|
|
ret = regmap_write_bits(config->regmap,
|
|
regulators[desc->id].decay_reg,
|
|
regulators[desc->id].decay_mask,
|
|
regulators[desc->id].decay_mask);
|
|
if (ret) {
|
|
dev_err(config->dev, "Error setting decay\n");
|
|
return ret;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int tps65086_regulator_probe(struct platform_device *pdev)
|
|
{
|
|
struct tps65086 *tps = dev_get_drvdata(pdev->dev.parent);
|
|
struct regulator_config config = { };
|
|
struct regulator_dev *rdev;
|
|
int i;
|
|
|
|
platform_set_drvdata(pdev, tps);
|
|
|
|
config.dev = &pdev->dev;
|
|
config.dev->of_node = tps->dev->of_node;
|
|
config.driver_data = tps;
|
|
config.regmap = tps->regmap;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(regulators); i++) {
|
|
rdev = devm_regulator_register(&pdev->dev, ®ulators[i].desc,
|
|
&config);
|
|
if (IS_ERR(rdev)) {
|
|
dev_err(tps->dev, "failed to register %s regulator\n",
|
|
pdev->name);
|
|
return PTR_ERR(rdev);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct platform_device_id tps65086_regulator_id_table[] = {
|
|
{ "tps65086-regulator", },
|
|
{ /* sentinel */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(platform, tps65086_regulator_id_table);
|
|
|
|
static struct platform_driver tps65086_regulator_driver = {
|
|
.driver = {
|
|
.name = "tps65086-regulator",
|
|
.probe_type = PROBE_PREFER_ASYNCHRONOUS,
|
|
},
|
|
.probe = tps65086_regulator_probe,
|
|
.id_table = tps65086_regulator_id_table,
|
|
};
|
|
module_platform_driver(tps65086_regulator_driver);
|
|
|
|
MODULE_AUTHOR("Andrew F. Davis <afd@ti.com>");
|
|
MODULE_DESCRIPTION("TPS65086 Regulator driver");
|
|
MODULE_LICENSE("GPL v2");
|