Mike Christie 0b4ea5b72b scsi: qedi: Fix ABBA deadlock in qedi_process_tmf_resp() and qedi_process_cmd_cleanup_resp() ... commit f10f582d28 upstream. This fixes a deadlock added with commit b40f3894e3 ("scsi: qedi: Complete TMF works before disconnect") Bug description from Jia-Ju Bai: qedi_process_tmf_resp() spin_lock(&session->back_lock); --> Line 201 (Lock A) spin_lock(&qedi_conn->tmf_work_lock); --> Line 230 (Lock B) qedi_process_cmd_cleanup_resp() spin_lock_bh(&qedi_conn->tmf_work_lock); --> Line 752 (Lock B) spin_lock_bh(&conn->session->back_lock); --> Line 784 (Lock A) When qedi_process_tmf_resp() and qedi_process_cmd_cleanup_resp() are concurrently executed, the deadlock can occur. This patch fixes the deadlock by not holding the tmf_work_lock in qedi_process_cmd_cleanup_resp while holding the back_lock. The tmf_work_lock is only needed while we remove the tmf_work from the work_list. Link: https://lore.kernel.org/r/20220208185448.6206-1-michael.christie@oracle.com Fixes: b40f3894e3 ("scsi: qedi: Complete TMF works before disconnect") Cc: Manish Rangankar <mrangankar@marvell.com> Cc: Nilesh Javali <njavali@marvell.com> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn> Reported-by: Jia-Ju Bai <baijiaju1990@gmail.com> Signed-off-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2022-02-23 12:03:22 +01:00
..
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile
qedi.h	scsi: qedi: Fix cleanup session block/unblock use	2021-06-02 01:28:23 -04:00
qedi_dbg.c
qedi_dbg.h
qedi_debugfs.c
qedi_fw.c	scsi: qedi: Fix ABBA deadlock in qedi_process_tmf_resp() and qedi_process_cmd_cleanup_resp()	2022-02-23 12:03:22 +01:00
qedi_fw_api.c
qedi_fw_iscsi.h
qedi_fw_scsi.h
qedi_gbl.h	scsi: qedi: Fix host removal with running sessions	2021-06-09 23:06:57 -04:00
qedi_hsi.h
qedi_iscsi.c	scsi: qedi: Add support for fastpath doorbell recovery	2021-08-11 22:44:36 -04:00
qedi_iscsi.h	scsi: qedi: Add support for fastpath doorbell recovery	2021-08-11 22:44:36 -04:00
qedi_main.c	scsi: qedi: Fix error codes in qedi_alloc_global_queues()	2021-08-16 13:27:57 -04:00
qedi_nvm_iscsi_cfg.h
qedi_sysfs.c	scsi: qedi: Use DEVICE_ATTR_RO() macro	2021-06-22 23:00:01 -04:00
qedi_version.h