mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-27 12:57:53 +00:00
Code Issues Releases Wiki Activity
linux-stable/kernel/power
History
Hongchen Zhang 4d4bf19c81 PM: hibernate: Enforce ordering during image compression/decompression 
commit 71cd7e80cf upstream.

An S4 (suspend to disk) test on the LoongArch 3A6000 platform sometimes
fails with the following error messaged in the dmesg log:

	Invalid LZO compressed length

That happens because when compressing/decompressing the image, the
synchronization between the control thread and the compress/decompress/crc
thread is based on a relaxed ordering interface, which is unreliable, and the
following situation may occur:

CPU 0					CPU 1
save_image_lzo				lzo_compress_threadfn
					  atomic_set(&d->stop, 1);
  atomic_read(&data[thr].stop)
  data[thr].cmp = data[thr].cmp_len;
	  				  WRITE data[thr].cmp_len

Then CPU0 gets a stale cmp_len and writes it to disk. During resume from S4,
wrong cmp_len is loaded.

To maintain data consistency between the two threads, use the acquire/release
variants of atomic set and read operations.

Fixes: 081a9d043c ("PM / Hibernate: Improve performance of LZO/plain hibernation, checksum image")
Cc: All applicable <stable@vger.kernel.org>
Signed-off-by: Hongchen Zhang <zhanghongchen@loongson.cn>
Co-developed-by: Weihao Li <liweihao@loongson.cn>
Signed-off-by: Weihao Li <liweihao@loongson.cn>
[ rjw: Subject rewrite and changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-02-23 08:54:23 +01:00
..
autosleep.c PM: sleep: fix typos in comments 2021-04-08 19:37:21 +02:00
console.c
energy_model.c PM: EM: fix memory leak with using debugfs_lookup() 2023-03-10 09:39:51 +01:00
hibernate.c PM: hibernate: Allow hybrid sleep to work with s2idle 2022-11-03 23:59:17 +09:00
Kconfig PM: sleep: remove trailing spaces and tabs 2021-06-11 18:49:09 +02:00
main.c PM: s2idle: ACPI: Fix wakeup interrupts handling 2022-02-16 12:56:19 +01:00
Makefile
power.h kernel/power: allow hibernation with page_poison sanity checking 2020-12-15 12:13:46 -08:00
poweroff.c
process.c workqueue: Introduce show_one_worker_pool and show_one_workqueue. 2023-05-11 23:00:35 +09:00
qos.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
snapshot.c PM: hibernate: Clean up sync_read handling in snapshot_write_next() 2023-11-28 16:56:29 +00:00
suspend.c PM: s2idle: ACPI: Fix wakeup interrupts handling 2022-02-16 12:56:19 +01:00
suspend_test.c PM: suspend: fix return value of __setup handler 2022-04-08 14:23:07 +02:00
swap.c PM: hibernate: Enforce ordering during image compression/decompression 2024-02-23 08:54:23 +01:00
user.c PM: hibernate: defer device probing when resuming from hibernation 2022-08-17 14:23:04 +02:00
wakelock.c PM: wakeup: simplify the output logic of pm_show_wakelocks() 2022-02-01 17:27:00 +01:00