Eric Dumazet 95b3904a26 net: prevent mss overflow in skb_segment() ... [ Upstream commit 23d05d563b ] Once again syzbot is able to crash the kernel in skb_segment() [1] GSO_BY_FRAGS is a forbidden value, but unfortunately the following computation in skb_segment() can reach it quite easily : mss = mss * partial_segs; 65535 = 3 * 5 * 17 * 257, so many initial values of mss can lead to a bad final result. Make sure to limit segmentation so that the new mss value is smaller than GSO_BY_FRAGS. [1] general protection fault, probably for non-canonical address 0xdffffc000000000e: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000070-0x0000000000000077] CPU: 1 PID: 5079 Comm: syz-executor993 Not tainted 6.7.0-rc4-syzkaller-00141-g1ae4cd3cbdd0 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 RIP: 0010:skb_segment+0x181d/0x3f30 net/core/skbuff.c:4551 Code: 83 e3 02 e9 fb ed ff ff e8 90 68 1c f9 48 8b 84 24 f8 00 00 00 48 8d 78 70 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 8a 21 00 00 48 8b 84 24 f8 00 RSP: 0018:ffffc900043473d0 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: 0000000000010046 RCX: ffffffff886b1597 RDX: 000000000000000e RSI: ffffffff886b2520 RDI: 0000000000000070 RBP: ffffc90004347578 R08: 0000000000000005 R09: 000000000000ffff R10: 000000000000ffff R11: 0000000000000002 R12: ffff888063202ac0 R13: 0000000000010000 R14: 000000000000ffff R15: 0000000000000046 FS: 0000555556e7e380(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020010000 CR3: 0000000027ee2000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> udp6_ufo_fragment+0xa0e/0xd00 net/ipv6/udp_offload.c:109 ipv6_gso_segment+0x534/0x17e0 net/ipv6/ip6_offload.c:120 skb_mac_gso_segment+0x290/0x610 net/core/gso.c:53 __skb_gso_segment+0x339/0x710 net/core/gso.c:124 skb_gso_segment include/net/gso.h:83 [inline] validate_xmit_skb+0x36c/0xeb0 net/core/dev.c:3626 __dev_queue_xmit+0x6f3/0x3d60 net/core/dev.c:4338 dev_queue_xmit include/linux/netdevice.h:3134 [inline] packet_xmit+0x257/0x380 net/packet/af_packet.c:276 packet_snd net/packet/af_packet.c:3087 [inline] packet_sendmsg+0x24c6/0x5220 net/packet/af_packet.c:3119 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0xd5/0x180 net/socket.c:745 __sys_sendto+0x255/0x340 net/socket.c:2190 __do_sys_sendto net/socket.c:2202 [inline] __se_sys_sendto net/socket.c:2198 [inline] __x64_sys_sendto+0xe0/0x1b0 net/socket.c:2198 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f8692032aa9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 d1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fff8d685418 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f8692032aa9 RDX: 0000000000010048 RSI: 00000000200000c0 RDI: 0000000000000003 RBP: 00000000000f4240 R08: 0000000020000540 R09: 0000000000000014 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff8d685480 R13: 0000000000000001 R14: 00007fff8d685480 R15: 0000000000000003 </TASK> Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:skb_segment+0x181d/0x3f30 net/core/skbuff.c:4551 Code: 83 e3 02 e9 fb ed ff ff e8 90 68 1c f9 48 8b 84 24 f8 00 00 00 48 8d 78 70 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e 8a 21 00 00 48 8b 84 24 f8 00 RSP: 0018:ffffc900043473d0 EFLAGS: 00010202 RAX: dffffc0000000000 RBX: 0000000000010046 RCX: ffffffff886b1597 RDX: 000000000000000e RSI: ffffffff886b2520 RDI: 0000000000000070 RBP: ffffc90004347578 R08: 0000000000000005 R09: 000000000000ffff R10: 000000000000ffff R11: 0000000000000002 R12: ffff888063202ac0 R13: 0000000000010000 R14: 000000000000ffff R15: 0000000000000046 FS: 0000555556e7e380(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020010000 CR3: 0000000027ee2000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Fixes: 3953c46c3a ("sk_buff: allow segmenting based on frag sizes") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Link: https://lore.kernel.org/r/20231212164621.4131800-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2024-01-10 17:16:59 +01:00
..
6lowpan
9p	net: 9p: avoid freeing uninit memory in p9pdu_vreadf	2024-01-01 12:42:41 +00:00
802
8021q	net: check vlan filter feature in vlan_vids_add_by_dev() and vlan_vids_del_by_dev()	2024-01-01 12:42:32 +00:00
appletalk	appletalk: Fix Use-After-Free in atalk_ioctl	2023-12-20 17:01:50 +01:00
atm	atm: Fix Use-After-Free in do_vcc_ioctl	2023-12-20 17:01:48 +01:00
ax25	ax25: Kconfig: Update link for linux-ax25.org	2023-09-18 12:56:58 +01:00
batman-adv	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-08-24 10:51:39 -07:00
bluetooth	Bluetooth: Add more enc key size check	2024-01-01 12:42:41 +00:00
bpf	bpf: Prevent inlining of bpf_fentry_test7()	2023-08-30 08:36:17 +02:00
bpfilter
bridge	netfilter: nf_conntrack_bridge: initialize err to 0	2023-11-28 17:19:52 +00:00
caif
can	can: isotp: isotp_sendmsg(): fix TX state detection and wait behavior	2023-10-06 12:54:33 +02:00
ceph	libceph: use kernel_connect()	2023-10-09 13:35:24 +02:00
core	net: prevent mss overflow in skb_segment()	2024-01-10 17:16:59 +01:00
dcb
dccp	dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.	2023-11-20 11:59:35 +01:00
devlink	devlink: Hold devlink lock on health reporter dump get	2023-10-06 15:56:46 -07:00
dns_resolver	keys, dns: Fix missing size check of V1 server-list header	2024-01-10 17:16:45 +01:00
dsa
ethernet
ethtool	ethtool: don't propagate EOPNOTSUPP from dumps	2023-12-08 08:52:23 +01:00
handshake	net/handshake: fix file ref count in handshake_nl_accept_doit()	2023-10-23 10:19:33 -07:00
hsr	hsr: Prevent use after free in prp_create_tagged_frame()	2023-11-20 11:59:34 +01:00
ieee802154	sysctl-6.6-rc1	2023-08-29 17:39:15 -07:00
ife	net: sched: ife: fix potential use-after-free	2024-01-01 12:42:30 +00:00
ipv4	tcp: derive delack_max from rto_min	2024-01-10 17:16:54 +01:00
ipv6	net/ipv6: Revert remove expired routes with a separated list of routes	2024-01-01 12:42:33 +00:00
iucv
kcm	kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().	2023-09-14 10:43:51 +02:00
key
l2tp	udp: annotate data-races around udp->encap_type	2023-11-20 11:58:56 +01:00
l3mdev
lapb
llc	llc: verify mac len before reading mac header	2023-11-20 11:59:34 +01:00
mac80211	wifi: mac80211: mesh_plink: fix matches_local logic	2024-01-01 12:42:27 +00:00
mac802154
mctp	mctp: perform route lookups under a RCU read-side lock	2023-10-10 19:43:22 -07:00
mpls
mptcp	mptcp: prevent tcp diag from closing listener subflows	2024-01-10 17:16:46 +01:00
ncsi	Revert ncsi: Propagate carrier gain/loss events to the NCSI controller	2023-11-28 17:20:10 +00:00
netfilter	netfilter: nft_immediate: drop chain reference counter on error	2024-01-10 17:16:51 +01:00
netlabel
netlink	drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group	2023-12-13 18:45:10 +01:00
netrom	netrom: Deny concurrent connect().	2023-08-28 06:58:46 +01:00
nfc	nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local	2024-01-10 17:16:48 +01:00
nsh
openvswitch	net/sched: act_ct: Always fill offloading tuple iifidx	2023-11-20 11:59:37 +01:00
packet	packet: Move reference count in packet_sock to atomic_long_t	2023-12-13 18:45:23 +01:00
phonet
psample	psample: Require 'CAP_NET_ADMIN' when joining "packets" group	2023-12-13 18:45:10 +01:00
qrtr
rds	net: prevent address rewrite in kernel_bind()	2023-10-01 19:31:29 +01:00
rfkill	net: rfkill: gpio: set GPIO direction	2024-01-01 12:42:41 +00:00
rose	net/rose: fix races in rose_kill_by_device()	2024-01-01 12:42:31 +00:00
rxrpc	rxrpc: Fix some minor issues with bundle tracing	2023-12-20 17:01:55 +01:00
sched	net: sched: em_text: fix possible memory leak in em_text_destroy()	2024-01-10 17:16:49 +01:00
sctp	sctp: update hb timer immediately after users change hb_interval	2023-10-04 17:29:58 -07:00
smc	net/smc: fix invalid link access in dumping SMC-R connections	2024-01-10 17:16:52 +01:00
strparser
sunrpc	SUNRPC: Revert 5f7fc5d69f	2024-01-01 12:42:26 +00:00
switchdev
tipc	tipc: Fix kernel-infoleak due to uninitialized TLV value	2023-11-28 17:19:51 +00:00
tls	net: tls, update curr on splice as well	2023-12-13 18:45:10 +01:00
unix	bpf, sockmap: af_unix stream sockets need to hold ref for pair sock	2023-12-08 08:52:23 +01:00
vmw_vsock	vsock/virtio: Fix unsigned integer wrap around in virtio_transport_has_space()	2023-12-20 17:01:50 +01:00
wireless	wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)	2024-01-05 15:19:44 +01:00
x25
xdp	xsk: add multi-buffer support for sockets sharing umem	2024-01-10 17:16:54 +01:00
xfrm	ipsec-2023-10-17	2023-10-17 18:21:13 -07:00
compat.c
devres.c
Kconfig
Kconfig.debug
Makefile
socket.c	net: Save and restore msg_namelen in sock_sendmsg	2024-01-10 17:16:51 +01:00
sysctl_net.c