mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-20 14:16:02 +00:00
![Scott Mayhew](/assets/img/avatar_default.png)
A generic_cred can be used to look up a unx_cred or a gss_cred, so it's not really safe to use the the generic_cred->acred->ac_flags to store the NO_CRKEY_TIMEOUT flag. A lookup for a unx_cred triggered while the KEY_EXPIRE_SOON flag is already set will cause both NO_CRKEY_TIMEOUT and KEY_EXPIRE_SOON to be set in the ac_flags, leaving the user associated with the auth_cred to be in a state where they're perpetually doing 4K NFS_FILE_SYNC writes. This can be reproduced as follows: 1. Mount two NFS filesystems, one with sec=krb5 and one with sec=sys. They do not need to be the same export, nor do they even need to be from the same NFS server. Also, v3 is fine. $ sudo mount -o v3,sec=krb5 server1:/export /mnt/krb5 $ sudo mount -o v3,sec=sys server2:/export /mnt/sys 2. As the normal user, before accessing the kerberized mount, kinit with a short lifetime (but not so short that renewing the ticket would leave you within the 4-minute window again by the time the original ticket expires), e.g. $ kinit -l 10m -r 60m 3. Do some I/O to the kerberized mount and verify that the writes are wsize, UNSTABLE: $ dd if=/dev/zero of=/mnt/krb5/file bs=1M count=1 4. Wait until you're within 4 minutes of key expiry, then do some more I/O to the kerberized mount to ensure that RPC_CRED_KEY_EXPIRE_SOON gets set. Verify that the writes are 4K, FILE_SYNC: $ dd if=/dev/zero of=/mnt/krb5/file bs=1M count=1 5. Now do some I/O to the sec=sys mount. This will cause RPC_CRED_NO_CRKEY_TIMEOUT to be set: $ dd if=/dev/zero of=/mnt/sys/file bs=1M count=1 6. Writes for that user will now be permanently 4K, FILE_SYNC for that user, regardless of which mount is being written to, until you reboot the client. Renewing the kerberos ticket (assuming it hasn't already expired) will have no effect. Grabbing a new kerberos ticket at this point will have no effect either. Move the flag to the auth->au_flags field (which is currently unused) and rename it slightly to reflect that it's no longer associated with the auth_cred->ac_flags. Add the rpc_auth to the arg list of rpcauth_cred_key_to_expire and check the au_flags there too. Finally, add the inode to the arg list of nfs_ctx_key_to_expire so we can determine the rpc_auth to pass to rpcauth_cred_key_to_expire. Signed-off-by: Scott Mayhew <smayhew@redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
145 lines
2.7 KiB
C
145 lines
2.7 KiB
C
/*
|
|
* linux/net/sunrpc/auth_null.c
|
|
*
|
|
* AUTH_NULL authentication. Really :-)
|
|
*
|
|
* Copyright (C) 1996, Olaf Kirch <okir@monad.swb.de>
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/module.h>
|
|
#include <linux/sunrpc/clnt.h>
|
|
|
|
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
|
|
# define RPCDBG_FACILITY RPCDBG_AUTH
|
|
#endif
|
|
|
|
static struct rpc_auth null_auth;
|
|
static struct rpc_cred null_cred;
|
|
|
|
static struct rpc_auth *
|
|
nul_create(struct rpc_auth_create_args *args, struct rpc_clnt *clnt)
|
|
{
|
|
atomic_inc(&null_auth.au_count);
|
|
return &null_auth;
|
|
}
|
|
|
|
static void
|
|
nul_destroy(struct rpc_auth *auth)
|
|
{
|
|
}
|
|
|
|
/*
|
|
* Lookup NULL creds for current process
|
|
*/
|
|
static struct rpc_cred *
|
|
nul_lookup_cred(struct rpc_auth *auth, struct auth_cred *acred, int flags)
|
|
{
|
|
if (flags & RPCAUTH_LOOKUP_RCU)
|
|
return &null_cred;
|
|
return get_rpccred(&null_cred);
|
|
}
|
|
|
|
/*
|
|
* Destroy cred handle.
|
|
*/
|
|
static void
|
|
nul_destroy_cred(struct rpc_cred *cred)
|
|
{
|
|
}
|
|
|
|
/*
|
|
* Match cred handle against current process
|
|
*/
|
|
static int
|
|
nul_match(struct auth_cred *acred, struct rpc_cred *cred, int taskflags)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
/*
|
|
* Marshal credential.
|
|
*/
|
|
static __be32 *
|
|
nul_marshal(struct rpc_task *task, __be32 *p)
|
|
{
|
|
*p++ = htonl(RPC_AUTH_NULL);
|
|
*p++ = 0;
|
|
*p++ = htonl(RPC_AUTH_NULL);
|
|
*p++ = 0;
|
|
|
|
return p;
|
|
}
|
|
|
|
/*
|
|
* Refresh credential. This is a no-op for AUTH_NULL
|
|
*/
|
|
static int
|
|
nul_refresh(struct rpc_task *task)
|
|
{
|
|
set_bit(RPCAUTH_CRED_UPTODATE, &task->tk_rqstp->rq_cred->cr_flags);
|
|
return 0;
|
|
}
|
|
|
|
static __be32 *
|
|
nul_validate(struct rpc_task *task, __be32 *p)
|
|
{
|
|
rpc_authflavor_t flavor;
|
|
u32 size;
|
|
|
|
flavor = ntohl(*p++);
|
|
if (flavor != RPC_AUTH_NULL) {
|
|
printk("RPC: bad verf flavor: %u\n", flavor);
|
|
return ERR_PTR(-EIO);
|
|
}
|
|
|
|
size = ntohl(*p++);
|
|
if (size != 0) {
|
|
printk("RPC: bad verf size: %u\n", size);
|
|
return ERR_PTR(-EIO);
|
|
}
|
|
|
|
return p;
|
|
}
|
|
|
|
const struct rpc_authops authnull_ops = {
|
|
.owner = THIS_MODULE,
|
|
.au_flavor = RPC_AUTH_NULL,
|
|
.au_name = "NULL",
|
|
.create = nul_create,
|
|
.destroy = nul_destroy,
|
|
.lookup_cred = nul_lookup_cred,
|
|
};
|
|
|
|
static
|
|
struct rpc_auth null_auth = {
|
|
.au_cslack = NUL_CALLSLACK,
|
|
.au_rslack = NUL_REPLYSLACK,
|
|
.au_flags = RPCAUTH_AUTH_NO_CRKEY_TIMEOUT,
|
|
.au_ops = &authnull_ops,
|
|
.au_flavor = RPC_AUTH_NULL,
|
|
.au_count = ATOMIC_INIT(0),
|
|
};
|
|
|
|
static
|
|
const struct rpc_credops null_credops = {
|
|
.cr_name = "AUTH_NULL",
|
|
.crdestroy = nul_destroy_cred,
|
|
.crbind = rpcauth_generic_bind_cred,
|
|
.crmatch = nul_match,
|
|
.crmarshal = nul_marshal,
|
|
.crrefresh = nul_refresh,
|
|
.crvalidate = nul_validate,
|
|
};
|
|
|
|
static
|
|
struct rpc_cred null_cred = {
|
|
.cr_lru = LIST_HEAD_INIT(null_cred.cr_lru),
|
|
.cr_auth = &null_auth,
|
|
.cr_ops = &null_credops,
|
|
.cr_count = ATOMIC_INIT(1),
|
|
.cr_flags = 1UL << RPCAUTH_CRED_UPTODATE,
|
|
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
|
|
.cr_magic = RPCAUTH_CRED_MAGIC,
|
|
#endif
|
|
};
|