mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-31 00:17:44 +00:00
fc7a6209d5
The driver core ignores the return value of this callback because there is only little it can do when a device disappears. This is the final bit of a long lasting cleanup quest where several buses were converted to also return void from their remove callback. Additionally some resource leaks were fixed that were caused by drivers returning an error code in the expectation that the driver won't go away. With struct bus_type::remove returning void it's prevented that newly implemented buses return an ignored error code and so don't anticipate wrong expectations for driver authors. Reviewed-by: Tom Rix <trix@redhat.com> (For fpga) Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Reviewed-by: Cornelia Huck <cohuck@redhat.com> (For drivers/s390 and drivers/vfio) Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> (For ARM, Amba and related parts) Acked-by: Mark Brown <broonie@kernel.org> Acked-by: Chen-Yu Tsai <wens@csie.org> (for sunxi-rsb) Acked-by: Pali Rohár <pali@kernel.org> Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org> (for media) Acked-by: Hans de Goede <hdegoede@redhat.com> (For drivers/platform) Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-By: Vinod Koul <vkoul@kernel.org> Acked-by: Juergen Gross <jgross@suse.com> (For xen) Acked-by: Lee Jones <lee.jones@linaro.org> (For mfd) Acked-by: Johannes Thumshirn <jth@kernel.org> (For mcb) Acked-by: Johan Hovold <johan@kernel.org> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (For slimbus) Acked-by: Kirti Wankhede <kwankhede@nvidia.com> (For vfio) Acked-by: Maximilian Luz <luzmaximilian@gmail.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> (For ulpi and typec) Acked-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com> (For ipack) Acked-by: Geoff Levand <geoff@infradead.org> (For ps3) Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com> (For thunderbolt) Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> (For intel_th) Acked-by: Dominik Brodowski <linux@dominikbrodowski.net> (For pcmcia) Acked-by: Rafael J. Wysocki <rafael@kernel.org> (For ACPI) Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> (rpmsg and apr) Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> (For intel-ish-hid) Acked-by: Dan Williams <dan.j.williams@intel.com> (For CXL, DAX, and NVDIMM) Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> (For isa) Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (For firewire) Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> (For hid) Acked-by: Thorsten Scherer <t.scherer@eckelmann.de> (For siox) Acked-by: Sven Van Asbroeck <TheSven73@gmail.com> (For anybuss) Acked-by: Ulf Hansson <ulf.hansson@linaro.org> (For MMC) Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C Acked-by: Sudeep Holla <sudeep.holla@arm.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Finn Thain <fthain@linux-m68k.org> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20210713193522.1770306-6-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
190 lines
4.4 KiB
C
190 lines
4.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* soundbus
|
|
*
|
|
* Copyright 2006 Johannes Berg <johannes@sipsolutions.net>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include "soundbus.h"
|
|
|
|
MODULE_AUTHOR("Johannes Berg <johannes@sipsolutions.net>");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Apple Soundbus");
|
|
|
|
struct soundbus_dev *soundbus_dev_get(struct soundbus_dev *dev)
|
|
{
|
|
struct device *tmp;
|
|
|
|
if (!dev)
|
|
return NULL;
|
|
tmp = get_device(&dev->ofdev.dev);
|
|
if (tmp)
|
|
return to_soundbus_device(tmp);
|
|
else
|
|
return NULL;
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_dev_get);
|
|
|
|
void soundbus_dev_put(struct soundbus_dev *dev)
|
|
{
|
|
if (dev)
|
|
put_device(&dev->ofdev.dev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_dev_put);
|
|
|
|
static int soundbus_probe(struct device *dev)
|
|
{
|
|
int error = -ENODEV;
|
|
struct soundbus_driver *drv;
|
|
struct soundbus_dev *soundbus_dev;
|
|
|
|
drv = to_soundbus_driver(dev->driver);
|
|
soundbus_dev = to_soundbus_device(dev);
|
|
|
|
if (!drv->probe)
|
|
return error;
|
|
|
|
soundbus_dev_get(soundbus_dev);
|
|
|
|
error = drv->probe(soundbus_dev);
|
|
if (error)
|
|
soundbus_dev_put(soundbus_dev);
|
|
|
|
return error;
|
|
}
|
|
|
|
|
|
static int soundbus_uevent(struct device *dev, struct kobj_uevent_env *env)
|
|
{
|
|
struct soundbus_dev * soundbus_dev;
|
|
struct platform_device * of;
|
|
const char *compat;
|
|
int retval = 0;
|
|
int cplen, seen = 0;
|
|
|
|
if (!dev)
|
|
return -ENODEV;
|
|
|
|
soundbus_dev = to_soundbus_device(dev);
|
|
if (!soundbus_dev)
|
|
return -ENODEV;
|
|
|
|
of = &soundbus_dev->ofdev;
|
|
|
|
/* stuff we want to pass to /sbin/hotplug */
|
|
retval = add_uevent_var(env, "OF_NAME=%pOFn", of->dev.of_node);
|
|
if (retval)
|
|
return retval;
|
|
|
|
retval = add_uevent_var(env, "OF_TYPE=%s", of_node_get_device_type(of->dev.of_node));
|
|
if (retval)
|
|
return retval;
|
|
|
|
/* Since the compatible field can contain pretty much anything
|
|
* it's not really legal to split it out with commas. We split it
|
|
* up using a number of environment variables instead. */
|
|
|
|
compat = of_get_property(of->dev.of_node, "compatible", &cplen);
|
|
while (compat && cplen > 0) {
|
|
int tmp = env->buflen;
|
|
retval = add_uevent_var(env, "OF_COMPATIBLE_%d=%s", seen, compat);
|
|
if (retval)
|
|
return retval;
|
|
compat += env->buflen - tmp;
|
|
cplen -= env->buflen - tmp;
|
|
seen += 1;
|
|
}
|
|
|
|
retval = add_uevent_var(env, "OF_COMPATIBLE_N=%d", seen);
|
|
if (retval)
|
|
return retval;
|
|
retval = add_uevent_var(env, "MODALIAS=%s", soundbus_dev->modalias);
|
|
|
|
return retval;
|
|
}
|
|
|
|
static void soundbus_device_remove(struct device *dev)
|
|
{
|
|
struct soundbus_dev * soundbus_dev = to_soundbus_device(dev);
|
|
struct soundbus_driver * drv = to_soundbus_driver(dev->driver);
|
|
|
|
if (dev->driver && drv->remove)
|
|
drv->remove(soundbus_dev);
|
|
soundbus_dev_put(soundbus_dev);
|
|
}
|
|
|
|
static void soundbus_device_shutdown(struct device *dev)
|
|
{
|
|
struct soundbus_dev * soundbus_dev = to_soundbus_device(dev);
|
|
struct soundbus_driver * drv = to_soundbus_driver(dev->driver);
|
|
|
|
if (dev->driver && drv->shutdown)
|
|
drv->shutdown(soundbus_dev);
|
|
}
|
|
|
|
/* soundbus_dev_attrs is declared in sysfs.c */
|
|
ATTRIBUTE_GROUPS(soundbus_dev);
|
|
static struct bus_type soundbus_bus_type = {
|
|
.name = "aoa-soundbus",
|
|
.probe = soundbus_probe,
|
|
.uevent = soundbus_uevent,
|
|
.remove = soundbus_device_remove,
|
|
.shutdown = soundbus_device_shutdown,
|
|
.dev_groups = soundbus_dev_groups,
|
|
};
|
|
|
|
int soundbus_add_one(struct soundbus_dev *dev)
|
|
{
|
|
static int devcount;
|
|
|
|
/* sanity checks */
|
|
if (!dev->attach_codec ||
|
|
!dev->ofdev.dev.of_node ||
|
|
dev->pcmname ||
|
|
dev->pcmid != -1) {
|
|
printk(KERN_ERR "soundbus: adding device failed sanity check!\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
dev_set_name(&dev->ofdev.dev, "soundbus:%x", ++devcount);
|
|
dev->ofdev.dev.bus = &soundbus_bus_type;
|
|
return of_device_register(&dev->ofdev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_add_one);
|
|
|
|
void soundbus_remove_one(struct soundbus_dev *dev)
|
|
{
|
|
of_device_unregister(&dev->ofdev);
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_remove_one);
|
|
|
|
int soundbus_register_driver(struct soundbus_driver *drv)
|
|
{
|
|
/* initialize common driver fields */
|
|
drv->driver.name = drv->name;
|
|
drv->driver.bus = &soundbus_bus_type;
|
|
|
|
/* register with core */
|
|
return driver_register(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_register_driver);
|
|
|
|
void soundbus_unregister_driver(struct soundbus_driver *drv)
|
|
{
|
|
driver_unregister(&drv->driver);
|
|
}
|
|
EXPORT_SYMBOL_GPL(soundbus_unregister_driver);
|
|
|
|
static int __init soundbus_init(void)
|
|
{
|
|
return bus_register(&soundbus_bus_type);
|
|
}
|
|
|
|
static void __exit soundbus_exit(void)
|
|
{
|
|
bus_unregister(&soundbus_bus_type);
|
|
}
|
|
|
|
subsys_initcall(soundbus_init);
|
|
module_exit(soundbus_exit);
|