linux-stable/tools/testing/selftests/net/mptcp
Matthieu Baerts (NGI0) 97633aa74d selftests: mptcp: diag: fix shellcheck warnings
shellcheck recently helped to prevent issues. It is then good to fix the
other harmless issues in order to spot "real" ones later.

Here, two categories of warnings are now ignored:

- SC2317: Command appears to be unreachable. The cleanup() function is
  invoked indirectly via the EXIT trap.

- SC2086: Double quote to prevent globbing and word splitting. This is
  recommended, but the current usage is correct and there is no need to
  do all these modifications to be compliant with this rule.

For the modifications:

  - SC2034: ksft_skip appears unused.
  - SC2046: Quote '$(get_msk_inuse)' to prevent word splitting.
  - SC2006: Use $(...) notation instead of legacy backticks `...`.

Now this script is shellcheck (0.9.0) compliant. We can easily spot new
issues.

Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240306-upstream-net-next-20240304-selftests-mptcp-shared-code-shellcheck-v2-7-bc79e6e5e6a0@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-03-07 21:06:52 -08:00
..
.gitignore
config selftests: mptcp: add missing kconfig for NF Mangle 2024-02-01 09:06:37 -08:00
diag.sh selftests: mptcp: diag: fix shellcheck warnings 2024-03-07 21:06:52 -08:00
Makefile
mptcp_connect.c
mptcp_connect.sh selftests: mptcp: more operations in ns_init/exit 2024-03-07 21:06:52 -08:00
mptcp_inq.c
mptcp_join.sh selftests: mptcp: add mptcp_lib_events helper 2024-03-07 21:06:52 -08:00
mptcp_lib.sh selftests: mptcp: add mptcp_lib_events helper 2024-03-07 21:06:52 -08:00
mptcp_sockopt.c
mptcp_sockopt.sh selftests: mptcp: more operations in ns_init/exit 2024-03-07 21:06:52 -08:00
pm_netlink.sh selftests: mptcp: more operations in ns_init/exit 2024-03-07 21:06:52 -08:00
pm_nl_ctl.c selftests: mptcp: add token for get_addr 2024-03-04 13:07:46 +00:00
settings selftests: mptcp: increase timeout to 30 min 2024-02-01 09:06:37 -08:00
simult_flows.sh selftests: mptcp: more operations in ns_init/exit 2024-03-07 21:06:52 -08:00
userspace_pm.sh selftests: mptcp: add mptcp_lib_events helper 2024-03-07 21:06:52 -08:00