Feng Tang 97640d8e2c x86/fpu: Set X86_FEATURE_OSXSAVE feature after enabling OSXSAVE in CR4 ... commit 2c66ca3949 upstream. 0-Day found a 34.6% regression in stress-ng's 'af-alg' test case, and bisected it to commit b81fac906a ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()"), which optimizes the FPU init order, and moves the CR4_OSXSAVE enabling into a later place: arch_cpu_finalize_init identify_boot_cpu identify_cpu generic_identify get_cpu_cap --> setup cpu capability ... fpu__init_cpu fpu__init_cpu_xstate cr4_set_bits(X86_CR4_OSXSAVE); As the FPU is not yet initialized the CPU capability setup fails to set X86_FEATURE_OSXSAVE. Many security module like 'camellia_aesni_avx_x86_64' depend on this feature and therefore fail to load, causing the regression. Cure this by setting X86_FEATURE_OSXSAVE feature right after OSXSAVE enabling. [ tglx: Moved it into the actual BSP FPU initialization code and added a comment ] Fixes: b81fac906a ("x86/fpu: Move FPU initialization into arch_cpu_finalize_init()") Reported-by: kernel test robot <oliver.sang@intel.com> Signed-off-by: Feng Tang <feng.tang@intel.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/lkml/202307192135.203ac24e-oliver.sang@intel.com Link: https://lore.kernel.org/lkml/20230823065747.92257-1-feng.tang@intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-08-30 16:27:26 +02:00
..
bugs.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
core.c	x86/fpu: Add kernel_fpu_begin_mask() to selectively initialize state	2021-01-27 11:47:49 +01:00
init.c	x86/fpu: Mark init functions __init	2023-08-08 19:56:35 +02:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
regset.c	x86/fpu: Limit xstate copy size in xstateregs_set()	2021-07-20 16:10:50 +02:00
signal.c	x86/fpu: Reset state for all signal restore failures	2021-06-23 14:41:29 +02:00
xstate.c	x86/fpu: Set X86_FEATURE_OSXSAVE feature after enabling OSXSAVE in CR4	2023-08-30 16:27:26 +02:00