mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
12a26c298d
divider_recalc_rate() is an helper function used by clock divider of
different types, so the structure containing the 'hw' pointer is not
always a 'struct clk_divider'
At the following line:
> div = _get_div(table, val, flags, divider->width);
in several cases, the value of 'divider->width' is garbage as the actual
structure behind this memory is not a 'struct clk_divider'
Fortunately, this width value is used by _get_val() only when
CLK_DIVIDER_MAX_AT_ZERO flag is set. This has never been the case so
far when the structure is not a 'struct clk_divider'. This is probably
why we did not notice this bug before
Fixes: afe76c8fd0 ("clk: allow a clk divider with max divisor when zero")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
146 lines
3.6 KiB
C
146 lines
3.6 KiB
C
/*
|
|
* Copyright (C) 2016 Maxime Ripard
|
|
* Maxime Ripard <maxime.ripard@free-electrons.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of
|
|
* the License, or (at your option) any later version.
|
|
*/
|
|
|
|
#include <linux/clk-provider.h>
|
|
|
|
#include "ccu_gate.h"
|
|
#include "ccu_div.h"
|
|
|
|
static unsigned long ccu_div_round_rate(struct ccu_mux_internal *mux,
|
|
struct clk_hw *parent,
|
|
unsigned long *parent_rate,
|
|
unsigned long rate,
|
|
void *data)
|
|
{
|
|
struct ccu_div *cd = data;
|
|
|
|
if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
|
|
rate *= cd->fixed_post_div;
|
|
|
|
rate = divider_round_rate_parent(&cd->common.hw, parent,
|
|
rate, parent_rate,
|
|
cd->div.table, cd->div.width,
|
|
cd->div.flags);
|
|
|
|
if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
|
|
rate /= cd->fixed_post_div;
|
|
|
|
return rate;
|
|
}
|
|
|
|
static void ccu_div_disable(struct clk_hw *hw)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_gate_helper_disable(&cd->common, cd->enable);
|
|
}
|
|
|
|
static int ccu_div_enable(struct clk_hw *hw)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_gate_helper_enable(&cd->common, cd->enable);
|
|
}
|
|
|
|
static int ccu_div_is_enabled(struct clk_hw *hw)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_gate_helper_is_enabled(&cd->common, cd->enable);
|
|
}
|
|
|
|
static unsigned long ccu_div_recalc_rate(struct clk_hw *hw,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
unsigned long val;
|
|
u32 reg;
|
|
|
|
reg = readl(cd->common.base + cd->common.reg);
|
|
val = reg >> cd->div.shift;
|
|
val &= (1 << cd->div.width) - 1;
|
|
|
|
parent_rate = ccu_mux_helper_apply_prediv(&cd->common, &cd->mux, -1,
|
|
parent_rate);
|
|
|
|
val = divider_recalc_rate(hw, parent_rate, val, cd->div.table,
|
|
cd->div.flags, cd->div.width);
|
|
|
|
if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
|
|
val /= cd->fixed_post_div;
|
|
|
|
return val;
|
|
}
|
|
|
|
static int ccu_div_determine_rate(struct clk_hw *hw,
|
|
struct clk_rate_request *req)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_mux_helper_determine_rate(&cd->common, &cd->mux,
|
|
req, ccu_div_round_rate, cd);
|
|
}
|
|
|
|
static int ccu_div_set_rate(struct clk_hw *hw, unsigned long rate,
|
|
unsigned long parent_rate)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
unsigned long flags;
|
|
unsigned long val;
|
|
u32 reg;
|
|
|
|
parent_rate = ccu_mux_helper_apply_prediv(&cd->common, &cd->mux, -1,
|
|
parent_rate);
|
|
|
|
if (cd->common.features & CCU_FEATURE_FIXED_POSTDIV)
|
|
rate *= cd->fixed_post_div;
|
|
|
|
val = divider_get_val(rate, parent_rate, cd->div.table, cd->div.width,
|
|
cd->div.flags);
|
|
|
|
spin_lock_irqsave(cd->common.lock, flags);
|
|
|
|
reg = readl(cd->common.base + cd->common.reg);
|
|
reg &= ~GENMASK(cd->div.width + cd->div.shift - 1, cd->div.shift);
|
|
|
|
writel(reg | (val << cd->div.shift),
|
|
cd->common.base + cd->common.reg);
|
|
|
|
spin_unlock_irqrestore(cd->common.lock, flags);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static u8 ccu_div_get_parent(struct clk_hw *hw)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_mux_helper_get_parent(&cd->common, &cd->mux);
|
|
}
|
|
|
|
static int ccu_div_set_parent(struct clk_hw *hw, u8 index)
|
|
{
|
|
struct ccu_div *cd = hw_to_ccu_div(hw);
|
|
|
|
return ccu_mux_helper_set_parent(&cd->common, &cd->mux, index);
|
|
}
|
|
|
|
const struct clk_ops ccu_div_ops = {
|
|
.disable = ccu_div_disable,
|
|
.enable = ccu_div_enable,
|
|
.is_enabled = ccu_div_is_enabled,
|
|
|
|
.get_parent = ccu_div_get_parent,
|
|
.set_parent = ccu_div_set_parent,
|
|
|
|
.determine_rate = ccu_div_determine_rate,
|
|
.recalc_rate = ccu_div_recalc_rate,
|
|
.set_rate = ccu_div_set_rate,
|
|
};
|