mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 15:15:47 +00:00
9b6bdbd933
There is a deadlock in rtllib_beacons_stop(), which is shown
below:
(Thread 1) | (Thread 2)
| rtllib_send_beacon()
rtllib_beacons_stop() | mod_timer()
spin_lock_irqsave() //(1) | (wait a time)
... | rtllib_send_beacon_cb()
del_timer_sync() | spin_lock_irqsave() //(2)
(wait timer to stop) | ...
We hold ieee->beacon_lock in position (1) of thread 1 and
use del_timer_sync() to wait timer to stop, but timer handler
also need ieee->beacon_lock in position (2) of thread 2.
As a result, rtllib_beacons_stop() will block forever.
This patch extracts del_timer_sync() from the protection of
spin_lock_irqsave(), which could let timer handler to obtain
the needed lock.
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Link: https://lore.kernel.org/r/20220417141641.124388-1-duoming@zju.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| rtl8192e | ||
| dot11d.c | ||
| dot11d.h | ||
| Kconfig | ||
| Makefile | ||
| rtl819x_BA.h | ||
| rtl819x_BAProc.c | ||
| rtl819x_HT.h | ||
| rtl819x_HTProc.c | ||
| rtl819x_Qos.h | ||
| rtl819x_TS.h | ||
| rtl819x_TSProc.c | ||
| rtllib.h | ||
| rtllib_crypt_ccmp.c | ||
| rtllib_crypt_tkip.c | ||
| rtllib_crypt_wep.c | ||
| rtllib_debug.h | ||
| rtllib_module.c | ||
| rtllib_rx.c | ||
| rtllib_softmac.c | ||
| rtllib_softmac_wx.c | ||
| rtllib_tx.c | ||
| rtllib_wx.c | ||
| TODO | ||