linux-stable

mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-24 03:15:59 +00:00

No description

Find a file

Baolin Wang 9bcef5973e mm: memcg: fix split queue list crash when large folio migration When running autonuma with enabling multi-size THP, I encountered the following kernel crash issue: [ 134.290216] list_del corruption. prev->next should be fffff9ad42e1c490, but was dead000000000100. (prev=fffff9ad42399890) [ 134.290877] kernel BUG at lib/list_debug.c:62! [ 134.291052] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI [ 134.291210] CPU: 56 PID: 8037 Comm: numa01 Kdump: loaded Tainted: G E 6.7.0-rc4+ #20 [ 134.291649] RIP: 0010:__list_del_entry_valid_or_report+0x97/0xb0 ...... [ 134.294252] Call Trace: [ 134.294362] <TASK> [ 134.294440] ? die+0x33/0x90 [ 134.294561] ? do_trap+0xe0/0x110 ...... [ 134.295681] ? __list_del_entry_valid_or_report+0x97/0xb0 [ 134.295842] folio_undo_large_rmappable+0x99/0x100 [ 134.296003] destroy_large_folio+0x68/0x70 [ 134.296172] migrate_folio_move+0x12e/0x260 [ 134.296264] ? __pfx_remove_migration_pte+0x10/0x10 [ 134.296389] migrate_pages_batch+0x495/0x6b0 [ 134.296523] migrate_pages+0x1d0/0x500 [ 134.296646] ? __pfx_alloc_misplaced_dst_folio+0x10/0x10 [ 134.296799] migrate_misplaced_folio+0x12d/0x2b0 [ 134.296953] do_numa_page+0x1f4/0x570 [ 134.297121] __handle_mm_fault+0x2b0/0x6c0 [ 134.297254] handle_mm_fault+0x107/0x270 [ 134.300897] do_user_addr_fault+0x167/0x680 [ 134.304561] exc_page_fault+0x65/0x140 [ 134.307919] asm_exc_page_fault+0x22/0x30 The reason for the crash is that, the commit `85ce2c517a` ("memcontrol: only transfer the memcg data for migration") removed the charging and uncharging operations of the migration folios and cleared the memcg data of the old folio. During the subsequent release process of the old large folio in destroy_large_folio(), if the large folio needs to be removed from the split queue, an incorrect split queue can be obtained (which is pgdat->deferred_split_queue) because the old folio's memcg is NULL now. This can lead to list operations being performed under the wrong split queue lock protection, resulting in a list crash as above. After the migration, the old folio is going to be freed, so we can remove it from the split queue in mem_cgroup_migrate() a bit earlier before clearing the memcg data to avoid getting incorrect split queue. [akpm@linux-foundation.org: fix comment, per Zi Yan] Link: https://lkml.kernel.org/r/61273e5e9b490682388377c20f52d19de4a80460.1703054559.git.baolin.wang@linux.alibaba.com Fixes: `85ce2c517a` ("memcontrol: only transfer the memcg data for migration") Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Nhat Pham <nphamcs@gmail.com> Reviewed-by: Yang Shi <shy828301@gmail.com> Reviewed-by: Zi Yan <ziy@nvidia.com> Cc: David Hildenbrand <david@redhat.com> Cc: "Huang, Ying" <ying.huang@intel.com> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Michal Hocko <mhocko@kernel.org> Cc: Muchun Song <muchun.song@linux.dev> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: Shakeel Butt <shakeelb@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2023-12-29 11:06:47 -08:00
arch	kexec: fix KEXEC_FILE dependencies	2023-12-20 13:46:19 -08:00
block	block-6.7-2023-12-01	2023-12-02 06:39:30 +09:00
certs
crypto	This push fixes a regression in ahash and hides the Kconfig sub-options for the jitter RNG.	2023-11-09 17:04:58 -08:00
Documentation	- Core Frameworks	2023-12-01 08:00:02 +09:00
drivers	Merge branch 'master' into mm-hotfixes-stable	2023-12-06 17:03:50 -08:00
fs	Merge branch 'master' into mm-hotfixes-stable	2023-12-06 17:03:50 -08:00
include	mm/mglru: reclaim offlined memcgs harder	2023-12-12 17:20:20 -08:00
init
io_uring	io_uring: use fget/fput consistently	2023-11-28 11:56:29 -07:00
ipc
kernel	kexec: select CRYPTO from KEXEC_FILE instead of depending on it	2023-12-20 13:46:19 -08:00
lib	maple_tree: do not preallocate nodes for slot stores	2023-12-20 13:46:19 -08:00
LICENSES
mm	mm: memcg: fix split queue list crash when large folio migration	2023-12-29 11:06:47 -08:00
net	wireless fixes:	2023-11-29 19:43:34 -08:00
rust
samples
scripts	Merge branch 'master' into mm-hotfixes-stable	2023-12-06 17:03:50 -08:00
security
sound	ALSA: hda: Disable power-save on KONTRON SinglePC	2023-11-30 16:14:21 +01:00
tools	selftests: secretmem: floor the memory size to the multiple of page_size	2023-12-20 13:46:19 -08:00
usr
virt
.clang-format
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore
.mailmap	mailmap: add an old address for Naoya Horiguchi	2023-12-20 13:46:20 -08:00
.rustfmt.toml
COPYING
CREDITS	MAINTAINERS: drop Antti Palosaari	2023-12-06 16:12:49 -08:00
Kbuild
Kconfig
MAINTAINERS	Merge branch 'master' into mm-hotfixes-stable	2023-12-06 17:03:50 -08:00
Makefile	Linux 6.7-rc4	2023-12-03 18:52:56 +09:00
README

README

Linux kernel
============

There are several guides for kernel developers and users. These guides can
be rendered in a number of formats, like HTML and PDF. Please read
Documentation/admin-guide/README.rst first.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.  The formatted documentation can also be read online at:

    https://www.kernel.org/doc/html/latest/

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.