mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-11-01 00:48:50 +00:00
9a56493f69
Switch over uts namespaces to use the newly introduced common lifetime counter. Currently every namespace type has its own lifetime counter which is stored in the specific namespace struct. The lifetime counters are used identically for all namespaces types. Namespaces may of course have additional unrelated counters and these are not altered. This introduces a common lifetime counter into struct ns_common. The ns_common struct encompasses information that all namespaces share. That should include the lifetime counter since its common for all of them. It also allows us to unify the type of the counters across all namespaces. Most of them use refcount_t but one uses atomic_t and at least one uses kref. Especially the last one doesn't make much sense since it's just a wrapper around refcount_t since 2016 and actually complicates cleanup operations by having to use container_of() to cast the correct namespace struct out of struct ns_common. Having the lifetime counter for the namespaces in one place reduces maintenance cost. Not just because after switching all namespaces over we will have removed more code than we added but also because the logic is more easily understandable and we indicate to the user that the basic lifetime requirements for all namespaces are currently identical. Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com> Reviewed-by: Kees Cook <keescook@chromium.org> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107.stgit@localhost.localdomain Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
177 lines
3.8 KiB
C
177 lines
3.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2004 IBM Corporation
|
|
*
|
|
* Author: Serge Hallyn <serue@us.ibm.com>
|
|
*/
|
|
|
|
#include <linux/export.h>
|
|
#include <linux/uts.h>
|
|
#include <linux/utsname.h>
|
|
#include <linux/err.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/cred.h>
|
|
#include <linux/user_namespace.h>
|
|
#include <linux/proc_ns.h>
|
|
#include <linux/sched/task.h>
|
|
|
|
static struct kmem_cache *uts_ns_cache __ro_after_init;
|
|
|
|
static struct ucounts *inc_uts_namespaces(struct user_namespace *ns)
|
|
{
|
|
return inc_ucount(ns, current_euid(), UCOUNT_UTS_NAMESPACES);
|
|
}
|
|
|
|
static void dec_uts_namespaces(struct ucounts *ucounts)
|
|
{
|
|
dec_ucount(ucounts, UCOUNT_UTS_NAMESPACES);
|
|
}
|
|
|
|
static struct uts_namespace *create_uts_ns(void)
|
|
{
|
|
struct uts_namespace *uts_ns;
|
|
|
|
uts_ns = kmem_cache_alloc(uts_ns_cache, GFP_KERNEL);
|
|
if (uts_ns)
|
|
refcount_set(&uts_ns->ns.count, 1);
|
|
return uts_ns;
|
|
}
|
|
|
|
/*
|
|
* Clone a new ns copying an original utsname, setting refcount to 1
|
|
* @old_ns: namespace to clone
|
|
* Return ERR_PTR(-ENOMEM) on error (failure to allocate), new ns otherwise
|
|
*/
|
|
static struct uts_namespace *clone_uts_ns(struct user_namespace *user_ns,
|
|
struct uts_namespace *old_ns)
|
|
{
|
|
struct uts_namespace *ns;
|
|
struct ucounts *ucounts;
|
|
int err;
|
|
|
|
err = -ENOSPC;
|
|
ucounts = inc_uts_namespaces(user_ns);
|
|
if (!ucounts)
|
|
goto fail;
|
|
|
|
err = -ENOMEM;
|
|
ns = create_uts_ns();
|
|
if (!ns)
|
|
goto fail_dec;
|
|
|
|
err = ns_alloc_inum(&ns->ns);
|
|
if (err)
|
|
goto fail_free;
|
|
|
|
ns->ucounts = ucounts;
|
|
ns->ns.ops = &utsns_operations;
|
|
|
|
down_read(&uts_sem);
|
|
memcpy(&ns->name, &old_ns->name, sizeof(ns->name));
|
|
ns->user_ns = get_user_ns(user_ns);
|
|
up_read(&uts_sem);
|
|
return ns;
|
|
|
|
fail_free:
|
|
kmem_cache_free(uts_ns_cache, ns);
|
|
fail_dec:
|
|
dec_uts_namespaces(ucounts);
|
|
fail:
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
/*
|
|
* Copy task tsk's utsname namespace, or clone it if flags
|
|
* specifies CLONE_NEWUTS. In latter case, changes to the
|
|
* utsname of this process won't be seen by parent, and vice
|
|
* versa.
|
|
*/
|
|
struct uts_namespace *copy_utsname(unsigned long flags,
|
|
struct user_namespace *user_ns, struct uts_namespace *old_ns)
|
|
{
|
|
struct uts_namespace *new_ns;
|
|
|
|
BUG_ON(!old_ns);
|
|
get_uts_ns(old_ns);
|
|
|
|
if (!(flags & CLONE_NEWUTS))
|
|
return old_ns;
|
|
|
|
new_ns = clone_uts_ns(user_ns, old_ns);
|
|
|
|
put_uts_ns(old_ns);
|
|
return new_ns;
|
|
}
|
|
|
|
void free_uts_ns(struct uts_namespace *ns)
|
|
{
|
|
dec_uts_namespaces(ns->ucounts);
|
|
put_user_ns(ns->user_ns);
|
|
ns_free_inum(&ns->ns);
|
|
kmem_cache_free(uts_ns_cache, ns);
|
|
}
|
|
|
|
static inline struct uts_namespace *to_uts_ns(struct ns_common *ns)
|
|
{
|
|
return container_of(ns, struct uts_namespace, ns);
|
|
}
|
|
|
|
static struct ns_common *utsns_get(struct task_struct *task)
|
|
{
|
|
struct uts_namespace *ns = NULL;
|
|
struct nsproxy *nsproxy;
|
|
|
|
task_lock(task);
|
|
nsproxy = task->nsproxy;
|
|
if (nsproxy) {
|
|
ns = nsproxy->uts_ns;
|
|
get_uts_ns(ns);
|
|
}
|
|
task_unlock(task);
|
|
|
|
return ns ? &ns->ns : NULL;
|
|
}
|
|
|
|
static void utsns_put(struct ns_common *ns)
|
|
{
|
|
put_uts_ns(to_uts_ns(ns));
|
|
}
|
|
|
|
static int utsns_install(struct nsset *nsset, struct ns_common *new)
|
|
{
|
|
struct nsproxy *nsproxy = nsset->nsproxy;
|
|
struct uts_namespace *ns = to_uts_ns(new);
|
|
|
|
if (!ns_capable(ns->user_ns, CAP_SYS_ADMIN) ||
|
|
!ns_capable(nsset->cred->user_ns, CAP_SYS_ADMIN))
|
|
return -EPERM;
|
|
|
|
get_uts_ns(ns);
|
|
put_uts_ns(nsproxy->uts_ns);
|
|
nsproxy->uts_ns = ns;
|
|
return 0;
|
|
}
|
|
|
|
static struct user_namespace *utsns_owner(struct ns_common *ns)
|
|
{
|
|
return to_uts_ns(ns)->user_ns;
|
|
}
|
|
|
|
const struct proc_ns_operations utsns_operations = {
|
|
.name = "uts",
|
|
.type = CLONE_NEWUTS,
|
|
.get = utsns_get,
|
|
.put = utsns_put,
|
|
.install = utsns_install,
|
|
.owner = utsns_owner,
|
|
};
|
|
|
|
void __init uts_ns_init(void)
|
|
{
|
|
uts_ns_cache = kmem_cache_create_usercopy(
|
|
"uts_namespace", sizeof(struct uts_namespace), 0,
|
|
SLAB_PANIC|SLAB_ACCOUNT,
|
|
offsetof(struct uts_namespace, name),
|
|
sizeof_field(struct uts_namespace, name),
|
|
NULL);
|
|
}
|