Quentin Monnet e89ef634f8 bpftool: Avoid leaking the JSON writer prepared for program metadata ... Bpftool creates a new JSON object for writing program metadata in plain text mode, regardless of metadata being present or not. Then this writer is freed if any metadata has been found and printed, but it leaks otherwise. We cannot destroy the object unconditionally, because the destructor prints an undesirable line break. Instead, make sure the writer is created only after we have found program metadata to print. Found with valgrind. Fixes: aff52e685e ("bpftool: Support dumping metadata") Signed-off-by: Quentin Monnet <quentin@isovalent.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Link: https://lore.kernel.org/bpf/20211022094743.11052-1-quentin@isovalent.com		2021-10-22 16:44:56 -07:00
..
bash-completion	tools: bpftool: Complete metrics list in "bpftool prog profile" doc	2021-07-30 15:40:28 -07:00
Documentation	tools: bpftool: Complete metrics list in "bpftool prog profile" doc	2021-07-30 15:40:28 -07:00
skeleton	tools, bpftool: Remove two unused variables.	2020-10-29 15:23:18 +01:00
.gitignore	tools/bpf: Remove bpf-helpers from bpftool docs	2021-03-04 18:39:45 -08:00
btf.c	bpftool: Switch to new btf__type_cnt API	2021-10-22 16:09:14 -07:00
btf_dumper.c	tools: Replace btf__get_from_id() with btf__load_from_kernel_by_id()	2021-07-29 17:23:52 -07:00
cfg.c	tools, bpftool: Poison and replace kernel integer typedefs	2020-05-11 21:20:46 +02:00
cfg.h
cgroup.c	tools: bpftool: Document and add bash completion for -L, -B options	2021-07-30 15:40:28 -07:00
common.c	Merge https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-07-31 11:23:26 -07:00
feature.c	bpftool: Only probe trace_vprintk feature in 'full' mode	2021-09-17 14:02:05 -07:00
gen.c	bpftool: Switch to new btf__type_cnt API	2021-10-22 16:09:14 -07:00
iter.c	selftests/bpf: Switch to new bpf_object__next_{map,program} APIs	2021-10-06 12:34:02 -07:00
jit_disasm.c	bpftool: Properly close va_list 'ap' by va_end() on error	2021-07-06 09:19:23 +02:00
json_writer.c	bpftool: Support dumping metadata	2020-09-15 18:28:27 -07:00
json_writer.h	bpftool: Support dumping metadata	2020-09-15 18:28:27 -07:00
link.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
main.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
main.h	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
Makefile	bpftool: Remove useless #include to <perf-sys.h> from map_perf_ring.c	2021-10-20 10:47:39 -07:00
map.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
map_perf_ring.c	bpftool: Remove useless #include to <perf-sys.h> from map_perf_ring.c	2021-10-20 10:47:39 -07:00
net.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
netlink_dumper.c	bpftool: Use consistent include paths for libbpf	2020-01-20 16:37:45 -08:00
netlink_dumper.h
perf.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
pids.c	tools/bpftool: Fix PID fetching with a lot of results	2020-12-08 16:45:20 +01:00
prog.c	bpftool: Avoid leaking the JSON writer prepared for program metadata	2021-10-22 16:44:56 -07:00
struct_ops.c	tools: bpftool: Update and synchronise option list in doc and help msg	2021-07-30 15:40:27 -07:00
tracelog.c
xlated_dumper.c	bpftool: Use syscall/loader program in "prog load" and "gen skeleton" command.	2021-05-19 00:41:31 +02:00
xlated_dumper.h